Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp369122pxb; Wed, 14 Apr 2021 18:06:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynYb4w+emFaTw7rHfhyHd9QA34E6amXAaBw80xD6Hzrj8aA6tf6wNkPZSuTXuUrCBoL7Is X-Received: by 2002:a17:906:b353:: with SMTP id cd19mr798743ejb.253.1618448810226; Wed, 14 Apr 2021 18:06:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618448810; cv=none; d=google.com; s=arc-20160816; b=yCqE+ClGR75l1xsAo26L2tsoB0+LG3GNjiV7lPWjO0vBvPF79XKhB/D1TsaWS/ne8a oiJ3s/scXAKxwg3pM3mdCUuBF7B54LFR8Vv8Rkk20uMqvnxikcf8F4po1wuu9Nh4tGb+ VhQqeZI3Ukvc5KD2aPVzNJ+S5G3EFZ97O954ylDJ2xCMM2BcGHT6PRFOdh/g+YgC7XxK Rrgq0aJBZY+TJy4XHu/fgnaVZLHPZRQGgxHoRQ8qCqtZKWd2UhqrXU+nNKDBnOEFA1qa fCjHXpe/9rySTjTH9+svpvqrinXeR4tBlpfdNd7/H7isu20SJ2tvhF+BtAFBex0RFCsN qXEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=DFlmD2IcGE8mdewprdvFzz8B8Jh3L7e3VAFDs4879yQ=; b=D8/kORy37NZYxbPuGc65iu0hSJgjrCDkoLuDUf0ewIQ0FxBHUu+NVxTpgzTLptAsRM ERh7S6msGOwgMUXBJWIwTpm/Uxgzrt4JwQMo0U1jnrvvCLo3xBrg9CtO/yBxKxXUylIt sXLqrYH09I3Il53f2QsQDmHiWZFo5MLu3VCBt/Lrhbr3mECUdngavixHFd8SQyEIJ4fu N4MJkukx7u4Dy7fLYIo/Qby0/8poqDG6l/DoK0GmuNfZgYEwRFCKDHA05ay8OHIqxoos OOzcz0TSuCKK0gI+YhX0tIfvPXqXR4Zral74Rzm093U0JxBwU190Hac3VkGlTQCJn32L a6AA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=sk3Ygg18; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w9si795446ejv.549.2021.04.14.18.06.26; Wed, 14 Apr 2021 18:06:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=sk3Ygg18; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230195AbhDOA2m (ORCPT + 99 others); Wed, 14 Apr 2021 20:28:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229926AbhDOA2j (ORCPT ); Wed, 14 Apr 2021 20:28:39 -0400 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3627C061574; Wed, 14 Apr 2021 17:28:15 -0700 (PDT) Received: by mail-yb1-xb2c.google.com with SMTP id k73so17885370ybf.3; Wed, 14 Apr 2021 17:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DFlmD2IcGE8mdewprdvFzz8B8Jh3L7e3VAFDs4879yQ=; b=sk3Ygg18PtzGk5rJnjmULucFP6fpxCnu0nbvFKkZ95Yvr9RmkNJubcEgPww1Tb4kYY m9KA4jxFaSwEc5lWiFdbqlm19r2GQmtA3OywBSzvS3E3zNgpQYxROth3niVXMezaxgIR yaCuxP8zeQJ+7OjqYVAxrxv7O5pHnU0yzyYw/y2/q3LM+rT63V0/An5GWurWxQDUpD07 twEUNV86TNjG1Ply771svk27/nn5Qw6uhMbIk9c4Y+kM+F8VFJHo06hqzGONNOOKI55/ oAq8DLScXpGi+rhU5F0rJn6k7j4+A27IADhpyQJsYzYfVv03BtonEMSo6hdG2KdZTtp1 9s4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DFlmD2IcGE8mdewprdvFzz8B8Jh3L7e3VAFDs4879yQ=; b=dZVsd5ggksUA+AF5UAhPZchHDR6/Xl9gzUmhSKRGhoR1GjpprTho0jWRzB2nIbWCIo 3qDNbOsB8V5/YNv/yqBCCuQz+w+Zvr+6jG20oq/aZmIS1iBmcqt8TzpG0ofWrD9E9kIV IYuv8vPDuh6DFR0xMUyt+pUwxQFCvLwBD9Te67B3QoFHaVem5ycL4MmG03I0h7ADFEF0 5Zyf/pBkzwfWk2CA4cbQNba3/ICB7iLn9uOFdG26+9HI2rLuR6C7jecrmCUwiZ2rHnHU sCXaEknTfowTamM+m1BkIsjRPDm95HcEdPsZdCjE9xNl+6pUE2eGxxdJIM+tC1ozAn/7 vmGA== X-Gm-Message-State: AOAM532TS3J7KUp/e/VytL+gsTXXFjN5VeC0fhdl9KtvR3HyCwym9fyF gfCcdpgdOyYkroNGlkrjv4K6rkSpQUn1lgGa0cI= X-Received: by 2002:a25:c4c5:: with SMTP id u188mr817891ybf.425.1618446495207; Wed, 14 Apr 2021 17:28:15 -0700 (PDT) MIME-Version: 1.0 References: <20210414155632.737866-1-revest@chromium.org> <20210414185744.y6x4pmnkqph5tmnb@kafai-mbp.dhcp.thefacebook.com> In-Reply-To: <20210414185744.y6x4pmnkqph5tmnb@kafai-mbp.dhcp.thefacebook.com> From: Andrii Nakryiko Date: Wed, 14 Apr 2021 17:28:04 -0700 Message-ID: Subject: Re: [PATCH] selftests/bpf: Fix the ASSERT_ERR_PTR macro To: Martin KaFai Lau Cc: Florent Revest , bpf , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , KP Singh , Brendan Jackman , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 14, 2021 at 11:58 AM Martin KaFai Lau wrote: > > On Wed, Apr 14, 2021 at 05:56:32PM +0200, Florent Revest wrote: > > It is just missing a ';'. This macro is not used by any test yet. > > > > Signed-off-by: Florent Revest > Fixes: 22ba36351631 ("selftests/bpf: Move and extend ASSERT_xxx() testing macros") > Thanks, Martin. Added Fixes tag and applied to bpf-next. > Since it has not been used, it could be bpf-next. Please also tag > it in the future. > > Acked-by: Martin KaFai Lau