Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp400074pxb; Wed, 14 Apr 2021 19:09:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxguUgdtbccMN5MrvF/5VLlEexGU72nI/UFc2q6/cBxwX9E3fJmWv1L1zxPli2nQzduG4F1 X-Received: by 2002:a62:7907:0:b029:23e:9010:3844 with SMTP id u7-20020a6279070000b029023e90103844mr1164626pfc.58.1618452544405; Wed, 14 Apr 2021 19:09:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618452544; cv=none; d=google.com; s=arc-20160816; b=0N6noP1jVZRTUiLkaX6EHpzuPTwo6xo3zo0O/TlifRIZ8ubt4Kv/VFXTAUS2tbsBYg hoXwU8CK4VoQLjjzbJdNqWWWHEsBLHmW6aTEOIgZLPoRkZ1n98eKDHdApq6Yq20odNdb L5H8dC1WrBlK+i5roDqCw7tiRZduk/g9dXDiCkmbwdutoHoTUFTLNbEI+/WrOojrVQwL rp1CYWzy28cTPNKf4xekno3eRi0hL8I1BcuhMBdUp8sP3rycTke5xn8FNcTT6aPWdMHJ jLc3KoABE5HHsJNCdkb8qbbo/YHl6oLYOpWztPSu53cv3pt+yzppgBUvHVTnvnYDqOIn qfjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=JqLpHGjz8FBfsB+oiUFw3oGbHf8VhZlWw288yxsMYis=; b=BWkvNnqWT6oXrNLNuA7CVfj8Tj7ovXnQNKthaoorwqm1FyXVOemq1GTY0iH+z5GD3d of0v6ND/RzevJ4joB3WFD8658zz0rjHqVPE+RtjOMS9+wFwKU5wSor5q9Ifvmb8eTYCB 3ck/pkpZMJSqcMWq+S+2xO2mJ6DEhJEfGFtEAXj1Qui07X16vq/ZG/Fp+YwjXXsUsT2s RdVmk/OGB4mkb0CwUYRUFHyPoHoSu2yVlrju5Qm2hrLwFNCOA2rLlWAuXTnQ0ra2KCEh Vdow+4d8OiH1ijGSdOohKTPPEHAgpTBM1zysf4zr3XL4oj6un8Jx+J1nxKblDpzjkG7Y YHxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kepstin.ca header.s=google header.b=VWtNrScH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=kepstin.ca Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m3si1499529pfb.52.2021.04.14.19.08.52; Wed, 14 Apr 2021 19:09:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kepstin.ca header.s=google header.b=VWtNrScH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=kepstin.ca Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229467AbhDOCId (ORCPT + 99 others); Wed, 14 Apr 2021 22:08:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbhDOCId (ORCPT ); Wed, 14 Apr 2021 22:08:33 -0400 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CDE9C061574 for ; Wed, 14 Apr 2021 19:08:10 -0700 (PDT) Received: by mail-qk1-x733.google.com with SMTP id d15so10760184qkc.9 for ; Wed, 14 Apr 2021 19:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kepstin.ca; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=JqLpHGjz8FBfsB+oiUFw3oGbHf8VhZlWw288yxsMYis=; b=VWtNrScHvqsJ9+VBK5repCCDNFK+b8SyNiz6DsD5iU9MSf/SFWFWvqbVIcZomSDRZZ fpcJbGUNy3WM6RSbnJORxrGHXHdL2rSYUeRWogG7bWoAbN3H7wBDofgFnPCEcW2AErm5 MuoGr5C3jHjbGDLFaV6P0Ep7TWCYTQnWj695U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=JqLpHGjz8FBfsB+oiUFw3oGbHf8VhZlWw288yxsMYis=; b=tVFX6WK+VPw7zFiS1T+RZZw5I/jq8mya8WDFahi13Ejy4DeAb8ZrS7jOd0AChENmyW /qgmkcCDXFyQT9TnOQ1/wuK3zzmYV+VT2u4ONwPe5pYzKBqG/S4Pm9N+pG8Yxxueryfj Lc7IQWb9abHFz8EVlW2Uxp4EcLoJcy+FgjeoRE5/o9Dq3uXSvf5e34hKUb5IHltFW/UM EA/NMdsZTJjhp/97CC5oF3dZuGAL9W/DYLk/RFxzuMkrZDXayxyqnm0J/YLLn4tVbaoU rSwxK9IuJh2Z0/K6aBWR6Prd5A/+aTnAUqGlz8fAL+SBJoDCNsN20AsIdEnuA245OYTW s/zQ== X-Gm-Message-State: AOAM530IusTYVq7KDIs59Q1txFzYBcPP5CpUst/GBDT0IC/ZxHEglpNP L53Yy0KqrXUt1UdxtFCZbOUjpw== X-Received: by 2002:a05:620a:15c:: with SMTP id e28mr1338013qkn.311.1618452489517; Wed, 14 Apr 2021 19:08:09 -0700 (PDT) Received: from saya.kepstin.ca (dhcp-108-168-125-232.cable.user.start.ca. [108.168.125.232]) by smtp.gmail.com with ESMTPSA id q17sm800305qtp.45.2021.04.14.19.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 19:08:08 -0700 (PDT) Message-ID: <07f5e30a2af1674f0a2f8995641bbaaf64e47d34.camel@kepstin.ca> Subject: Re: [PATCH] Fix turbostat exiting with an error when run on AMD CPUs From: Calvin Walton To: Linux PM list Cc: "linux-kernel@vger.kernel.org" , Len Brown , Chen Yu Date: Wed, 14 Apr 2021 22:08:07 -0400 In-Reply-To: <88d11c19e662f67ae492eb4b93e12e1b24e68c1d.camel@kepstin.ca> References: <88d11c19e662f67ae492eb4b93e12e1b24e68c1d.camel@kepstin.ca> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2021-04-14 at 22:05 -0400, Calvin Walton wrote: > The current version of turbostat exits immediately upon entering the > main loop, with error code -13. This is a regression that was > introducted > in these commits: > > 9972d5d84d76 tools/power turbostat: Enable accumulate RAPL display > 87e15da95775 tools/power turbostat: Introduce functions to accumulate > RAPL consumption Ah, I failed to check the mailing list before sending this patch! Terry Bowman's fix here should probably be preferred: https://patchwork.kernel.org/project/linux-pm/patch/20210331155807.3838-1-terry.bowman@amd.com/ My patch was simply the minimum necessary to get turbostat working again. -- Calvin Walton