Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp572450pxb; Thu, 15 Apr 2021 01:09:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOow2NFCsybj61+FheauJfkQTjSSvneaMysJEwz5URpPNku5Kb9zHJ7T/6wmzNHPDlbn+o X-Received: by 2002:a17:906:1d10:: with SMTP id n16mr2105043ejh.445.1618474152106; Thu, 15 Apr 2021 01:09:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618474152; cv=none; d=google.com; s=arc-20160816; b=VfzG4eRkPaA0zy+aKUVKkbFQlic3Y1ZmTN2kLME722KdOJDxi38hGpoot/70MSNhto zkV4F0zmcAMIAUBQ7hLMNTYnlbPQ7I/DIPTFaNhJkVJge/33XF6iAn77Ke03ofN1aEpZ z+lJEjJHI4BbTU5WSOea1oFrUmw5bSZYdIPgI+qSll51VY8YJU1vCVJCyhAcmkMK9iz3 Kx0veBby+lZ/QYm/m9rvlN+3m1Stc6nOuVewEhIYivvCVyIJ1BivQg05EJhQfoPmAIsM Kw5LRE1vi0pFArTAgZoDnUpROtDesn08r+sZe0hW5zfc+XQm4JuwxCcz4hUguM2M7l2j xQTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=b4x2zPRkrRtqYD5K5m2BlNAn5NndYRLGDDLyS1fbJuU=; b=MSwaDBpVZzv5YK/aJk4O8Pgaj7bA0FnCbG28ebaqNtt5UshwxGt2Pefp/6vS1tUSVR eyf38HQGwcNTtkMj3XrgAahh9HoKl4RrJ7t3jK4aZX/cyJgHluknSSu3UNes6EmGUNGF 2FIp69Grc6zaPlTn9OYZ8n+iMghs7vcAMXxzepLbWce13EfUjH3U/QaWcy2qjuCydZVZ KbhJWVhFRFyQnh0bOHfhJ10FwsFD6/QgF1Zyl5//twgiMV9EYjiThM4WoQF1khAEf8D0 UwdNRHnxB8iFrxsJ3xgKYHVZDIYyVHtD7gHZmWtp3MEAsdXGoYmqVWcwC7B74tZ3vaI/ 3g1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RYBB+myX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hq24si1490723ejc.24.2021.04.15.01.08.42; Thu, 15 Apr 2021 01:09:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RYBB+myX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231251AbhDOIH6 (ORCPT + 99 others); Thu, 15 Apr 2021 04:07:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230090AbhDOIH6 (ORCPT ); Thu, 15 Apr 2021 04:07:58 -0400 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFD11C061574; Thu, 15 Apr 2021 01:07:35 -0700 (PDT) Received: by mail-ot1-x334.google.com with SMTP id w31-20020a9d36220000b02901f2cbfc9743so21835651otb.7; Thu, 15 Apr 2021 01:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b4x2zPRkrRtqYD5K5m2BlNAn5NndYRLGDDLyS1fbJuU=; b=RYBB+myXB858Lk7tkbdh5mU04N9i99DeizzNjXvHxOIUpCjAHGTMTLMNqyeY87NzL/ bGTspbo2oybwrtD016LzzC6OkI90038kQbsOOxQYSCDhgnRs6glvizolDnak4Na2bxzd 9I+FtTzfiPfHUWPQbyY0/AUFaOpqYIz/HQlVNCPqCgmPmzb6jxSXZ+sFq8TUyMjoLsTI iubv8ZMfTbVb03Ywz/wNuortGXbKaG+FpsywjuN9uyBZJ2Qmy0QTocScuesgbkyCMbnb HjNXUsLVJGNg7+0fxrpuDXy4Ed02W/znc4LCrP/8CAEBAJ7GJ/6Kc3Dq/d4SM/nZrt0A kx+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b4x2zPRkrRtqYD5K5m2BlNAn5NndYRLGDDLyS1fbJuU=; b=I5R8gRnBteeRKQueiwPPIXXsrBsc0+j/qCnpw+1rmKog5RocqArR/w0jxUsy/ktADK 8w2Qe4NLTf+AC4VikWeCoh1BirRLy8FRPC1OFBX4jIGrwwlXsgl2p8YdRYZ+FZlH5xTl ukVGrpZFdm9I0Zuc6Lm3gaNQ+YHlk1doq6E8TSWL0XNdi2m6bP5OeWHf4EMvwEP24Oda uhO8ahWtdOrNOw58tXnauG1PgaocNHs0wMTuUz8uqjqEX8/ReLLjpllRuuwJ5Ka+a2OB tOJXQyn869zQhqcah8KhTbxTG5GHPuvhgZGW8f5Go8wGIji7zKTm4463wLHYrz17Eyog Quaw== X-Gm-Message-State: AOAM530H4QznizSJtS2ejaXDcY46OPOH0hlqzG3Iz54kFlwOZmQ45pZ6 fwkOHlOfiVvT/MGFqsDAQ4W0u63U50ggo7PVFjU= X-Received: by 2002:a05:6830:802:: with SMTP id r2mr1651505ots.110.1618474055310; Thu, 15 Apr 2021 01:07:35 -0700 (PDT) MIME-Version: 1.0 References: <20210414031240.313852-1-ilya.lipnitskiy@gmail.com> <20210414031240.313852-3-ilya.lipnitskiy@gmail.com> In-Reply-To: <20210414031240.313852-3-ilya.lipnitskiy@gmail.com> From: Sergey Ryazanov Date: Thu, 15 Apr 2021 11:07:24 +0300 Message-ID: Subject: Re: [PATCH v2 2/8] MIPS: pci-rt2880: remove unneeded locks To: Ilya Lipnitskiy Cc: Thomas Bogendoerfer , linux-mips@vger.kernel.org, open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 14, 2021 at 6:12 AM Ilya Lipnitskiy wrote: > Mirror pci-rt3883 fix from commit e5067c718b3a ("MIPS: pci-rt3883: > Remove odd locking in PCI config space access code"). pci-rt2880 shares > the driver layout with pci-rt3883 and the same reasons apply. > > Caller (generic PCI code) already does proper locking, so no need to add > another one here. Local PCI read/write functions are never called > simultaneously, also they do not require synchronization with the PCI > controller ops, since they are used before the controller registration. > > Suggested-by: Sergey Ryazanov > Signed-off-by: Ilya Lipnitskiy Reviewed-by: Sergey Ryazanov -- Sergey