Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210222132822.7830-1-kevin3.tang@gmail.com> <20210222132822.7830-7-kevin3.tang@gmail.com>
 <20210324112745.n76qhrbhzyfunmkd@gilmour> <CAFPSGXYK0Hi2-eYkukO2pNhHrJVZ=f79sj_hjXnGBZ_meVmkFg@mail.gmail.com>
 <20210407104854.fgn67pvau7dchcm2@gilmour>
In-Reply-To: <20210407104854.fgn67pvau7dchcm2@gilmour>
From:   Kevin Tang <kevin3.tang@gmail.com>
Date:   Thu, 15 Apr 2021 08:19:44 +0800
Message-ID: <CAFPSGXbJwNd47UAwVu4c1t5K7j4sgMtTLtDZ15woHZbRTghVfA@mail.gmail.com>
Subject: Re: [PATCH v4 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver
To:     Maxime Ripard <maxime@cerno.tech>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        ML dri-devel <dri-devel@lists.freedesktop.org>,
        devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Maxime Ripard <maxime@cerno.tech> =E4=BA=8E2021=E5=B9=B44=E6=9C=887=E6=97=
=A5=E5=91=A8=E4=B8=89 =E4=B8=8B=E5=8D=886:48=E5=86=99=E9=81=93=EF=BC=9A
>
> On Wed, Mar 31, 2021 at 09:47:12AM +0800, Kevin Tang wrote:
> > > > diff --git a/drivers/gpu/drm/sprd/Makefile
> > > b/drivers/gpu/drm/sprd/Makefile
> > > > index 6c25bfa99..d49f4977b 100644
> > > > --- a/drivers/gpu/drm/sprd/Makefile
> > > > +++ b/drivers/gpu/drm/sprd/Makefile
> > > > @@ -1,5 +1,8 @@
> > > >  # SPDX-License-Identifier: GPL-2.0
> > > >
> > > >  obj-y :=3D sprd_drm.o \
> > > > -     sprd_dpu.o
> > > > -
> > > > +     sprd_dpu.o \
> > > > +     sprd_dsi.o \
> > > > +     dw_dsi_ctrl.o \
> > > > +     dw_dsi_ctrl_ppi.o \
> > >
> > > So it's a designware IP? There's a driver for it already that seems
> > > fairly similar:
> > > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> > >
> > Our dw dsi controller is not a standard synopsys ip, we have updated a =
lot
> > on the basic ip version,
> > the entire control register is different, i have cc to drm/bridge revie=
wers
> > and maintainers.
>
> You should make it more obvious then in a comment or in the name of the
> driver. If it's fairly different from the original IP from Synopsys,
> maybe you should just drop the reference to the name?
Thks, i will be fix it.
>
> Maxime