Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp587739pxb; Thu, 15 Apr 2021 01:36:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyB2ublhXs8HbvQQz/gj5nE0vMLsj1jxJVCYhagS+G5IlTG6X4QXmloV/FsBvkpIbeUIWk6 X-Received: by 2002:a17:902:7c8a:b029:e6:f010:a4f4 with SMTP id y10-20020a1709027c8ab02900e6f010a4f4mr2700228pll.17.1618475776391; Thu, 15 Apr 2021 01:36:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618475776; cv=none; d=google.com; s=arc-20160816; b=iV/IDMxt1LxzF6uVkuSluy/aksOpgH/ft+Zns7J09UgylJ9bcOyriKMEmGgmgaTyZ7 xij8X31NYavWIr/e71vm5uUdJbubJkOorm73hvmwZN75fQXbM0F6FJ2UD1nZ4jlZ4nrN LgMERy7V5u9aJ4bOHCsdwpAZOnFJi7ugFdPTChI88MFYqux+YsRoZ1937OyZrkdLWqHK GZJp6P9fCCzuozAg9ShgUmQZnm5ZxjkkJNJeqkIABsaZpKR3Iw9xse6hCTIlydO0sw+P kOPPRaFWpG2FrwMFrpT7D18qQGMPwwnE0LoqlDXbyCnNnpZ+b2pwZ1BiGEmEmCsAQPwO TuAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SrF/vsV4j4L4GAt5abbAQBWTA61BTin9EKhsssuCVGI=; b=NqWwH57qZ6kbbu5EeSomjK1V5U1HI3SDpwD1urA0pkjt/LRVwA4ru0TgreAJR3wRYD 2Gr8vxi1vesZE/gLqYVyzrxQD4E45364Fd+Q9XpPJCnETVMsu8pxISIZfiNE6EW+P9xr gByaogRhwhdT54o7zpLSE0mVsg7mTO29c2YMTDO9a3fEeMbVd8bsFO/xCSlZjoZCziGi 8Tp3IuJXYSPzPP0VCxp5+Ai9Gu/0QvxZoKFIzNrzifajlzBNKYhn9gbELOxt/An45CxW rRWsNHFGD8ghb5bRbjyZUBulnQGHq/kc2mDdFgmZJ5tmEd0Bd7G1sTmIgtej1PRrMtQv XiGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mhnkGNtK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t10si2412389pgu.154.2021.04.15.01.36.03; Thu, 15 Apr 2021 01:36:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mhnkGNtK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231688AbhDOIf0 (ORCPT + 99 others); Thu, 15 Apr 2021 04:35:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:33326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230090AbhDOIfZ (ORCPT ); Thu, 15 Apr 2021 04:35:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 24073601FD; Thu, 15 Apr 2021 08:35:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618475701; bh=8QUuqpA7nbNGk3YzMcAbRg8vAX4zEmHRY5lwyMMpeLs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mhnkGNtK9NV0W0N6DL46mPQVNA1II/S2zRQX9QfWfR/9TYJjG+nHgooLzTe2mTW/Y 6hqyUeImYxZEQfMVwTiI9UV45qScSePtFoJwg1/4NObt1d4C1vBT6sT4NoIk8NjCmW svmrS+lJ2n3W5tfYj7bweOp3DOxnTt62t+Pxurh8= Date: Thu, 15 Apr 2021 10:34:59 +0200 From: Greg Kroah-Hartman To: Alexander Shishkin Cc: Andy Shevchenko , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] stm class: Replace uuid_t with plain u8 uuid[16] Message-ID: References: <20210414171251.14672-1-alexander.shishkin@linux.intel.com> <20210414171251.14672-3-alexander.shishkin@linux.intel.com> <87sg3sfzl1.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sg3sfzl1.fsf@ashishki-desk.ger.corp.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 14, 2021 at 10:14:34PM +0300, Alexander Shishkin wrote: > Greg Kroah-Hartman writes: > > >> Using raw buffer APIs against uuid_t / guid_t. > > > > So you want to do that, or you do not want to do that? Totally > > confused, > > My understanding is that: > 1) generate_random_uuid() use is allegedly bad even though it's in their > header, > 2) poking directly at the byte array inside uuid_t is bad, even though, > again, header. > > It is, indeed, not ideal. > > If agreeable, I'll update this patch to the below and respin the whole > series. You are showing that Andy wrote this, when you are the one that did :( Anyway, I've dropped this single patch from the series and applied the rest. Feel free to send this patch as a stand-alone one once you have the authorship issues sorted out. thanks, greg k-h