Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp595033pxb; Thu, 15 Apr 2021 01:49:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjPNdDJNz15KubSsqms7OlV4OR71Qlcezj+bMpNnsS/rxb5HeXADccz3hjyVVvg8eohjbj X-Received: by 2002:a17:90a:ff06:: with SMTP id ce6mr2663096pjb.204.1618476590595; Thu, 15 Apr 2021 01:49:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618476590; cv=none; d=google.com; s=arc-20160816; b=fdVbMXPGf5t/OBkUc0WTZw+7V32Anvmot7RGZwY1jEgUEtWwBvsjilN2VULdl9G+pZ URzXwFa3iTAwsJyxzd+BkzuaII6nThuv3LKSAaVkP73g8jmZIbwLytEDR241dcJ+jwMn 4zdsAkrQwbgvqC8Zge3gGoZZLu+IV8okVeYpSlx/fIRfdWAK4H5kQuxb5XgvS3PijnK6 Nts+sM9uvgQK+iMTppQ90H8YBj/e+Xzrvr0irFSf2rzlZrr38ksrQ3IacjOBEkd6zQ/N azm3S4EECpkDjuj0ac+4y6vZmZHCQG9XZweUutUNRTvS6fvopKVxuUpC4QBMSd/1lpI6 s1Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=9EqqgG+q8KzPD6ybwhaMMrl+lTUL1ThiaE2usmOBrbU=; b=frnLCeq0l4GKbh35/qSyWw9SYtRccpK/HgziWQna1o3JEoQ5NGZ6nIUXKdERGvbCYG Jd3FOFIF6pY1eQ65K1/u6LiM3JMM8DXP0VVIQp8Cr9bBJXhe/G1envgKbDMtjDwWFg73 v/xsfzeDc2Ak6NIAoIiGTPX5DlVpx8g/J7HA34Gc6TXfX3HFSVFJ8S0iO81Cp2mZGwEv z3CWyLQMHQL0HybMlS2yDn0uLKHXfWfhAmbVRKfa9B6b9hjqSbuM6NKvGqpl6CfeQxX0 1xIhALvHg0jshnRKnvkWpskPdJ9IHCK2i8+FY8YgWLdosngHGM5ydcJ/YWCj1L/mBcZO 9F/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vfEhPcBu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b8si1542201pjh.136.2021.04.15.01.49.38; Thu, 15 Apr 2021 01:49:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vfEhPcBu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231856AbhDOIt2 (ORCPT + 99 others); Thu, 15 Apr 2021 04:49:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231512AbhDOIt1 (ORCPT ); Thu, 15 Apr 2021 04:49:27 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58B9AC061574 for ; Thu, 15 Apr 2021 01:49:05 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id b17so16440780pgh.7 for ; Thu, 15 Apr 2021 01:49:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9EqqgG+q8KzPD6ybwhaMMrl+lTUL1ThiaE2usmOBrbU=; b=vfEhPcBuw6/bl7NR8nCxzGsao6TLi2NirGNNZYMBz1Indy9smfYatKTzZBrgZHQBu1 8IiRk896u8QitG0cES3OJ+6NbD88dhnRq8dUAMeGL9PsGUY0FXKGXceJ1lupog7yc65P 4ZSp99yAV2pgT5UM3+Cx+tic3/jpNk+vFbLnEFYKohVTigzttQn1xG0LhY7mXuLAnfK5 yzoQlvW1vPRjDeO7vW+9iJtyxJ5GNoZtvJPd4AY9j+DUVurXRKFUTLwHhFLKe8+wTFM2 kbaI6Z4EawlksGBRwcGusRiQQaz5oTwDR8jYlpDL56n/uUlK/tG8gGTTI1CL089VCrn2 RWRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9EqqgG+q8KzPD6ybwhaMMrl+lTUL1ThiaE2usmOBrbU=; b=SFxpFBCDqasDgrQYEPjqywG9VfyfHsgeWGimVhnnLb5ZnFu1h69RiZsGP3GLeb41T4 GKWbrxIVctK5Lb2ZLtDGNdTudJgyXSwBk9Z5ke9ZqEnOpGL94Hi+F1qVGpyx/+Zbj4gc QQZiv6e/9yMJZGZMjaVcsfIuI0SmV3Lv48s5I/FLVw6Oy5SQ6YRFgBmirbT4iutKjVm5 0Kck/SmVLHpz24BpUhi+oDECopxCxxLhG/pOVYR+Htp2bTKj6OSxHu+MuNoLAE3ZP7e8 rH1zif0OR/LVQw2PWNlQUH8QRZ7EWNBspeBpmVI/PsZYklH7w3t/dmPI3fBta3kGVEYw OWOg== X-Gm-Message-State: AOAM530Krz1PiQ0m3zi9S5jAIAGcWSprCznrdY4+hd07nlL4M0CMIodC GQlWjKxIGa/NohZhQfZ01jXFy99Va09kmIYZH20= X-Received: by 2002:a62:5c6:0:b029:24d:e97f:1b1d with SMTP id 189-20020a6205c60000b029024de97f1b1dmr2218277pff.40.1618476544690; Thu, 15 Apr 2021 01:49:04 -0700 (PDT) MIME-Version: 1.0 References: <20210414171251.14672-1-alexander.shishkin@linux.intel.com> <20210414171251.14672-3-alexander.shishkin@linux.intel.com> <87sg3sfzl1.fsf@ashishki-desk.ger.corp.intel.com> In-Reply-To: From: Andy Shevchenko Date: Thu, 15 Apr 2021 11:48:48 +0300 Message-ID: Subject: Re: [PATCH 2/7] stm class: Replace uuid_t with plain u8 uuid[16] To: Greg Kroah-Hartman Cc: Alexander Shishkin , Andy Shevchenko , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 15, 2021 at 11:35 AM Greg Kroah-Hartman wrote: > > On Wed, Apr 14, 2021 at 10:14:34PM +0300, Alexander Shishkin wrote: > > Greg Kroah-Hartman writes: > > > > >> Using raw buffer APIs against uuid_t / guid_t. > > > > > > So you want to do that, or you do not want to do that? Totally > > > confused, > > > > My understanding is that: > > 1) generate_random_uuid() use is allegedly bad even though it's in their > > header, > > 2) poking directly at the byte array inside uuid_t is bad, even though, > > again, header. > > > > It is, indeed, not ideal. > > > > If agreeable, I'll update this patch to the below and respin the whole > > series. > > You are showing that Andy wrote this, when you are the one that did :( > Anyway, I've dropped this single patch from the series and applied the > rest. Feel free to send this patch as a stand-alone one once you have > the authorship issues sorted out. Internally it was proposed by me as well, so authorship is correct. -- With Best Regards, Andy Shevchenko