Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] iommu/amd: Remove performance counter
 pre-initialization test
To:     David Coe <david.coe@live.co.uk>, linux-kernel@vger.kernel.org,
        iommu@lists.linux-foundation.org
Cc:     joro@8bytes.org, will@kernel.org, jsnitsel@redhat.com,
        pmenzel@molgen.mpg.de, Jon.Grimm@amd.com,
        Tj <ml.linux@elloe.vision>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Alexander Monakov <amonakov@ispras.ru>,
        Alex Hung <1917203@bugs.launchpad.net>
References: <20210409085848.3908-1-suravee.suthikulpanit@amd.com>
 <20210409085848.3908-3-suravee.suthikulpanit@amd.com>
 <VI1PR09MB26380EED406F2F08ACB6B5BBC7729@VI1PR09MB2638.eurprd09.prod.outlook.com>
 <add9d575-191e-d7a6-e3e1-dfc7ea7f35c8@amd.com>
 <VI1PR09MB2638289727E1854B5CE7A3AAC74E9@VI1PR09MB2638.eurprd09.prod.outlook.com>
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
Message-ID: <df6c8363-baac-5d97-5b06-4bcd3163f83d@amd.com>
Date:   Thu, 15 Apr 2021 16:28:16 +0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.1
In-Reply-To: <VI1PR09MB2638289727E1854B5CE7A3AAC74E9@VI1PR09MB2638.eurprd09.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.252.73.101] (165.204.80.7) by KL1PR0302CA0019.apcprd03.prod.outlook.com (2603:1096:802::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.6 via Frontend Transport; Thu, 15 Apr 2021 09:28:24 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ad363763-dc14-45e0-34b5-08d8fff0d2fe
X-MS-TrafficTypeDiagnostic: BYAPR12MB3127:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR12MB312781E4EE222BA100C47C12F34D9@BYAPR12MB3127.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 6ev0vHDstD17iTGL0tVACRu/IBK5US5kn1kL+NEl6afg26XtgI3QUwi7po1tcev21emB9wZRlNnfIUkGZsEFR3lMRYNKczfIPVzkXktwDgxDwkldRyX69Cr8yGBNp1sWV1zD+Q/2kM24/yoFWbC9imoiJWO+pjeIM4p7qGU8jMe2g80aXbGT3GU0ee1bw3WacC/QX5+eBeFhcPSi3HSCaUKjV/FQoKIyvpEhXzPlgH4wlwms2HGpanOMX9mu+Qg4i0fEdWq/a6w4JwXjbd3jqzoXlWRZjFCMVdCmdr5dVagOqD+4J5s0iOUGOZQhg0K1VHqeRgEathdyaKLAqwSAguUJ0git7R8swcRk4wW6LI2HTpwPLPz8XMziQtkWla4NzbpvQ7/jyuajf5Jt6an5I/spFp8WXoMSkxYospdSgMU8C4Ywk51v1Vpky6DyN8lGr5H0RRkDQYJjsEAo9Iiseo9O73bJEEZZV0Vnayiy4SEaLA+ls2FLsiEDsXlcJjfbLXsZlwMwXiBU1Ds9I2clrfI3P29jhfMvdv+GA7bKlKdOaSwr3ZRFoKgvHhghXtEcjblHOAoZXALdsNynxpHWL3RLP2dnP8hclozdPVIJCZVwBbbmt6KVT0tSwXquZkgLgIEdKDeNQc8CLLJ62MQ7DagQhDRhaM9ryDBxmvmAcaqGRP6qZNVgwsohsqRXT96NEXKouhEvRgrWIs8R8/QaqxTlbkgPYIyl4jgwxSANg86e4O5dzKDcSPGXYI92PRlZ
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR12MB4597.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(396003)(376002)(346002)(39860400002)(7416002)(8676002)(54906003)(86362001)(186003)(4326008)(53546011)(478600001)(316002)(16576012)(83380400001)(6666004)(2616005)(2906002)(36756003)(6486002)(956004)(8936002)(66556008)(38100700002)(16526019)(31696002)(5660300002)(52116002)(38350700002)(31686004)(66946007)(66476007)(26005)(34580700001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?TXcybkZQRjVib3JMbzF6VnlFUnBDUnhJQ3VxUnRiWDhuamgyT01tZjBjZ1dv?=
 =?utf-8?B?aFhnbUV5ZytRalBVWHY5dlZXZ1lOdU04d1h1am8rRllxSXdNc0RTNzBCZTdH?=
 =?utf-8?B?RXh2TjB0UTUrU1A2SDAxMWcxeEpVQVRZWE1vbHBRVlU2amdRNTUzbGYzUXJK?=
 =?utf-8?B?MTBOckFWdGtZeVd4ek1WNzB5MkMwSzlMbXhiTEZnSk9oYi9ybysrc010bFl3?=
 =?utf-8?B?eGVqQTF2SWhSeWFjeXlaMGozVUo0ZTZWS3ZHa0J2alY0Tk56MGQ3cnRPeVho?=
 =?utf-8?B?TGJuOS9BbFZzSS8wQmhacXYrZ2VURDVrSU1FdXZhYTBxTjEvS3ZoQTZzSVFu?=
 =?utf-8?B?eXA1ZldJbm5iTEUydCtuTlVpSi8wSEJjajNhbndUeUpFck53ZHF0SGljM25l?=
 =?utf-8?B?WWFvNVVndXl0QTNuOVdneW5XM2IzNzBUUXlSUDFWbS9mam5xMGJJRGY0Titj?=
 =?utf-8?B?M2o1Vk5ldFdScGZJWjY3MGx4NUdUYmZxRWRYaXZhdmZVUHNCQm02WndTUk5z?=
 =?utf-8?B?ZTR4SmpKYW00eWpqWmxRZmo4ZXdTdDRrSUV2c0FDUHpPdWVuSGU2R080K2x5?=
 =?utf-8?B?cStVcXRHNDNiamNKWHpsN1hacVlLRlIvaFFJUjdJWjJQZDhDV1NSMW1OUnhE?=
 =?utf-8?B?cGg2c1NvUmVOai9KeDJGaVJyc3V0aFJvczd0WElKTllJU1o2d01kUnp0cWQw?=
 =?utf-8?B?YVcxZTdKSElzeUozaWdKSWtldDd6UXY2czdrNGJkSVRCWlVacjVOSE1Ya1gz?=
 =?utf-8?B?aEdLbS8wcmJ5TTNkeWwvUUoreEhZcnE3bWs1SHlqOFdIWXVXNVJNVC9tZUNh?=
 =?utf-8?B?VzlwV1JTbjRvNm0yQjBMNWxhT1hPaHhWakljQitKVG92bmgwVzdkaEsrS0M1?=
 =?utf-8?B?dHB5REpjcENlTkJxWmtla29nTlE1SFBzc0xLd1FON3UzYUlWd3NQU09OWVJi?=
 =?utf-8?B?TVVsN2RDZEJRS3BMSmFXUzhZbXgxNS8yUm51anltckZqT0ZydTlScllqWks3?=
 =?utf-8?B?bWFURk9sdnlLR3dUT1pMOWJmSDhjazJ2UDNEanpUZ0FRcTVONFY2aUx0RzNm?=
 =?utf-8?B?dEZTbDhjOUhIMXhwMnFZU0FaNDd4cnBaKzMyRWYwTVBKb0FrZEdxbFlSbDc3?=
 =?utf-8?B?OEFKby8xKzUxOTAvLy9jYVNUZFdHU2ttMWlUcWh4TUxsZEZsVWxhRDVYdFhH?=
 =?utf-8?B?ci8vcU04eTVjdnNPN1FLSVcxMFY5SVBTNjJ4bmtQemRVYzIrSUVJSkEzRS9U?=
 =?utf-8?B?a0hJaW9LUGQwOFMzRno4Z0pjQVE1Skw0QkgyQ3ZWc0NjMlRrWjBpY3BpaXJX?=
 =?utf-8?B?YWxPeWJ4L0RjeUFMVm9pUXl1WjY0dC95QkZoZDgzLytsclg5WUdLZFFlTVg1?=
 =?utf-8?B?S0ZHT2craUlOUmpDYjJrM1BmNmMwcEFiYnM0eVlPWEZvU0tnM0piNXhhaU5k?=
 =?utf-8?B?MW8xQ1dOajJOS00rMEQ1cUtONm1uRWxUVEtJUjZyMnEwcElweG01dTJ2clpH?=
 =?utf-8?B?NVpIWStqWG1TemVwWGhnVXYvWmhxRnRnWWJpVGkraGUwaXI3UmlMOFZEbEU5?=
 =?utf-8?B?Y2IwTVJuKzZMd290UjkyN0JWcGtxNTVQUnVIRVBTcVRMcUhPRFI1UDl5S1Vm?=
 =?utf-8?B?QVd3aEhFblczc0FMczJLTDJZM3Z3Q2xHZG40eTU2UUl2UmxvdWhiWWNkSzRv?=
 =?utf-8?B?dy9IR2IxU3RuZkNiT1FCdFM2TW9ydmtoLzcxVVpDWUJkU1BUQXpZcmh2Q2No?=
 =?utf-8?Q?/nFsKHVFYFYcVF3SQfpZak8CJM4+yPDCsIsSj89?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad363763-dc14-45e0-34b5-08d8fff0d2fe
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4597.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2021 09:28:27.3112
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7BL9XppsCZ1dNKqySx1KS9K1HewcVAqT5jx3W28fyPGcK3o2D1xTZ2lol/ToWNIfHdSFfmjkVFLgcdXp61KVaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3127
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

David,

On 4/14/2021 10:33 PM, David Coe wrote:
> Hi Suravee!
> 
> I've re-run your revert+update patch on Ubuntu's latest kernel 5.11.0-14 partly to check my mailer's 'mangling' hadn't also reached the code!
> 
> There are 3 sets of results in the attachment, all for the Ryzen 2400G. The as-distributed kernel already incorporates your IOMMU RFCv3 patch.
> 
> A. As-distributed kernel (cold boot)
>     >5 retries, so no IOMMU read/write capability, no amd_iommu events.
> 
> B. As-distributed kernel (warm boot)
>     <5 retries, amd_iommu running stats show large numbers as before.
> 
> C. Revert+Update kernel
>     amd_iommu events listed and also show large hit/miss numbers.
> 
> In due course, I'll load the new (revert+update) kernel on the 4700G but won't overload your mail-box unless something unusual turns up.
> 
> Best regards,
> 

For the Ryzen 2400G, could you please try with:
- 1 event at a time
- Not more than 8 events (On your system, it has 2 banks x 4 counters/bank.
I am trying to see if this issue might be related to the counters multiplexing).

Thanks,
Suravee