Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp628980pxb; Thu, 15 Apr 2021 02:50:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTgSanlhUXiViSGKzkoxvWyxZW5TUaNg9bGpDnFhVs9Qs2YhVeFa1UxEgJs0UIUr0TTIw7 X-Received: by 2002:a05:6402:5252:: with SMTP id t18mr3165386edd.258.1618480258773; Thu, 15 Apr 2021 02:50:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618480258; cv=none; d=google.com; s=arc-20160816; b=CvFZOp0eN5CJ+b82Zv9YgcB7Nx5GG/THea8rQ1K5L+k5/aLZJTlmUbPok9AwDrJLFn FsI/HtZoQGSWS7DeQEICZiW6FDZxbP0wIufe4mIeEUcaeFAPsJqJcgGlnSCIxw3GaAoV NP4NltOTdb/pGdw2+rbVpnFkNWHMuT+NuOojfm38H7hGZMYpqhSIw7vDQ2aPa+DLl1hf 2+rCFNl/ffP412icaA8cQwJ62H9F2ibeB4NvsTdq/iQGRFdWKbZJaRYsjf1vU7FAWXY8 hFx9UgNNbDnRegDHUBUZnWYV0ryrQqEfGhsPskn0WALvuiiDS2xaJ2pCJc8sWL03mO4I kqcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date; bh=kdwRZ3B/pB+XI49FbxnFqN2mdJ3h4Oic0/Hg3V0EdM8=; b=WCjSm+4aQtDEbEuLAOhmcdz/ChZxR7YQjDRS7E69zDkAPd4hVcSdvllKnX4I5pps8B SnDRow367hIjv7Vlb/Vw+dNntDtlmLQ2RinOCSYwdKtBpmvQTTXpSHUEoPMQtZ+aX8gS P4EO+cQUwOjLObwyOQQalJExs+Eg+/iHGEvm1HpNsmDuBW8kaMABQJApCh13Px7CtT+s XFbkVsHROOj7v8A8ho4BDEp9B+krXHK+f30+B1s9mvxd7H7NRcFZZxkw6szoAvLKHIML +n8nxLj/qcgwHukPaTFwQQBgd8klBnnv3yUlLJu+xo9fQyFzQMDlQM2W2xrd4VKIxwKc 9Q/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n3si1662077ejz.565.2021.04.15.02.50.34; Thu, 15 Apr 2021 02:50:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231862AbhDOJr7 (ORCPT + 99 others); Thu, 15 Apr 2021 05:47:59 -0400 Received: from vmi485042.contaboserver.net ([161.97.139.209]:36878 "EHLO gentwo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231809AbhDOJr6 (ORCPT ); Thu, 15 Apr 2021 05:47:58 -0400 Received: by gentwo.de (Postfix, from userid 1001) id 377C9B00679; Thu, 15 Apr 2021 11:47:34 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by gentwo.de (Postfix) with ESMTP id 3652AB00673; Thu, 15 Apr 2021 11:47:34 +0200 (CEST) Date: Thu, 15 Apr 2021 11:47:34 +0200 (CEST) From: Christoph Lameter To: Wan Jiabing cc: Doug Ledford , Jason Gunthorpe , Kamal Heib , Alaa Hleihel , Valentine Fatiev , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kael_w@yeah.net Subject: Re: [PATCH] infiniband: ulp: Remove unnecessary struct declaration In-Reply-To: <20210415092124.27684-1-wanjiabing@vivo.com> Message-ID: References: <20210415092124.27684-1-wanjiabing@vivo.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Apr 2021, Wan Jiabing wrote: > struct ipoib_cm_tx is defined at 245th line. > And the definition is independent on the MACRO. > The declaration here is unnecessary. Remove it. Correct. Reviewed-by: Christoph Lameter