Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 15 Apr 2021 13:47:11 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc:     Colin King <colin.king@canonical.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Arunachalam Santhanam <arunachalam.santhanam@in.bosch.com>,
        linux-can <linux-can@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] can: etas_es58x: Fix missing null check on netdev
 pointer
Message-ID: <20210415114711.fqxj2j744fmqw6pb@pengutronix.de>
References: <20210415084723.1807935-1-colin.king@canonical.com>
 <20210415090412.q3k4tmsp3rdfj54t@pengutronix.de>
 <CAMZ6RqJvN10Qf7rg-Z1aD82kJGPqueqgr+t88=yoJH93m+OuGw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="t7rubfvizd7wa7y7"
Content-Disposition: inline
In-Reply-To: <CAMZ6RqJvN10Qf7rg-Z1aD82kJGPqueqgr+t88=yoJH93m+OuGw@mail.gmail.com>
Precedence: bulk


--t7rubfvizd7wa7y7
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 15.04.2021 20:42:36, Vincent MAILHOL wrote:
> On Thu. 15 Apr 2021 at 18:04, Marc Kleine-Budde <mkl@pengutronix.de> wrot=
e:
> > On 15.04.2021 09:47:23, Colin King wrote:
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > There is an assignment to *netdev that is can potentially be null but=
 the
>                                            ^^
> Typo: that is can -> that can

Fixed.

> > > null check is checking netdev and not *netdev as intended. Fix this by
> > > adding in the missing * operator.
> > >
> > > Addresses-Coverity: ("Dereference before null check")
> > > Fixes: 8537257874e9 ("can: etas_es58x: add core support for ETAS ES58=
X CAN USB interfaces")
> > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>=20
> Acked-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>

Added to the patch.

Tnx,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--t7rubfvizd7wa7y7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmB4J70ACgkQqclaivrt
76kHtAgAr2VHjyVKYe8lsy62ZU9S+BhaUtOfaHJF8shAcpOeiyBIJyAaxExUjGri
xEmOffCtfWmRmuk3sWLczgQ5690LfMZIGCz2n5zJZ2wjxUywNnWFCKY60pWKhYly
kR2GVviWErqSq5V2ibkj7qCgQCtMAPsQinJx4YbSmw37xVFaluCZfDobiznLs0Xk
ZLgpCXK4kzXrI0ZpoVJ4Lpc4lz7eF/l9z62oUlAxBGx0b2lIe4ogRPIzKG7gGci8
CZY+aWMUGOVNkdcO2gm/9bPH9Ot58QAS1Y1D0FPX4lxRgKr7TRtT7QQl3gof/9ik
LaFtRQ7qWKpbaVTLiOgg0Mu9bbfJpg==
=qXQD
-----END PGP SIGNATURE-----

--t7rubfvizd7wa7y7--