Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp800466pxb; Thu, 15 Apr 2021 07:00:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwdVbvAxdVavE9uJYF6Vk5W53yTleB8pPXS5fZ2PLIeSs92z0/sf0rwe/0MxWsLBgWsRfk X-Received: by 2002:a05:6402:3550:: with SMTP id f16mr4380659edd.134.1618495215055; Thu, 15 Apr 2021 07:00:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618495215; cv=none; d=google.com; s=arc-20160816; b=Ozmy/N/wpZJ8JmL1pkrNIVKnh/1t3jeFpGLB9NRLLekTFo6i6DY5Tz1VtDSJ1l9nhW rGwA4REUezrS/vD52YCFp4D9Ig6uJpQ4qd6OBzJC30ScYxUQxSHi5+BqFAwinr1JBrlW KmdbV49AOTo0dRlGKG1smye5/8BdWiZqia5Sj3urQhn4B19YiEDif2Y+xRPvo+4hmoH4 YbAYtSYdT8GKE9rg5emV4WcktLylmAJ0AEr7TRNO/COlnvsMZf2ggfLlvvt+6Colz4A/ m2TAPI2HF/LArjhcTVkvWBDEYPWIimYKiZWOacLsDauH/pjY52iHri6oVsotquGUgIqV p6jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=xBHA/wHC3df+8VK2A/kqYRa1Jk9aBpuu5mwzFS7+Kis=; b=KOrzHiYVWFnOg1xJcnfnvp85pT6/tpmucg8EiZJS9lRMa3p4AuxHxZ11aw9sd3NmNw 0hkk2NMsV59tOlb5Gn4Tgy89h9Wmig2fgXuxyeFDMIvoIwuGK2V8wy/5YwZIa/n/oRBq ppemFVUZ9DpZJKwruUXKfdD9KeuXSPMYPGTek1mFHQhmHcTkUotMd/UOGUiOHouVcrfA Re8BkkCIMgUrlIGyM7E4TWDFkyNsXolKm2KsHnJBlMEq4/7oavF2J2sVDYSdSr9Htrt/ c+jkpP0obBiafnyVpPuQY4wfrA1DEjZm7D4G28yb7TBqRQZht1n/LgLY3XaDU1afx4F+ StqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cq5si2552996edb.80.2021.04.15.06.59.49; Thu, 15 Apr 2021 07:00:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233134AbhDON7S (ORCPT + 99 others); Thu, 15 Apr 2021 09:59:18 -0400 Received: from mga17.intel.com ([192.55.52.151]:60059 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231549AbhDON7S (ORCPT ); Thu, 15 Apr 2021 09:59:18 -0400 IronPort-SDR: CkolhUsRVbRTZ7UKT7r4VIbAwBhMhXg5SromWdjeazFTA+H6yiorYf8mumGVKuMfeqEOpnnctz k9rvN4HbosBg== X-IronPort-AV: E=McAfee;i="6200,9189,9955"; a="174961472" X-IronPort-AV: E=Sophos;i="5.82,225,1613462400"; d="scan'208";a="174961472" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 06:58:53 -0700 IronPort-SDR: 1Ero4IpCmY7zN/BTHjiLpTX2bZF4Yh00EOPhGr04YRY+PryaHh50jCkmxU7H3tJHVBvXgIoVkE ovqkuIFI+rDQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,225,1613462400"; d="scan'208";a="425186820" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 15 Apr 2021 06:58:49 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 7C258BA; Thu, 15 Apr 2021 16:59:05 +0300 (EEST) From: Andy Shevchenko To: Dan Williams , linux-nvdimm@lists.01.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Vishal Verma , Dave Jiang , Ira Weiny , "Rafael J. Wysocki" , Len Brown , Andy Shevchenko Subject: [PATCH v1 1/1] ACPI: NFIT: Import GUID before use Date: Thu, 15 Apr 2021 16:59:01 +0300 Message-Id: <20210415135901.47131-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Strictly speaking the comparison between guid_t and raw buffer is not correct. Import GUID to variable of guid_t type and then compare. Signed-off-by: Andy Shevchenko --- drivers/acpi/nfit/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index 958aaac869e8..6d8a1a93636a 100644 --- a/drivers/acpi/nfit/core.c +++ b/drivers/acpi/nfit/core.c @@ -678,10 +678,12 @@ static const char *spa_type_name(u16 type) int nfit_spa_type(struct acpi_nfit_system_address *spa) { + guid_t guid; int i; + import_guid(&guid, spa->range_guid); for (i = 0; i < NFIT_UUID_MAX; i++) - if (guid_equal(to_nfit_uuid(i), (guid_t *)&spa->range_guid)) + if (guid_equal(to_nfit_uuid(i), &guid)) return i; return -1; } -- 2.30.2