Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp808614pxb; Thu, 15 Apr 2021 07:08:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNNbdtDOCeGACLWnK3DlXFhOSaL01XMX6/W8oQFgjJU7PIDQQTKQyhx6xHpL/ZAOyU/9Kr X-Received: by 2002:a17:906:1313:: with SMTP id w19mr3625186ejb.64.1618495712947; Thu, 15 Apr 2021 07:08:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618495712; cv=none; d=google.com; s=arc-20160816; b=u+Yk2M69/mcv8Bw5QAiBlj29jaEjqg/bKTPMffvTIptiEyeHr+2RLhUoq8lIOZuVuP 9/lNXJ5ttDo5D+gfPxaLmGfyVPbrBshFxkyu9LUUPh86bbQya5kFvVKv6gD4dpj9fHGt HJko6n8Vj0uALEdIjJx61FPHSyECLV0vXU+1jdq8OklDutp6RACZD950DKEudC5WHskp /bmqCU4UreCNGpYQRS7ALx3yUPv3J300N4z7Klq+JkDVeIEEjGwfNegJdP0f99m0Btj+ 33ZX6Skpex1A4y3YXTdIt13VBZ9OSYvkDR/L/B1xRESj5I2rsVGW9/zyAW01AzLozmft JpXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=KzRZVFNb/tVjZ4zVD8dN9LPR+RtfZo+UyOgJpDh0Z4s=; b=T6MnixtG8pKCRg4W7OjspdRc5GNE0x3KOe2dJHUoibW1/WLBz6l/84/GZETCkReMeA KJH+0fstVgfufdPBmLR8rKMgXeqeRD2olUMidHImy0jK2csEJUeor13dUjYyIH2UJ/Qy 3Oy3H/xTf45u6IzISznsZQtVsxzPe8YoroxLdkCA0VKWGlButkNX0lI3Ad5TD43pFIc4 poBs5WuDZnFeFbkGORCbBeFgsfaDa+BOPLP34u3NR4fwwGMz+epkB2iPKlSLCAgILuZ3 Np9AfMQoRFxUo1Iq3lSdRitj8K1BiWRmnfKCRw5qvt1GC8UuwUjMWZ9YQGpOZkUKn8NU tp3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@xs4all.nl header.s=s2 header.b=TDecdCDC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y3si2334323ejo.374.2021.04.15.07.08.05; Thu, 15 Apr 2021 07:08:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@xs4all.nl header.s=s2 header.b=TDecdCDC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233436AbhDOOFJ (ORCPT + 99 others); Thu, 15 Apr 2021 10:05:09 -0400 Received: from lb1-smtp-cloud8.xs4all.net ([194.109.24.21]:46207 "EHLO lb1-smtp-cloud8.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233428AbhDOOFI (ORCPT ); Thu, 15 Apr 2021 10:05:08 -0400 Received: from [192.168.2.10] ([84.202.3.209]) by smtp.xs4all.nl with ESMTPA id X2bnl3mgIsMyaX2bqlUPit; Thu, 15 Apr 2021 16:04:43 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1618495483; bh=KzRZVFNb/tVjZ4zVD8dN9LPR+RtfZo+UyOgJpDh0Z4s=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=TDecdCDCnvBoJTXlUHSwQF8Md5dtl6+yBQGGnhr5XIoX9KijaCJnxt9TrGkZiekpj eBiEXJMoTZPsS6be4+fI+xZPF6lBXLtU0bMDYJA5wTwvHvHCfnsy7PXwZxBOjGiPiu juPf0rMUJ7fWyjS8d/g1OwEBR8sngKtx4a55bvEi5/M7zu8dZR7PNq0Tn5XnE95XBZ uPGqNXzgdPK0YNG+LhEio2CQqDBca40WoJQ2IjCLD1Ps/RQ1QyEz69gM7QctVuxM1u wHFT6vURMtdVZo9edRhdNV6FGRGtdUDIX+s4ZU729IzPnBQvw+GrNgm6Km2CXfEepi 818TJWQtd2zoA== Subject: Re: [PATCH] staging: media: tegra-video: Align line break to match with the open parenthesis in file vi.c To: Aline Santana Cordeiro , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com References: <20210414130939.GA15290@focaruja> From: Hans Verkuil Message-ID: <72418471-9cd9-e271-e125-3196ff589891@xs4all.nl> Date: Thu, 15 Apr 2021 16:04:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210414130939.GA15290@focaruja> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfO+qT6QUSM93GsLUJm9b5upqI50NiYAuIw6wYQFkThBjMjREGCEovLzuZoCyvenBZwSjvIvFDDYW7nBu5t947gzu89ScMktX/5dgZWcF0re6VWYHh1II YG5YEXGqHOpcRvg0RrlLgO2xaZIYnCPkcazYplsdBCrE0F4NPBeBTWLt/K2zqDOkVWPrNyNVIPKQnvr3llObyKUm6umX5vS15SoYT65olJSAmcOzBfgH3Bqa dZILwEJIKuOLLQZ1/zGfjCLldcAAHsIBR6kCA5b78Y0Y0kIv0WH0EH8zTrep+MucdNV2Nop8HJpK597kIbAznJabRoy14KyqbjQTGew4GxzlLIyrsVnXMZXL Jbio8qF1plTUK6RWIkYR47DuvXLmV65cBOVyI6Phla5+Ac3Y4zF/a1FIFy2grdZ8erBCgQeez9AJLIUPGfSiNCHqsFzkcHXgmemkhZUvAykuvmaSz7ecQF9/ gZKe2cRlzY84a0zY5miuS6N2WTtXimapfues0oURDOZ7C5eeZvBwW0vJQOXjZDIQD6EUdr8yy8BkhxcJ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/04/2021 15:09, Aline Santana Cordeiro wrote: > Align line break to match with the open parenthesis. > Issue detected by checkpatch.pl. > > Signed-off-by: Aline Santana Cordeiro > --- > drivers/staging/media/tegra-video/vi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c > index 7a09061c..9878d1e 100644 > --- a/drivers/staging/media/tegra-video/vi.c > +++ b/drivers/staging/media/tegra-video/vi.c > @@ -1813,7 +1813,8 @@ static int tegra_vi_graph_parse_one(struct tegra_vi_channel *chan, > } > > tvge = v4l2_async_notifier_add_fwnode_subdev(&chan->notifier, > - remote, struct tegra_vi_graph_entity); > + remote, Add this line to the previous line. That looks a bit better and is one line shorter. Regards, Hans > + struct tegra_vi_graph_entity); > if (IS_ERR(tvge)) { > ret = PTR_ERR(tvge); > dev_err(vi->dev, >