Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 15 Apr 2021 16:11:06 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     "Jin, Yao" <yao.jin@linux.intel.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v3 12/27] perf parse-events: Support no alias assigned
 event inside hybrid PMU
Message-ID: <YHhJeuYMA/0Jof55@krava>
References: <20210329070046.8815-1-yao.jin@linux.intel.com>
 <20210329070046.8815-13-yao.jin@linux.intel.com>
 <YHgdixeqOu2NarkC@krava>
 <132fc848-7252-0d7f-4a5f-020e8f79012e@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <132fc848-7252-0d7f-4a5f-020e8f79012e@linux.intel.com>
Precedence: bulk

On Thu, Apr 15, 2021 at 09:36:16PM +0800, Jin, Yao wrote:

SNIP

> > > +	int n = 0;
> > > +
> > > +	list_for_each(pos, list)
> > > +		n++;
> > > +
> > > +	return n;
> > > +}
> > > +
> > > +static int parse_events__with_hybrid_pmu(struct parse_events_state *parse_state,
> > > +					 const char *str, char *pmu_name,
> > > +					 bool *found, struct list_head *list)
> > > +{
> > > +	struct parse_events_state ps = {
> > > +		.list           = LIST_HEAD_INIT(ps.list),
> > > +		.stoken         = PE_START_EVENTS,
> > > +		.pmu_name       = pmu_name,
> > > +		.idx            = parse_state->idx,
> > > +	};
> > 
> > could we add this pmu_name directly to __parse_events?
> > 
> 
> Do you suggest we directly call __parse_events()?
> 
> int __parse_events(struct evlist *evlist, const char *str,
> 		   struct parse_events_error *err, struct perf_pmu *fake_pmu)
> 
> 	struct parse_events_state parse_state = {
> 		.list	  = LIST_HEAD_INIT(parse_state.list),
> 		.idx	  = evlist->core.nr_entries,
> 		.error	  = err,
> 		.evlist	  = evlist,
> 		.stoken	  = PE_START_EVENTS,
> 		.fake_pmu = fake_pmu,
> 	};
> 
> But for parse_events__with_hybrid_pmu, we don't have valid evlist. So if we
> switch to __parse_events, evlist processing may be a problem.

you should use parse_state->evlist no? but we can chec/make this
change in next itaration.. it's already lot of changes

jirka