Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp835033pxb; Thu, 15 Apr 2021 07:43:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwlCmqT2pRzC6EF6P7JS30JYihlYsevkI0nZ+N14BQFL3I1wR8z+tYIfZbNBu3jRyfv52U/ X-Received: by 2002:a17:902:e8d5:b029:e6:cabb:d07 with SMTP id v21-20020a170902e8d5b02900e6cabb0d07mr4188442plg.3.1618497803891; Thu, 15 Apr 2021 07:43:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618497803; cv=none; d=google.com; s=arc-20160816; b=LdKd0R8BwnSN39U2ZS+EqT4He1iJc4r4XjdvAA9uZM6eNu7oeDWQf2ypYBebKgJsiz oO0dvW8nV9fulvItnK6x9eNsiiStoVQoKUNu6FyeK5oP2HqhY8MwyLn5RvOQfB4+5zOe 5xw0O7lJU1WOHnGRDZRyvOmjaUIz+/iTZmR3dVXMRa18Gz6Mu4wXFraTDqKEtLUFcoJF qRLug1G4hq1xN83c9h9TMhdc75IkjNGF76NI9qqeKSfqIx91q8y9ygo8SgJSpLCM7jeJ bRcVYCro0GJPVrjEI5LhWMeefpQfyxBpRLXA9jyN5Wvs5IsBNUHbDqWfHsLLdZ/+LP1T g5eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zikLCvg8Vxn2oRzUzqk3+0E7GCS6qdh2A26rpggGqOM=; b=NaGXdwR1gdOwvCSBrVcqcC3h42T2nb75f3bfu+5y2e1d8Bkh05A3x+sDZjuhNBYG0p J+0XFXiMvy0EFzKZP1egcc7C+4Uf30iLOvHOB6jvbChsKgAUBVVHw5CSop4ZHDaSTiW2 YbRinFiy8a5DQYCQgFLBfqa3hjKIlKePGzRsHDxOvyHWWO8KahlsM8RhooNmHu800XA7 o3gydGL6dtquNioRjUKWu/5dAyatx3LL7KK1lfQbbAVqL/GTY2wbwB8z2qrcxvl7EuiJ Bb3koc5s/vf3VXDG3dbtcpBipmv/35mNar9KH0VtRKT/NbAWUYMrvU9JppYXrESJVHWg 5QWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=GI2XyNCZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 34si3462205pjo.12.2021.04.15.07.43.11; Thu, 15 Apr 2021 07:43:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=GI2XyNCZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233349AbhDOOm7 (ORCPT + 99 others); Thu, 15 Apr 2021 10:42:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233201AbhDOOm6 (ORCPT ); Thu, 15 Apr 2021 10:42:58 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F33BC061574; Thu, 15 Apr 2021 07:42:34 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3DD6989A; Thu, 15 Apr 2021 16:42:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1618497751; bh=k+IQUeSEYm1M3FFyJ2PXsEYwB8+VDm1H6a7nr/uK4Bs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GI2XyNCZXM9QT6cYE4wKtBBgpjxWlnf+46yux+Bl8X6OTHU+ERIQau2ZVIAV50AVW dGSmh+hkw9jwvhGckd61GrigbYhXswNKzR1IQ2gkG47lk+LjO5liUBlDwWHf1SuAi/ LmSJLlVbDz58Sv+Y7HncWMqGOe+8TiHS4stq0tjc= Date: Thu, 15 Apr 2021 17:42:29 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: Geert Uytterhoeven , Magnus Damm , Kieran Bingham , Rob Herring , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/7] dt-bindings: media: max9286: Re-indent example Message-ID: References: <20210415122602.87697-1-jacopo+renesas@jmondi.org> <20210415122602.87697-2-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210415122602.87697-2-jacopo+renesas@jmondi.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, Thank you for the patch. On Thu, Apr 15, 2021 at 02:25:56PM +0200, Jacopo Mondi wrote: > The dt-bindings examples are usually indented with 4 spaces. > > The maxim,max9286 schema has the example indented with only > 2 spaces, re-indent it. > > Cosmetic change only. > > Signed-off-by: Jacopo Mondi Tested by applying and verifying that `git show -b` shows an empty diff. Reviewed-by: Laurent Pinchart > --- > .../bindings/media/i2c/maxim,max9286.yaml | 214 +++++++++--------- > 1 file changed, 107 insertions(+), 107 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > index ee16102fdfe7..0e7162998b77 100644 > --- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml > @@ -191,140 +191,140 @@ examples: > #include > > i2c@e66d8000 { > - #address-cells = <1>; > - #size-cells = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > > - reg = <0 0xe66d8000>; > + reg = <0 0xe66d8000>; > > - gmsl-deserializer@2c { > - compatible = "maxim,max9286"; > - reg = <0x2c>; > - poc-supply = <&camera_poc_12v>; > - enable-gpios = <&gpio 13 GPIO_ACTIVE_HIGH>; > + gmsl-deserializer@2c { > + compatible = "maxim,max9286"; > + reg = <0x2c>; > + poc-supply = <&camera_poc_12v>; > + enable-gpios = <&gpio 13 GPIO_ACTIVE_HIGH>; > > - gpio-controller; > - #gpio-cells = <2>; > + gpio-controller; > + #gpio-cells = <2>; > > - maxim,reverse-channel-microvolt = <170000>; > + maxim,reverse-channel-microvolt = <170000>; > > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > > - port@0 { > - reg = <0>; > + port@0 { > + reg = <0>; > > - max9286_in0: endpoint { > - remote-endpoint = <&rdacm20_out0>; > - }; > - }; > - > - port@1 { > - reg = <1>; > - > - max9286_in1: endpoint { > - remote-endpoint = <&rdacm20_out1>; > - }; > - }; > - > - port@2 { > - reg = <2>; > - > - max9286_in2: endpoint { > - remote-endpoint = <&rdacm20_out2>; > - }; > - }; > + max9286_in0: endpoint { > + remote-endpoint = <&rdacm20_out0>; > + }; > + }; > > - port@3 { > - reg = <3>; > + port@1 { > + reg = <1>; > > - max9286_in3: endpoint { > - remote-endpoint = <&rdacm20_out3>; > - }; > - }; > + max9286_in1: endpoint { > + remote-endpoint = <&rdacm20_out1>; > + }; > + }; > > - port@4 { > - reg = <4>; > + port@2 { > + reg = <2>; > > - max9286_out: endpoint { > - data-lanes = <1 2 3 4>; > - remote-endpoint = <&csi40_in>; > - }; > - }; > - }; > + max9286_in2: endpoint { > + remote-endpoint = <&rdacm20_out2>; > + }; > + }; > > - i2c-mux { > - #address-cells = <1>; > - #size-cells = <0>; > + port@3 { > + reg = <3>; > > - i2c@0 { > - #address-cells = <1>; > - #size-cells = <0>; > - reg = <0>; > + max9286_in3: endpoint { > + remote-endpoint = <&rdacm20_out3>; > + }; > + }; > > - camera@51 { > - compatible = "imi,rdacm20"; > - reg = <0x51>, <0x61>; > + port@4 { > + reg = <4>; > > - port { > - rdacm20_out0: endpoint { > - remote-endpoint = <&max9286_in0>; > + max9286_out: endpoint { > + data-lanes = <1 2 3 4>; > + remote-endpoint = <&csi40_in>; > + }; > }; > - }; > - > }; > - }; > - > - i2c@1 { > - #address-cells = <1>; > - #size-cells = <0>; > - reg = <1>; > > - camera@52 { > - compatible = "imi,rdacm20"; > - reg = <0x52>, <0x62>; > + i2c-mux { > + #address-cells = <1>; > + #size-cells = <0>; > > - port { > - rdacm20_out1: endpoint { > - remote-endpoint = <&max9286_in1>; > - }; > - }; > - }; > - }; > + i2c@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > > - i2c@2 { > - #address-cells = <1>; > - #size-cells = <0>; > - reg = <2>; > + camera@51 { > + compatible = "imi,rdacm20"; > + reg = <0x51>, <0x61>; > > - camera@53 { > - compatible = "imi,rdacm20"; > - reg = <0x53>, <0x63>; > + port { > + rdacm20_out0: endpoint { > + remote-endpoint = <&max9286_in0>; > + }; > + }; > > - port { > - rdacm20_out2: endpoint { > - remote-endpoint = <&max9286_in2>; > + }; > }; > - }; > - }; > - }; > > - i2c@3 { > - #address-cells = <1>; > - #size-cells = <0>; > - reg = <3>; > + i2c@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + camera@52 { > + compatible = "imi,rdacm20"; > + reg = <0x52>, <0x62>; > + > + port { > + rdacm20_out1: endpoint { > + remote-endpoint = <&max9286_in1>; > + }; > + }; > + }; > + }; > > - camera@54 { > - compatible = "imi,rdacm20"; > - reg = <0x54>, <0x64>; > + i2c@2 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <2>; > + > + camera@53 { > + compatible = "imi,rdacm20"; > + reg = <0x53>, <0x63>; > + > + port { > + rdacm20_out2: endpoint { > + remote-endpoint = <&max9286_in2>; > + }; > + }; > + }; > + }; > > - port { > - rdacm20_out3: endpoint { > - remote-endpoint = <&max9286_in3>; > + i2c@3 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <3>; > + > + camera@54 { > + compatible = "imi,rdacm20"; > + reg = <0x54>, <0x64>; > + > + port { > + rdacm20_out3: endpoint { > + remote-endpoint = <&max9286_in3>; > + }; > + }; > + }; > }; > - }; > }; > - }; > }; > - }; > }; -- Regards, Laurent Pinchart