Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp844822pxb; Thu, 15 Apr 2021 07:57:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxaVEvo6NwGLF4chtuuTh4FNvXPdXBVdXqSQBXo8rpiCSEJFaMhLT0zTNBC+NQGWJOIVXB0 X-Received: by 2002:a17:90a:a789:: with SMTP id f9mr4534111pjq.192.1618498643769; Thu, 15 Apr 2021 07:57:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618498643; cv=none; d=google.com; s=arc-20160816; b=oEFOkpAQ94ALAFfWEjfYNWVPS0zdrxgalF7IGz+3twJHPSia29BXU/vxH8EV+RstII VKju6XSzyT5OUcLKdKfEgiwRv/a+mCfsn409YX9YClnSUpNQ6XaJSdhYz/W/dZIdtLVF YRjmKeWPbF05r+psocOssZY/8VDKhaqtAvUUiQ7S9vzWmPmoUZIRD/m3SsgIIa+CcMjG +Hxtg2uk3Dd5+FloClywitMVqDv2fm1zo+kg1maenPGDZRWhpS3GCpoHJyNwJgrkPCdN leOkmBtRvUzIpV4e6qEZRQ8ejn7uY6Epehi2yfX4Ec6FXEhDoc2yIf/HVpGBNtCeObGm 1TmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=v2Or3xICyiqCWSxc7wSGSWZGmIO5mcHsrHauPLbBJ7U=; b=c6OtUIF7tubCPwvvDU/vzzw2h0jysEwx9dx6FdwDkd7p8tnDzX+nwSfaK1yx6A2H7n DOUpSb9H2Z629eQPCAeZZxQkgS2YrdHnjue4uCQgAHA4uyCE2t+s3zG3InccRP9qQ078 UQU0Q5AVM3sX8UU84rkEvgjQE+TeVDUsEvdUb2Ej7n/1+3+BP+a5DjKRnWxB5lClRrKY 2gdTDaSvlFP+ck+AnMwyYdXBLQ62pJRn+LFkgbioxh4aMj4I8ef4MOtYiq1lLmb/nJ4l 5ekKrkR/ZlSBE9IAxsSE9z+YiHGAro2gkj4ExDaf/pyucc708P/ZoKgIrr0agOO7W6ZO +b6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=L0ALyEji; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h6si3402508pji.39.2021.04.15.07.57.11; Thu, 15 Apr 2021 07:57:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=L0ALyEji; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233936AbhDOO4b (ORCPT + 99 others); Thu, 15 Apr 2021 10:56:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:39614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233953AbhDOOxc (ORCPT ); Thu, 15 Apr 2021 10:53:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DDEBF613D5; Thu, 15 Apr 2021 14:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618498338; bh=aZpCNt2XF25QtCJu1iUt7ziUpIDpur/9IVskh4YRI9U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L0ALyEjiTMSHBgt66u2XxzOQ3uSKakM/59GQZ+Oyi2dhssrdPDlYNUTT+OIX9oVo0 EDjZF4lNNG4sC314comsCetTdSH862nVS6qGO7bYiBdrsLNp0BOor9x4CJ1d9iBeFz sEL5FicncbEyw4wh/H3/XVoDL9EujzBKC2Hz26uQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+28a246747e0a465127f3@syzkaller.appspotmail.com, Pavel Skripkin , "David S. Miller" Subject: [PATCH 4.9 31/47] drivers: net: fix memory leak in atusb_probe Date: Thu, 15 Apr 2021 16:47:23 +0200 Message-Id: <20210415144414.466627824@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210415144413.487943796@linuxfoundation.org> References: <20210415144413.487943796@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Skripkin commit 6b9fbe16955152626557ec6f439f3407b7769941 upstream. syzbot reported memory leak in atusb_probe()[1]. The problem was in atusb_alloc_urbs(). Since urb is anchored, we need to release the reference to correctly free the urb backtrace: [] kmalloc include/linux/slab.h:559 [inline] [] usb_alloc_urb+0x66/0xe0 drivers/usb/core/urb.c:74 [] atusb_alloc_urbs drivers/net/ieee802154/atusb.c:362 [inline][2] [] atusb_probe+0x158/0x820 drivers/net/ieee802154/atusb.c:1038 [1] Reported-by: syzbot+28a246747e0a465127f3@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ieee802154/atusb.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/ieee802154/atusb.c +++ b/drivers/net/ieee802154/atusb.c @@ -341,6 +341,7 @@ static int atusb_alloc_urbs(struct atusb return -ENOMEM; } usb_anchor_urb(urb, &atusb->idle_urbs); + usb_free_urb(urb); n--; } return 0;