Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp845165pxb; Thu, 15 Apr 2021 07:57:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJZTrYl89KJoYH3DBdpqtm1Eqn+8yljIly+ndHGBNB/V3FmiHiawqiCT7QQx0udab9l/Zj X-Received: by 2002:a17:90a:e2d7:: with SMTP id fr23mr4221431pjb.29.1618498673785; Thu, 15 Apr 2021 07:57:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618498673; cv=none; d=google.com; s=arc-20160816; b=NcZHaUu3EXQDM6QjmSnUgF2xUJ//0eZ/8/NSkYIHOPnjTuEy6yajKGjTRa7pmrCI87 a0EZPRzFjrCGKFYJrFiZSlF7Yh0EplwMA2+MC2iNSTeT3pSbfomdkzpVD4EY7T6TN4En lmiR/b8IYOPUMEsJKqeQm65+/TfKQk8ZbG+fJNmEvLUtb2iqsCpqS4WA56eNxuYsFXf/ 39cx0DZAXxWzhEckltv4XNVANY5JIgeyjEkesBEeVn2MvQiukhcaoEjH5CsXV8k6Hc5B CLjEzoiX1j2shv3mBb1/ebkJ/QvgrMEYdOAc9p0FLbXMF5lIN+BRVP9gLXCCKP5K7t4H 4J2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=o2YfXwo+2MVVEQQdEI/Qz+OdvFFfq88cHF9xPTNM1dc=; b=j7ooH7bv5r4DeDRiaSpAuSQAmeRcccfXNlFOlRstnKRvPg/mp7+i8zTENSr1vdzT7k ATXMmxkl908CyZYQNx7gL1xLbwINK1Dbfm3iDsbCCljfIX0Y7cmb6FIRfPZVD1ZRUTcc 5+ZP+kkyFS3BF+HpWQqDryEq2CiGdnGL7QnPGsFXLOEU1UQEAyw9j0JSR4ZVOpzECVFS bcECLXembAcgQTBSEifgJVxgDaqJJdZMXx3Q0TYky+iRy5hTQfL8hLYKCLlIeQaUW7cL lEKfG5f56jaixHOWKKaUUYvDJJlPKlJ4LgReycUFU6DHL9nt0Zq7xkGeEp4prqf9cotV 54yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RKSvdldT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c11si3485801plo.141.2021.04.15.07.57.41; Thu, 15 Apr 2021 07:57:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RKSvdldT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233996AbhDOO46 (ORCPT + 99 others); Thu, 15 Apr 2021 10:56:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:39858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234282AbhDOOx5 (ORCPT ); Thu, 15 Apr 2021 10:53:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7329C613D7; Thu, 15 Apr 2021 14:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618498352; bh=2W8o1gYyf2lPNJY4lrbNxni64c6yxSIkHaHfmmrXssw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RKSvdldTIq91Q/i1PW+iHk6BByyvC7a2xl+v+qY++erhkz8ARFyndxT3jvP5qYXSI gk1IjuQNJUgSx9xqKWxEe1+chUG/gXL75uu4TR6/Plp0hj4aQCfwWeJFlYKVsROaEz y29UBh2ozTyWUTKA8M3SZVGt+rQbUztHpuZepM9g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+d946223c2e751d136c94@syzkaller.appspotmail.com, Alexander Aring , Stefan Schmidt Subject: [PATCH 4.9 36/47] net: ieee802154: fix nl802154 del llsec dev Date: Thu, 15 Apr 2021 16:47:28 +0200 Message-Id: <20210415144414.615063660@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210415144413.487943796@linuxfoundation.org> References: <20210415144413.487943796@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Aring commit 3d1eac2f45585690d942cf47fd7fbd04093ebd1b upstream. This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVICE is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+d946223c2e751d136c94@syzkaller.appspotmail.com Signed-off-by: Alexander Aring Link: https://lore.kernel.org/r/20210221174321.14210-2-aahringo@redhat.com Signed-off-by: Stefan Schmidt Signed-off-by: Greg Kroah-Hartman --- net/ieee802154/nl802154.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -1796,7 +1796,8 @@ static int nl802154_del_llsec_dev(struct struct nlattr *attrs[NL802154_DEV_ATTR_MAX + 1]; __le64 extended_addr; - if (nla_parse_nested(attrs, NL802154_DEV_ATTR_MAX, + if (!info->attrs[NL802154_ATTR_SEC_DEVICE] || + nla_parse_nested(attrs, NL802154_DEV_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVICE], nl802154_dev_policy)) return -EINVAL;