Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp845459pxb; Thu, 15 Apr 2021 07:58:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzofekY29FIjvFumKn2h7Enhdr5FoEAkjTk1/QeZ5VwhRN/yJJ5XU17fP/C5t4VWbDAmk3O X-Received: by 2002:a62:3486:0:b029:24c:34c0:3c7a with SMTP id b128-20020a6234860000b029024c34c03c7amr3659098pfa.36.1618498703896; Thu, 15 Apr 2021 07:58:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618498703; cv=none; d=google.com; s=arc-20160816; b=SzVmJ/YbK8X8SUqU0gZIkyQTWl1oKuZXTrxW3n66OnzYRV1cGeZx5Mz0L1zc+41YmL GiQo92BcwYIcDwxVtAUoPZjkmkF7jt4bxufDiujq9F7trbEEQP1Qrg7gLMmfhei4bzyY sH05WCb+XmR+1kXzP4izDTSc4lRTrehmLBHIXRy0k89SbQdB9V/5kUz3OOXuUA1wjQtj GlkqqIWnFfn5sYPWcsY2S4l6xKClgiCSdPxG/gy3cUsbpV54J2os2cb8asl7AE53LiCs H6q9syoA3gQ7mIlLmkydG95TGCu8KGdddOau8OfnPUnc26b4fmX54V/vc8NuOKPnH4wF ADvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mZH1fFBXveVCPTPMOVWdC+EswXnHmWE+vJhU7CXkYak=; b=o5P0VXyEYOiZFqyO65WMCI4W0PtLdQESHMxsgIHvVvjMLl+drk4fSP3poGh5mik3mp DlJQl/fgGrnSuNTNS4skubSVrmielE815diPNLH3B8xyK4PdpncZbIR9sy5mqgwZeSBj eCs08ug4jx3QYjtNQq9xME9Hh6LQ4c9TG/jLZRyQpQYICHo99mIFNl82ckAMwiXThhnb ZLO9jGTxaBIsU46tpjBLr6NI4GU7SMavvXlcIBqUTTZykpndHXMQWHJZakAYlThxsY3R yxCfKG0JYHQ+dd+u40zT2eJMjTwtA3onGCB8/c4jycLAk73IjGxojKbfL6hFIxnuTWq4 fnDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=acChM1YB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 34si3462205pjo.12.2021.04.15.07.58.11; Thu, 15 Apr 2021 07:58:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=acChM1YB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234220AbhDOO4z (ORCPT + 99 others); Thu, 15 Apr 2021 10:56:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:39830 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234280AbhDOOx4 (ORCPT ); Thu, 15 Apr 2021 10:53:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 940456113B; Thu, 15 Apr 2021 14:52:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618498349; bh=adwfwwQMdygbQVB+/u0sDbUshgQoaHvxg2kwUrTHzro=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=acChM1YBoaEKp2Ee8xqBmKdIZPojrk8Fo5gPDR34xC37AJQfOHAKfXaBXH0XSvxq4 XrJF0b3uPp30C1li032cG9dIqo4bFAJIGzswjSnE1COfpNsoMvoDuXzRm8qS/NgqFN O5nOS9z0x+uvPzWakeRrmKwwH8uGWfK4FQy/Fr58= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+ac5c11d2959a8b3c4806@syzkaller.appspotmail.com, Alexander Aring , Stefan Schmidt Subject: [PATCH 4.9 35/47] net: ieee802154: fix nl802154 del llsec key Date: Thu, 15 Apr 2021 16:47:27 +0200 Message-Id: <20210415144414.584873414@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210415144413.487943796@linuxfoundation.org> References: <20210415144413.487943796@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Aring commit 37feaaf5ceb2245e474369312bb7b922ce7bce69 upstream. This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_KEY is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+ac5c11d2959a8b3c4806@syzkaller.appspotmail.com Signed-off-by: Alexander Aring Link: https://lore.kernel.org/r/20210221174321.14210-1-aahringo@redhat.com Signed-off-by: Stefan Schmidt Signed-off-by: Greg Kroah-Hartman --- net/ieee802154/nl802154.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -1627,7 +1627,8 @@ static int nl802154_del_llsec_key(struct struct nlattr *attrs[NL802154_KEY_ATTR_MAX + 1]; struct ieee802154_llsec_key_id id; - if (nla_parse_nested(attrs, NL802154_KEY_ATTR_MAX, + if (!info->attrs[NL802154_ATTR_SEC_KEY] || + nla_parse_nested(attrs, NL802154_KEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_KEY], nl802154_key_policy)) return -EINVAL;