Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp845893pxb; Thu, 15 Apr 2021 07:59:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyAgLYgLAoYyyK9n+LNGGwA0DRR0NEcH5k2xb/oE/EnEnlLV2VQ1VXgXDgsuNq2AoS0TOw X-Received: by 2002:a05:6a00:1651:b029:241:afa4:92b1 with SMTP id m17-20020a056a001651b0290241afa492b1mr3416184pfc.12.1618498746594; Thu, 15 Apr 2021 07:59:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618498746; cv=none; d=google.com; s=arc-20160816; b=xEDug94beTzZ/x6zT9enimoz5oSc0hkvqe41DXz4a4crkPK3RzCQEYg5DZfdyFmMc8 TcoMObZaCvdt/laevPOnZ54XwgPbNZzQa9m9gHkqw/vPOQbEvZQ2RSHajPFj3nPT/+kw 2l8Zs6uxyUhwuEp8xR+diDmApolB1RXQBOdXmJKgb3P4QZOMJErWGGsft0maMaQ4qJGv k3xLW00PFRf9+uh8fpw/D0EDqojuiVMW6H++ubC0mQpAigwW5uXChc5MBl0a/LFcxcYm cL6upf9KkB722toapojWvKpfz26RzWduMTNrfaBfVKOd2sz0Rfa+flp22CC5JaDudAoU 106A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Hhgkt0S4+CTGrp+9NOiYWgL+Rqqa9Y1efy3So7PqY3E=; b=pXp9S96Ql4K5nrHL3G8Bnxg5Grq9xsSv1Gvl+7Cr/mo/PEX4G9N7rWkjz5TnDjN0M2 wlhUipeWcLh1PFaHKhBeben/X3Q8suPie7J6oGA1EAErtFK3Q181ICd1pT9eO4O8lEFJ HqEz1IRKYjDFX32/Lex/D7idoT3RSnJNPW2IpyUXaED/qVzr6CL+M9INgxJWfmm1Fh9P 0CvRSV109BGUKuW+u9z3oAMvhiXSdscn9iwsdg5O6Qe6Fa9LbZZaBKZxHxocr43fKtWG DrN8vHLAIAr4lyUiTJ/5G+Q2nIJpe45RoKIi8Nne1M6JF6pY0SecC34dq6El0douCKHv ZiPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aoY6Fs5o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l14si3193887pgc.150.2021.04.15.07.58.54; Thu, 15 Apr 2021 07:59:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aoY6Fs5o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234466AbhDOO47 (ORCPT + 99 others); Thu, 15 Apr 2021 10:56:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:39920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234284AbhDOOx5 (ORCPT ); Thu, 15 Apr 2021 10:53:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 09B6B613D3; Thu, 15 Apr 2021 14:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618498354; bh=hXjEIDFshVrp9ActqGejmA9MCrvITxzEh3EaBUalbZU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aoY6Fs5oo1HIee0SCMifJvQ0LtJeko2spUAMEFjytYnbEw1MKkMhXO4wLfKZJ62rl FKQn7DG928s3sTotHpjIQhRZRIufodveD9EILeVF3ZT2Ne36ERYkMUxzL6dtKdeOKe mYgMSDoSGad7btdVR/z48L42XYqkmAGByRuUOBXg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hugh Dickins , Michal Hocko , David Rientjes , Gerald Schaefer , Andrew Morton , Linus Torvalds , Chen si , Baoyou Xie , Wen Yang , Zijiang Huang Subject: [PATCH 4.9 27/47] mm: add cond_resched() in gather_pte_stats() Date: Thu, 15 Apr 2021 16:47:19 +0200 Message-Id: <20210415144414.326518538@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210415144413.487943796@linuxfoundation.org> References: <20210415144413.487943796@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hugh Dickins commit a66c0410b97c07a5708881198528ce724f7a3226 upstream. The other pagetable walks in task_mmu.c have a cond_resched() after walking their ptes: add a cond_resched() in gather_pte_stats() too, for reading /proc//numa_maps. Only pagemap_pmd_range() has a cond_resched() in its (unusually expensive) pmd_trans_huge case: more should probably be added, but leave them unchanged for now. Link: http://lkml.kernel.org/r/alpine.LSU.2.11.1612052157400.13021@eggly.anvils Signed-off-by: Hugh Dickins Acked-by: Michal Hocko Cc: David Rientjes Cc: Gerald Schaefer Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Reported-by: Chen si Signed-off-by: Baoyou Xie Signed-off-by: Wen Yang Signed-off-by: Zijiang Huang Signed-off-by: Greg Kroah-Hartman --- fs/proc/task_mmu.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -1609,6 +1609,7 @@ static int gather_pte_stats(pmd_t *pmd, } while (pte++, addr += PAGE_SIZE, addr != end); pte_unmap_unlock(orig_pte, ptl); + cond_resched(); return 0; } #ifdef CONFIG_HUGETLB_PAGE