Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422725AbWJPQY3 (ORCPT ); Mon, 16 Oct 2006 12:24:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422640AbWJPQY3 (ORCPT ); Mon, 16 Oct 2006 12:24:29 -0400 Received: from colin.muc.de ([193.149.48.1]:40967 "EHLO mail.muc.de") by vger.kernel.org with ESMTP id S1422725AbWJPQY2 (ORCPT ); Mon, 16 Oct 2006 12:24:28 -0400 Date: 16 Oct 2006 18:24:26 +0200 Date: Mon, 16 Oct 2006 18:24:26 +0200 From: Andi Kleen To: Alan Cox Cc: akpm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pci: x86-32/64 switch to pci_get API Message-ID: <20061016162426.GB14354@muc.de> References: <1161013892.24237.100.camel@localhost.localdomain> <20061016160759.GA14354@muc.de> <1161017113.24237.115.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1161017113.24237.115.camel@localhost.localdomain> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 27 On Mon, Oct 16, 2006 at 05:45:13PM +0100, Alan Cox wrote: > Ar Llu, 2006-10-16 am 18:07 +0200, ysgrifennodd Andi Kleen: > > > --- linux.vanilla-2.6.19-rc1-mm1/arch/x86_64/kernel/pci-calgary.c 2006-10-13 15:10:06.000000000 +0100 > > > +++ linux-2.6.19-rc1-mm1/arch/x86_64/kernel/pci-calgary.c 2006-10-13 17:14:40.000000000 +0100 > > > @@ -879,7 +879,7 @@ > > > > > > error: > > > do { > > > - dev = pci_find_device_reverse(PCI_VENDOR_ID_IBM, > > > + dev = pci_get_device_reverse(PCI_VENDOR_ID_IBM, > > > PCI_DEVICE_ID_IBM_CALGARY, > > > dev); > > > > No put call anywhere? > > You can't hot unplug your MMU Not sure about that. Calgary is afaik in the bridges and since Summit has pluggable PCI cages and nodes i would assume the MMU instances are also hot pluggables. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/