Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1017197pxb; Thu, 15 Apr 2021 11:47:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydXskb3T0K+DRkY32WseaSGZXIe6CTLCwpyNEgprccn2T93VzHFFeb3HHXQhQIsu2QSAoq X-Received: by 2002:a17:902:dac8:b029:eb:14e1:5057 with SMTP id q8-20020a170902dac8b02900eb14e15057mr5427316plx.65.1618512456095; Thu, 15 Apr 2021 11:47:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618512456; cv=none; d=google.com; s=arc-20160816; b=Bmv7Uaf5w38DFCUULUIk4XIpEBuBKd53pgxUoHcaxBhABXge6wh64k7vKp0KNuy6wA /tjF2GQUlzxXyjFDgzxRHlFhIULgTz6RJ5ELq6AVb+ELa0hXDgZ5jPuqJNM9k9qyKOcF 9xdh2aas/J4Ovhp8vQMfIootb/3U4fX1J163DPgPHup0x4lq1uFEVDjRv78MoovGZWG3 dvJGcWSWz6yrMCA6ILuy7XaVQq76E+LQwPB5G4EdYrdlu+iqTYzW0zEwZ7XL96pyg4ZN dJnUUNTLvUIx78LoldO7FSnANb81fJPFkGJxV6m0FX1cnNT3BzdjTbwXSPtj+VEwCPE2 a/3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=iPdfqFT/TrMEBgwtOcaOwea4sUI31fIESBeN4dwEHBQ=; b=N36MY5lIdfCupQIaTVWExkmtP3v0GUjzwynxEYxTkxUZATLZR9wH2m5drInWlu+Roh 0DViql3KrTAJhxpwQPRKXM+cYGW9764fReAFXnfgUMe/rcCARLQcpc4Dvp7usqYkSU4C LmsD0YM9ZlcbgWXGexRJNWo6yn6+sfmOq8PSnIe6roYeNgM5N9HtpHC55dmSjpZv5MN/ Fb3gIheLfnB2lp7ASke0rWLrKx7GhQTvxrdfe5hzLpidAO0iAlm1UvEhubS/qpNaHKug l3XQgMvyNSzMu5JXXtGRrar90Uk1Q+lCf0oePzHO/HFc6qPWuigYlyP3Z5viCyH/cYly O+OA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f16si4367908pfj.17.2021.04.15.11.47.23; Thu, 15 Apr 2021 11:47:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234565AbhDOSrC (ORCPT + 99 others); Thu, 15 Apr 2021 14:47:02 -0400 Received: from netrider.rowland.org ([192.131.102.5]:42731 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S233948AbhDOSrB (ORCPT ); Thu, 15 Apr 2021 14:47:01 -0400 Received: (qmail 16071 invoked by uid 1000); 15 Apr 2021 14:46:37 -0400 Date: Thu, 15 Apr 2021 14:46:37 -0400 From: Alan Stern To: Chris Chiu Cc: Greg KH , m.v.b@runbox.com, hadess@hadess.net, linux-usb@vger.kernel.org, Linux Kernel Subject: Re: [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub Message-ID: <20210415184637.GA15445@rowland.harvard.edu> References: <20210415114856.4555-1-chris.chiu@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 16, 2021 at 12:13:43AM +0800, Chris Chiu wrote: > One thing worth mentioning here, I never hit the hub_ext_port_status -71 > problem if I resume by waking up from the keyboard connected to the hub. I thought you said earlier that the port got into trouble while it was suspending, not while it was resuming. You wrote: > [ 2789.679812] usb 3-4-port3: can't suspend, status -110 So if the problem occurs during suspend, how can it be possible to avoid the problem by taking some particular action later while resuming? > But the usbcore kernel log shows me wPortStatus: 0503 wPortChane: 0004 > of that port while resuming. In normal cases, they are 0507:0000. The 0004 bit of wPortChange means that the suspend status has changed; the port is no longer suspended because the device attached to that port (your keyboard) issued a wakeup request. > I don't know how to SetPortFeature() with setting the status change bit only. You can't. Only the hub itself can set the wPortChange bits. > Or maybe it's just some kind of timing issue of the > idle/suspend/resume signaling. Not timing. It's because you woke the system up from the attached keyboard. Alan Stern