Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210415183639.1487-1-rdunlap@infradead.org>
In-Reply-To: <20210415183639.1487-1-rdunlap@infradead.org>
From:   Adrien Grassein <adrien.grassein@gmail.com>
Date:   Thu, 15 Apr 2021 21:36:39 +0200
Message-ID: <CABkfQAGfaxQJ4xdMpJk3CO-VZueM11BBUR-YpAQ8v0-wvwAheg@mail.gmail.com>
Subject: Re: [PATCH -next] drm: bridge: fix LONTIUM use of mipi_dsi_() functions
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Sam Ravnborg <sam@ravnborg.org>, Vinod Koul <vkoul@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Reviewed-by: Adren Grassein <adrien.grassein@gmail.com>

Le jeu. 15 avr. 2021 =C3=A0 20:36, Randy Dunlap <rdunlap@infradead.org> a =
=C3=A9crit :
>
> The Lontium DRM bridge drivers use mipi_dsi_() function interfaces so
> they need to select DRM_MIPI_DSI to prevent build errors.
>
> ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/lontium-lt9611u=
xc.ko] undefined!
> ERROR: modpost: "mipi_dsi_device_register_full" [drivers/gpu/drm/bridge/l=
ontium-lt9611uxc.ko] undefined!
> ERROR: modpost: "of_find_mipi_dsi_host_by_node" [drivers/gpu/drm/bridge/l=
ontium-lt9611uxc.ko] undefined!
> ERROR: modpost: "mipi_dsi_device_unregister" [drivers/gpu/drm/bridge/lont=
ium-lt9611uxc.ko] undefined!
> ERROR: modpost: "mipi_dsi_detach" [drivers/gpu/drm/bridge/lontium-lt9611u=
xc.ko] undefined!
> ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/lontium-lt9611.=
ko] undefined!
> ERROR: modpost: "mipi_dsi_device_register_full" [drivers/gpu/drm/bridge/l=
ontium-lt9611.ko] undefined!
> ERROR: modpost: "of_find_mipi_dsi_host_by_node" [drivers/gpu/drm/bridge/l=
ontium-lt9611.ko] undefined!
> ERROR: modpost: "mipi_dsi_device_unregister" [drivers/gpu/drm/bridge/lont=
ium-lt9611.ko] undefined!
> ERROR: modpost: "mipi_dsi_detach" [drivers/gpu/drm/bridge/lontium-lt9611.=
ko] undefined!
> WARNING: modpost: suppressed 5 unresolved symbol warnings because there w=
ere too many)
>
> Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge")
> Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC brid=
ge")
> Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Adrien Grassein <adrien.grassein@gmail.com>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: stable@vger.kernel.org
> ---
>  drivers/gpu/drm/bridge/Kconfig |    3 +++
>  1 file changed, 3 insertions(+)
>
> --- linux-next-20210414.orig/drivers/gpu/drm/bridge/Kconfig
> +++ linux-next-20210414/drivers/gpu/drm/bridge/Kconfig
> @@ -66,6 +66,7 @@ config DRM_LONTIUM_LT8912B
>         depends on OF
>         select DRM_PANEL_BRIDGE
>         select DRM_KMS_HELPER
> +       select DRM_MIPI_DSI
>         select REGMAP_I2C
>         help
>           Driver for Lontium LT8912B DSI to HDMI bridge
> @@ -81,6 +82,7 @@ config DRM_LONTIUM_LT9611
>         depends on OF
>         select DRM_PANEL_BRIDGE
>         select DRM_KMS_HELPER
> +       select DRM_MIPI_DSI
>         select REGMAP_I2C
>         help
>           Driver for Lontium LT9611 DSI to HDMI bridge
> @@ -94,6 +96,7 @@ config DRM_LONTIUM_LT9611UXC
>         depends on OF
>         select DRM_PANEL_BRIDGE
>         select DRM_KMS_HELPER
> +       select DRM_MIPI_DSI
>         select REGMAP_I2C
>         help
>           Driver for Lontium LT9611UXC DSI to HDMI bridge