Date: Mon, 16 Oct 2006 11:39:37 -0700
From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: lkml <linux-kernel@vger.kernel.org>, johnstul@us.ibm.com
Subject: Re: [PATCH] i386 Time: Avoid PIT SMP lockups
Message-Id: <20061016113937.a76f8d06.akpm@osdl.org>
In-Reply-To: <p73odsccqy5.fsf@verdi.suse.de>
References: <1160596462.5973.12.camel@localhost.localdomain>
	<20061011142646.eb41fac3.akpm@osdl.org>
	<1160606911.5973.36.camel@localhost.localdomain>
	<20061011160328.f3e7043a.akpm@osdl.org>
	<p73odsccqy5.fsf@verdi.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 990
Lines: 31

On 16 Oct 2006 15:48:02 +0200
Andi Kleen <ak@suse.de> wrote:

> Andrew Morton <akpm@osdl.org> writes:
> > 
> > Is there any actual need to hold xtime_lock while doing the port IO?  I'd
> > have thought it would suffice to do
> > 
> > 	temp = port_io
> > 	write_seqlock(xtime_lock);
> > 	xtime = muck_with(temp);
> > 	write_sequnlock(xtime_lock);
> > 
> > ?
> 
> That would be a good idea in general. The trouble is just that whatever race
> is there will be still there then, just harder to trigger (so instead of 
> every third boot it will muck up every 6 weeks). Not sure that is
> a real improvement.
> 

Confused.  What race are you referring to?

This is addressing a starvation problem which is due to the slowness of the
port-io (iirc).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/