Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     jejb@linux.ibm.com, Qiheng Lin <linqiheng@huawei.com>
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-kernel@vger.kernel.org, njavali@marvell.com,
        mrangankar@marvell.com, linux-scsi@vger.kernel.org,
        GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH -next] scsi: qla4xxx: remove unneeded if-null-free check
Date:   Thu, 15 Apr 2021 22:51:15 -0400
Message-Id: <161853823945.16006.7771182124397291131.b4-ty@oracle.com>
In-Reply-To: <20210409120345.6447-1-linqiheng@huawei.com>
References: <20210409120345.6447-1-linqiheng@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.mkp.ca.oracle.com (138.3.201.9) by SA9PR11CA0023.namprd11.prod.outlook.com (2603:10b6:806:6e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Fri, 16 Apr 2021 02:51:36 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8ffb4cb1-4388-402c-6726-08d900828db4
X-MS-TrafficTypeDiagnostic: PH0PR10MB4568:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB4568E367017E42DE19AEDCB58E4C9@PH0PR10MB4568.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 7VHSxmg644Em23Y7Yjlp+tJfup52/kkpf42BsmSxmXETNB0CO+6EVLBGOZtvPeHzb7gzYGte49wQOAfE0t/Mvgm7BQeEzM5Q+DTWynREA31aTzF5k9oLHshXmai8CW6Fjq5BOaXQPotgIbvAeXjj+tSBRtlrEsbAVQCSSwpEes3N8/G0GnZ9ujvR/ZNaI7/tw63bBGMIJ+y9KIqvvYT4p8Wm5ac5J1PWEw90t/hQkJY8AoAFLDOzLvN835juHYf54BnD71INXQ8dmPWbGSFIipUuYFHUsWb3XYpvWDjCboZY73BaIirBtl8BzxVWIqxsAa7r1E1dIf2tFJ49a7ZLmlUclbYNZauR2PUcO8X3B875DBi15VDbA7iENPZyiSlccKrYwQzVO9HTixs9YpJkf6HajFbrlR3vFVDn8eWCnhjr4i+qQ+XWdshU2sPgaQZvSXYn8BLZbCCoeP5VSuJxewttiCp0hAq91ATcpFTgAJ9ILydZiJo0fFw67Oh0yPE9hvApRltkrNmQT+J3gCM0EmARzZsDNwTsfSW8uFLin2A++p+Rezw0E4yv/t5ZZzLNuBozF17Ucc1oNcL/X6VkwCUzphcfrXV0EUZ4Z7RIo1v6r/k+HUDSwDSVaJ5bAv5MWRu4xG7BvNHuv1YJjjIgBWAq1bUvd1cnyUfJ2RyAAUShgFQOCEOmxXws/DxeIrtujiSOIeVCM98vvvJsetRBXd66CMh+i4vyK5XM8/5qbR6j6T+rrNGxdPjlQJwg7O2M
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(396003)(376002)(346002)(136003)(316002)(103116003)(6486002)(5660300002)(478600001)(26005)(2616005)(956004)(8936002)(83380400001)(16526019)(66946007)(66556008)(66476007)(86362001)(6916009)(4326008)(8676002)(186003)(38100700002)(38350700002)(2906002)(36756003)(966005)(7696005)(6666004)(52116002)(32563001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?c1M1Sk92S3dkYnJVQ0pHeGhTNGVBbDZnbm5qbFNLRlIvOU90Syt3a0V6RVlh?=
 =?utf-8?B?c3Jpc2pQM09WVzNQMjY3K1BOY2x5NHB3cUtadlFaSUFDVmJDdkIxNXBwL3Fa?=
 =?utf-8?B?a1R3RHlSQXk3UXhuUXBwQjJON01Dc1pDcDgweTBrbVVWMkw2R3htUllHZjdY?=
 =?utf-8?B?dFp0bFNBVklMelQ3eHF3OHVrWVgzUm5LNTNRdkFNVHpVdnhnYXcvcHhLWlFS?=
 =?utf-8?B?OExWZVBORURocmFWYzF4K0dQZjVBb2xMcUp2S0JTQmtUT3JyckhWajl4UmFo?=
 =?utf-8?B?MVJGSGJoUVk3ZWM4K012MC9XaDF2TUsvUExieWkxTnRMSWFIREduN21DRVNo?=
 =?utf-8?B?WUJpeGdGY3pobFdvN3ZKeHNGVzhRaEVqS1FNYS9tTFFXaG1SaFdYVWZza2F3?=
 =?utf-8?B?WE8zV0dNWjBEeGJrVjltVjlzbTc5WCtyMzd2MGkzOTNFaUpVTzYxWXRWVHFo?=
 =?utf-8?B?Qlc4eFVnV3A1WGQxVHlrOGpJRkUzMGtjQytPQUQ2bm56b3RDMUsxVnhDR0ZC?=
 =?utf-8?B?VEZ1RUpWc0NYZTc5RGtiRGxWRDVqZGNieExUTytGdXJHT2xmTFREVXpra2p3?=
 =?utf-8?B?ajdNTVE3cXp2emVoT0hZWm9aZU1lVjk2V0p5NmVnUkxBMlNFSlBpeVdqdjRU?=
 =?utf-8?B?YUN3UGRyNmptd0RDMDA3bzN2emVhTTl2TUJFSkJaMWNqRnc5WG1ibGI4Z1hz?=
 =?utf-8?B?Y01uQU45b09WTnlobnltVUZHc3Q1eGpYWDlnVE1XNk4vd29pb0dBYitOTUI1?=
 =?utf-8?B?dmw4N1ZVenJGQ1JoU2ZoNWxJUkpuNU85emUvZUl3VWs5RXlEK1JiTWdDNW4w?=
 =?utf-8?B?ZFhXYzNZbnE0TFpqcWNOd3FNTStTUEF3MkU5WTA4OTFOQ3dPTXVYSDAvKzBu?=
 =?utf-8?B?b0JnNnVXWVJQMld2TitPNTZlcG11UHFab204ZFJubWFUdUJJUUhMODhKTFoy?=
 =?utf-8?B?bTJnOG1wMjRtaGJiaE9UVytyb0NqclFqN3ovZlpqN1hwYWt4QXF3STNqMktu?=
 =?utf-8?B?VDk5bXA4SkFSZXJ1T1l4UEJVYWlWdzN6Y0JyWmQrOGNvdWF5a25HOFBSbTFl?=
 =?utf-8?B?eUFQWWtkREsrRzZqaVZHTFQ2SlZGMW1CelVZemRuYzdKNVhVWnZ0OGZ3ek1U?=
 =?utf-8?B?dGtHOWJINk82ckI4TWxNaDkzOEpuczJPSGcxeXVpZi9oWm1tZzMvcWlFTzYw?=
 =?utf-8?B?M2orMG90ajVoWWUvL29lVWg5ZU5ib2tGMHg1QzZ2REg1Ym1UblZpTmVuTXBo?=
 =?utf-8?B?eTYxUlhBMkp1NFpscnhqSG5GSXJXY2NrV2hvc1RrVFpVWjQ4clR3QVpDRXVD?=
 =?utf-8?B?NkRxamRLcDhXYUU2VDBMdGxEaGJ3L3RUQW4yWlRHbXNwb0RKWFVubkJjOW14?=
 =?utf-8?B?ZkpmUFgreWNRQnR3MXBtS2Vka0tqSTgxK0RjL2czT3l0bFpzK0ZYWGVoTUNz?=
 =?utf-8?B?UW1CcHkyMDB1UUhqSEFWczRlVnFjOFpOKzE1U2J0eUdqMWo0QkNITDBPRFBH?=
 =?utf-8?B?VFd3UVBMRnA2YlBEc0gvNHNDZVUzTjlMOGgzZGs2YlNvbzM3Z3NrdjNLREJK?=
 =?utf-8?B?RG5kTFIwems5NngwbmVxeWZHaUJqN2VmaWRJTDZtYzd2Rm1BRHRiSVJUWlNq?=
 =?utf-8?B?R2F6cStPRWkwSUErWHY5RHhuNXJJTEMvaXVIaHZLQkZKdzRrMVI3dE01QlNz?=
 =?utf-8?B?THVLb3VVM0xxdTlGRjcyWVNKcmNYOHFQTG0yTXlYM1RVUVl0NVZPaVkvMURL?=
 =?utf-8?Q?r8aE8zOSy5K7dQtdddv6qgaRjoXA742BXfbQY06?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ffb4cb1-4388-402c-6726-08d900828db4
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2021 02:51:37.4427
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UDIzVWTgk23vnmdNcSfoVFuNbU0ciNEJ8gbhQ5LpDcgzWE65b9JwsMQGKLuG3zLeRMTPztkfS6fld4898y/vAkD9iK+og1V3M+WUckljCbc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4568
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9955 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 adultscore=0 phishscore=0 malwarescore=0 mlxscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104060000 definitions=main-2104160022
X-Proofpoint-GUID: Q3bGnUZ01xlSNIpHtpz7TP6jiVn8Iwdo
X-Proofpoint-ORIG-GUID: Q3bGnUZ01xlSNIpHtpz7TP6jiVn8Iwdo
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9955 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 spamscore=0
 impostorscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0
 bulkscore=0 phishscore=0 suspectscore=0 malwarescore=0 clxscore=1015
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000
 definitions=main-2104160022
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 9 Apr 2021 20:03:45 +0800, Qiheng Lin wrote:

> Eliminate the following coccicheck warning:
> 
> drivers/scsi/qla4xxx/ql4_os.c:4175:2-7: WARNING:
>  NULL check before some freeing functions is not needed.
> drivers/scsi/qla4xxx/ql4_os.c:4196:2-7: WARNING:
>  NULL check before some freeing functions is not needed.
> drivers/scsi/qla4xxx/ql4_os.c:4215:2-7: WARNING:
>  NULL check before some freeing functions is not needed.
> drivers/scsi/qla4xxx/ql4_os.c:6400:2-7: WARNING:
>  NULL check before some freeing functions is not needed.
> drivers/scsi/qla4xxx/ql4_os.c:6402:2-7: WARNING:
>  NULL check before some freeing functions is not needed.
> drivers/scsi/qla4xxx/ql4_os.c:6555:2-7: WARNING:
>  NULL check before some freeing functions is not needed.
> drivers/scsi/qla4xxx/ql4_os.c:6557:2-7: WARNING:
>  NULL check before some freeing functions is not needed.
> drivers/scsi/qla4xxx/ql4_os.c:7838:2-7: WARNING:
>  NULL check before some freeing functions is not needed.
> drivers/scsi/qla4xxx/ql4_os.c:7840:2-7: WARNING:
>  NULL check before some freeing functions is not needed.

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi: qla4xxx: remove unneeded if-null-free check
      https://git.kernel.org/mkp/scsi/c/eb5a3e3b75fe

-- 
Martin K. Petersen	Oracle Linux Engineering