Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp110288pxb; Fri, 16 Apr 2021 00:35:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysS+TWUawKhrR45TTw1wqyvGB6hleQ0vEJ2FXNemIQaXAPH3MYyjxFr6S5AUf5y3WVivw9 X-Received: by 2002:a17:906:cc46:: with SMTP id mm6mr7335289ejb.138.1618558554946; Fri, 16 Apr 2021 00:35:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618558554; cv=none; d=google.com; s=arc-20160816; b=jSGjoeAK3y7Zcque1aIcGjZsmsr2bIbnGxNhZBgRtRzAtQX/Jep6T2FVCuq7isYfyH MozcOn9dRGC7WHH52NASl90ohnRbKs7mbECFAKKC7TJDOSnzZJLaHZTUN0pbvJn2H733 3JBD0iCNlno5YxA3QKYSQRkxnf9eNuENv2UCPcUXbmZFL0BdX7UnIoIElsetGQfwaWFW srrE9ZYBlI8dpDnf8eumPj/tLQWcZ+AZjHR91OWrIiQ9xJkP1G3q4xh5T92mRRuVBL8p CWVpUngbdvMDpoKu63VBMEep7ub00QnIaTX0uVkEKC4rcmvGuQy1TQyj89HDGQdTIw0b QBWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=uFu1ansvgQWTnPWidX6DS+YOvYK1ittywA6eOG1qupA=; b=PhWWMIusf56/2LPYQnM4CWxqI16I72shZRe4EMMS1HgdCgukZyCAQQmcOLFcKxTdGC TBCf1dYP2YSna85iNsjYIz5AChzGJWZO1sM8py8uVR8XUb/As4HGh4BuAU6OKyiEnGTb o9AkT7Wwov5BLhS2n+NlKLKSTTohRvCFFJY2c0XIkpGJUSefqhssedDoI0kg+HAD4MXR lHulhpBbjwO4U/JHFW9Nknyav4neqO8rWg7KSoUtvudh4yEKpqyJT0EQIw98r5L1sQPY A98jbcPLJCPV5FFxFX1kVWl/fqCoIQHaMNbFf+SY27h3LCgt9XLZzXihWxIkzvxRdaaw f1Rw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y6si330050edc.72.2021.04.16.00.35.32; Fri, 16 Apr 2021 00:35:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239676AbhDPHen (ORCPT + 99 others); Fri, 16 Apr 2021 03:34:43 -0400 Received: from mail-qv1-f42.google.com ([209.85.219.42]:34522 "EHLO mail-qv1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239462AbhDPHem (ORCPT ); Fri, 16 Apr 2021 03:34:42 -0400 Received: by mail-qv1-f42.google.com with SMTP id j3so12999723qvs.1; Fri, 16 Apr 2021 00:34:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uFu1ansvgQWTnPWidX6DS+YOvYK1ittywA6eOG1qupA=; b=c+20I+f/+5NcwR7XIOzF2TMduM0BpkNsu/uE7CZB0lNh5AfcArtH65w8QR2g69W4Md NNP8Yj/aCqNTJGHmmaJIG7VBMKiAYHFb21ig/DfkUt1fptF7Ynez6nleTuACMZ5uBH+o 3VmZwGnmJXMGhbL3D4trs0yo0Ml80ZLtZ7exwznCAzQgJLwGWU36G+wIp8NaDwJrZSaq mLpNbWjU0CKzrcAAZYJeD5vZGsWITwQZe9SsWr4dmgIWexyywpdspWUrOzIC7Bexje1I Tuk61BFxt+Esml5KqK8+t1rOb1HD9kXOV9H/TUjbIqnUQTIfGSDmYzPZZknF9Q9zj3e2 hhlA== X-Gm-Message-State: AOAM531GLj55DKTvyB/mkfr9McneK6uRABB/DLFXZuUVZ6DE8lcnuCxT MA1qI9T9btYs5oiH8OkuDVKbAzel4e1mJg== X-Received: by 2002:a0c:f2c8:: with SMTP id c8mr6999428qvm.35.1618558457628; Fri, 16 Apr 2021 00:34:17 -0700 (PDT) Received: from [10.68.32.192] (broadband-188-32-236-56.ip.moscow.rt.ru. [188.32.236.56]) by smtp.gmail.com with ESMTPSA id a26sm3602955qtg.60.2021.04.16.00.34.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Apr 2021 00:34:17 -0700 (PDT) Subject: Re: [PATCH] floppy: remove redundant assignment to variable st To: Colin King , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Willy Tarreau Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210415130020.1959951-1-colin.king@canonical.com> From: Denis Efremov Message-ID: Date: Fri, 16 Apr 2021 10:34:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210415130020.1959951-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 4/15/21 4:00 PM, Colin King wrote: > From: Colin Ian King > > The variable st is being assigned a value that is never read and > it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Applied, thanks! https://github.com/evdenis/linux-floppy/commit/aeec7983d49a5f972df47c742ff8373df15b0d28 > --- > arch/x86/include/asm/floppy.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/include/asm/floppy.h b/arch/x86/include/asm/floppy.h > index d43717b423cb..6ec3fc969ad5 100644 > --- a/arch/x86/include/asm/floppy.h > +++ b/arch/x86/include/asm/floppy.h > @@ -74,7 +74,6 @@ static irqreturn_t floppy_hardint(int irq, void *dev_id) > int lcount; > char *lptr; > > - st = 1; > for (lcount = virtual_dma_count, lptr = virtual_dma_addr; > lcount; lcount--, lptr++) { > st = inb(virtual_dma_port + FD_STATUS); >