From: Andi Kleen <ak@suse.de>
To: Zachary Amsden <zach@vmware.com>
Subject: Re: [RFC] Avoid PIT SMP lockups
Date: Tue, 17 Oct 2006 00:40:49 +0200
User-Agent: KMail/1.9.3
Cc: caglar@pardus.org.tr, Gerd Hoffmann <kraxel@suse.de>,
       john stultz <johnstul@us.ibm.com>, lkml <linux-kernel@vger.kernel.org>
References: <1160170736.6140.31.camel@localhost.localdomain> <200610121045.32846.caglar@pardus.org.tr> <453404F6.5040202@vmware.com>
In-Reply-To: <453404F6.5040202@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200610170040.49502.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1217
Lines: 26


> It might only happen with SMP because the difficulty of getting good 
> enough TSC / timer IRQ synchronization during boot increases 
> exponentially with SMP configurations. And it might pass 10% of the time 
> because you were lucky enough not to fire off another timer interrupt yet.

We have the same problem with NMI watchdog events unfortunately. 
Need to call something in the nmi watchdog code to make sure it is 
not renewed and then reenabled.
Or maybe it's better to figure out a way that yields atomic patches.

I think the best way is to make sure all alternative() patches
are always done before the code can be ever executed - this
means doing it very early for the main kernel. The only exception
would be the LOCK prefix patching, which should be atomic.

iirc there was some more patching except lock prefixes going on for 
SMP<->UP transisitions,  but last time I checked they didn't look 
particularly useful and could be probably eliminated.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/