Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: yuk6dktqCJoke4B43c3fxCoq/DA9rQgLYOEHJ0WHRfuPmgH2X8ilnwUlGn3TuXDDLaiL45Q7Z4
 2mQG80zaP8iA==
IronPort-SDR: BJZDC5Jq+ygLeIOUlN5DHtRSPA54UoNQksLH1UDbp79GVwgghc+S2OVAoPSCFnBDJYUy8lcCQt
 LxOAcsVCbvTw==
From:   Alexander Shishkin <alexander.shishkin@linux.intel.com>
To:     Tao Zhang <taozha@codeaurora.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>
Cc:     Tao Zhang <taozha@codeaurora.org>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Tingwei Zhang <tingwei@codeaurora.org>,
        Mao Jinlong <jinlmao@codeaurora.org>,
        Yuanfang Zhang <zhangyuanfang@codeaurora.org>,
        alexander.shishkin@linux.intel.com
Subject: Re: [PATCH v1 1/2] coresight: Add support for device names
In-Reply-To: <1618560476-28908-2-git-send-email-taozha@codeaurora.org>
References: <1618560476-28908-1-git-send-email-taozha@codeaurora.org>
 <1618560476-28908-2-git-send-email-taozha@codeaurora.org>
Date:   Fri, 16 Apr 2021 14:19:27 +0300
Message-ID: <87im4mfpds.fsf@ashishki-desk.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Tao Zhang <taozha@codeaurora.org> writes:

> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
> index 4ba801d..b79c726 100644
> --- a/drivers/hwtracing/coresight/coresight-core.c
> +++ b/drivers/hwtracing/coresight/coresight-core.c
> @@ -1640,6 +1640,12 @@ char *coresight_alloc_device_name(struct coresight_dev_list *dict,
>  	int idx;
>  	char *name = NULL;
>  	struct fwnode_handle **list;
> +	struct device_node *node = dev->of_node;
> +
> +	if (!node) {
> +		if (!of_property_read_string(node, "coresight-name", &name))

Ok, I'm not a device tree expert, but I'm pretty sure the above is a
nop.

Regards,
--
Alex