Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: taozha=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Fri, 16 Apr 2021 20:14:22 +0800
From:   taozha@codeaurora.org
To:     Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Tingwei Zhang <tingwei@codeaurora.org>,
        Mao Jinlong <jinlmao@codeaurora.org>,
        Yuanfang Zhang <zhangyuanfang@codeaurora.org>
Subject: Re: [PATCH v1 1/2] coresight: Add support for device names
In-Reply-To: <87im4mfpds.fsf@ashishki-desk.ger.corp.intel.com>
References: <1618560476-28908-1-git-send-email-taozha@codeaurora.org>
 <1618560476-28908-2-git-send-email-taozha@codeaurora.org>
 <87im4mfpds.fsf@ashishki-desk.ger.corp.intel.com>
Message-ID: <fbadb638e161e62d38ed2ba905da7340@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-04-16 19:19, Alexander Shishkin wrote:
> Tao Zhang <taozha@codeaurora.org> writes:
> 
>> diff --git a/drivers/hwtracing/coresight/coresight-core.c 
>> b/drivers/hwtracing/coresight/coresight-core.c
>> index 4ba801d..b79c726 100644
>> --- a/drivers/hwtracing/coresight/coresight-core.c
>> +++ b/drivers/hwtracing/coresight/coresight-core.c
>> @@ -1640,6 +1640,12 @@ char *coresight_alloc_device_name(struct 
>> coresight_dev_list *dict,
>>  	int idx;
>>  	char *name = NULL;
>>  	struct fwnode_handle **list;
>> +	struct device_node *node = dev->of_node;
>> +
>> +	if (!node) {
>> +		if (!of_property_read_string(node, "coresight-name", &name))
> 
> Ok, I'm not a device tree expert, but I'm pretty sure the above is a
> nop.
> 
> Regards,
> --
> Alex
You are right. The pointer check code here is wrong, I will correct it 
on the V2 version.

Tao