Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp323687pxb; Fri, 16 Apr 2021 06:39:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdXfcoF02zhHHsvNsUp2SD5j4SF4WW/sOLsqAeB8lVjrgGaeQjgW2JNOw6n3+7U5Uzjb41 X-Received: by 2002:aa7:d599:: with SMTP id r25mr10142992edq.68.1618580344519; Fri, 16 Apr 2021 06:39:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618580344; cv=none; d=google.com; s=arc-20160816; b=IFKkDgUkDjnTMLHD6sOvgiZEMzA/Q94Xn+Mn3LAOP8RFsQRK8vGTLQjvMP15HFvjCH HsKvWIOyrBJBy25NpGViTUofP+A5Ia+OGMHR4WIJ8TIOARGz+CNm5mzBik31nGrTiJjM 5F0qipeN6ACFQM2aLE3G8vfBbHtZ3uXQr0gCs67bxmcT53hB5EhT+6Uljm+MVW0iOefu COkQyQ2X93qGLY3TeJbeLZ0CCjAQMiR+Jx+91CZs+Bs2RFbOsxGohrz9RRNP0TyiqyuE awdHFGJbIG8rXUIicn+1pCdTX7V3RngnxA4fWHoawm6F4kDz4158OkEoiCpRvD5thBHp 2HGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ebOzLEOwHteNt7so3opQ2xhJ/MzF3dfpzn3Cmc1eTrI=; b=bi3T1KHFJw0QI/dqNT1fORZwFUMyETbXNCTNHJrkaXlSij7hh2h/KbxRilG+oaHrlH a+/3lkrPuJP+MA0KQ9p3nvS2Ws8vPTvpCceyGfI4BW4ayFeZIfVHI4CCPqU/0dF9m1BB nlP6iZKCX0X3Enydx97XCzEj884kDem9jOmo9BaRcOdrrZHg9Jmap3ID3b7PqJa+80Vi xcYkvU6T4TDXZjxBkrPW9wUTSN1nBhTX/r564dzFsJjzmJHIhfjtzO3/LKIhawGlU3zW zS5/a6qv8qYkRd1Z+JwefzWytfnrePoBJOYbtu3PfpWoJ5taztyfJR/uikpP19kfJUZk MD9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BJi5NHc+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q19si4718940ejd.250.2021.04.16.06.38.41; Fri, 16 Apr 2021 06:39:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BJi5NHc+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241981AbhDPLpB (ORCPT + 99 others); Fri, 16 Apr 2021 07:45:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:47246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241891AbhDPLpB (ORCPT ); Fri, 16 Apr 2021 07:45:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1D13161057; Fri, 16 Apr 2021 11:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618573476; bh=g1GQ3fMRsXXUxb3TziyhacMOOpriyOWdQMsWa6+jGug=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BJi5NHc+XLro4v3JuXfxVimD3qTxlRIlEQW0jKcbC1fkOeMbhX+QD36Vpgv/m5ZWS w9k0pCOsSSy5e1rtpgZ6meO2kxgPq/nHRJ8xHTAE/3ueN6qs6pqlukQ1HUBO0cBT9Z 1AQShBFk27Hug5dFGtBphwLSnqUSmscREcGT3KDTwjeLt7aURG5nZp5OsnGRS8Tf1v cyIiJ5wZAAlMJuC7YOXtzgBlbuPlBe1viVwrvSNQ2ApaD5WM28tOf9xQWfW9Tzj99G Xv0t+SbyVly+TfTJMs7hkGCjxMV0CtCIjWPw5NkGbs+NBYqqEsV1nMMDioVyRJhgy+ nG5AVY/FWbnzA== Date: Fri, 16 Apr 2021 14:44:26 +0300 From: Mike Rapoport To: David Hildenbrand Cc: Ard Biesheuvel , Linux ARM , Anshuman Khandual , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm , Linux Kernel Mailing List , Linux Memory Management List Subject: Re: [RFC/RFT PATCH 1/3] memblock: update initialization of reserved pages Message-ID: References: <20210407172607.8812-1-rppt@kernel.org> <20210407172607.8812-2-rppt@kernel.org> <0c48f98c-7454-1458-15a5-cc5a7e1fb7cd@redhat.com> <3811547a-9057-3c80-3805-2e658488ac99@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 15, 2021 at 11:30:12AM +0200, David Hildenbrand wrote: > > Not sure we really need a new pagetype here, PG_Reserved seems to be quite > > enough to say "don't touch this". I generally agree that we could make > > PG_Reserved a PageType and then have several sub-types for reserved memory. > > This definitely will add clarity but I'm not sure that this justifies > > amount of churn and effort required to audit uses of PageResrved(). > > > Then, we could mostly avoid having to query memblock at runtime to figure > > > out that this is special memory. This would obviously be an extension to > > > this series. Just a thought. > > > > Stop pushing memblock out of kernel! ;-) > > Can't stop. Won't stop. :D > > It's lovely for booting up a kernel until we have other data-structures in > place ;) A bit more seriously, we don't have any data structure that reliably represents physical memory layout and arch-independent fashion. memblock is probably the best starting point for eventually having one. -- Sincerely yours, Mike.