Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <65e556b53fad029474fd948afecf0e226aa01f87.camel@kepstin.ca>
Subject: Re: [PATCH v4] tools/power turbostat: Fix RAPL summary collection
 on AMD processors
From:   Calvin Walton <calvin.walton@kepstin.ca>
To:     Terry Bowman <terry.bowman@amd.com>, lenb@kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Fri, 16 Apr 2021 10:50:48 -0400
In-Reply-To: <68be4830-36ec-85ad-56ae-ee3cf9b9589c@amd.com>
References: <20210330213825.77294-1-terry.bowman@amd.com>
         <17d15837848eddd8445b206356531b9b5aae644b.camel@kepstin.ca>
         <68be4830-36ec-85ad-56ae-ee3cf9b9589c@amd.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2021-04-16 at 06:42 -0500, Terry Bowman wrote:
> 
> Hi Calvin,
> 
> Thanks for the feedback. I'll begin making the change and testing.
> I'll 
> respond with V2 patch in this thread.
> 
> Regards,
> Terry

It looks like there might already be a patch in the pipeline for this
issue; see Chen Yu's response to my patch here:
https://lkml.org/lkml/2021/4/14/1322
I'm hoping we get some clarification of the status soon.

While you're respinning your patch, there's one other issue that I
noticed - all the idx/offset-related functions pass the offset value in
a variable of type "int" (32bit signed integer), but the offset of the
AMD MSR_CORE_ENERGY_STAT MSR is 0xC001029A, which exceeds INT_MAX. The
offsets should all use "off_t" to get a 64bit type and avoid wrapping
or sign extension issues.

-- 
Calvin Walton <calvin.walton@kepstin.ca>