Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp390127pxb; Fri, 16 Apr 2021 08:08:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlj+lUtRGYUL11a+OAuV6X3IbRe5+zVl0BSF5k/raugfiyW8i7QL3IKp56VFYO2MqgnZGb X-Received: by 2002:a17:906:46d6:: with SMTP id k22mr8552439ejs.243.1618585722179; Fri, 16 Apr 2021 08:08:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618585722; cv=none; d=google.com; s=arc-20160816; b=wW0EM/vfX0EUUYHUesRobuxKvPlHpVxYYZT3cxjR3Aq69NQMcfQStZ50QZKaGFJdCw 333lx5eFX8cPJ/M2FOcp3cvqK8uP3aV0xvu/LkXCN3FZ8leUH7D4p1dD+gUyMay2EJCS 6pZBWoJysys2uu7KJbE3hq6XxSFA5dUCkvRx2wOi9GO6GOvzPwWmjEHBpFg854O1hGZu q4N6fdRgrPpXrnRb9vmMMoBMHRkZmTlXtzgcAnI5GPzv2+G1IR+ZQsj6TJd4YRA8EVil zIHuQHWIY1DcSQcosI+jWrLNsEki6vLtFRZx6LNxJ4xrY99SfQzZ++FXam10x4Swaprc ZOQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:references:cc :to:from:subject; bh=h9GLmuoWRBrIX8vKjsu3dNdsMPMTk+unES234zNjZnQ=; b=UAm//fl6E493/5MUf9iqjIWUgQGEifeRG8YX1jUUE+1JG5z+C6cIDLBMq1ggm3j9IV LHX0gBh4nNUrgXHRdgPXfw5z6TeEq5t4yp7itMsrQZ+uA5L8zS4SMyczI5zyYSSszKjW E2RzPaSKwt+Hj0qrDk/x1arjw5wo1yKaiMF3ZyMBYlWekl4tA56sS4eaT6sVHKpInlhJ 45dHr0JTpx5M6W9F9NU5Rp/qjgASa2m6uPEsn+REj52AsnbRMRcN6jAXCKjfm8cbTPsx OoO9axCJQDsY//vf5vgTv4hPeIg/ri+DEeTRoz6i0cO3+CfmiephASWJuUP3WjNZ0gLo 6yVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v5si5262896edc.166.2021.04.16.08.08.18; Fri, 16 Apr 2021 08:08:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244316AbhDPPFh (ORCPT + 99 others); Fri, 16 Apr 2021 11:05:37 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:37766 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242887AbhDPPF0 (ORCPT ); Fri, 16 Apr 2021 11:05:26 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4FMKJB6MPwz9v3LN; Fri, 16 Apr 2021 17:04:58 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id nfnIuGVT2LDV; Fri, 16 Apr 2021 17:04:58 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4FMKJB4wVtz9v3LK; Fri, 16 Apr 2021 17:04:58 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 0F4968B851; Fri, 16 Apr 2021 17:05:00 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id gM_a9XKodz3W; Fri, 16 Apr 2021 17:04:59 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 7EF558B84C; Fri, 16 Apr 2021 17:04:58 +0200 (CEST) Subject: Re: [PATCH v1 3/5] mm: ptdump: Provide page size to notepage() From: Christophe Leroy To: Steven Price , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , akpm@linux-foundation.org Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org References: <1ef6b954fb7b0f4dfc78820f1e612d2166c13227.1618506910.git.christophe.leroy@csgroup.eu> <41819925-3ee5-4771-e98b-0073e8f095cf@arm.com> <1102cda1-b00f-b6ef-6bf3-22068cc11510@arm.com> <6ff4816b-8ff6-19de-73a2-3fcadc003ccd@csgroup.eu> Message-ID: Date: Fri, 16 Apr 2021 17:04:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 16/04/2021 à 16:40, Christophe Leroy a écrit : > > > Le 16/04/2021 à 15:00, Steven Price a écrit : >> On 16/04/2021 12:08, Christophe Leroy wrote: >>> >>> >>> Le 16/04/2021 à 12:51, Steven Price a écrit : >>>> On 16/04/2021 11:38, Christophe Leroy wrote: >>>>> >>>>> >>>>> Le 16/04/2021 à 11:28, Steven Price a écrit : >>>>>> To be honest I don't fully understand why powerpc requires the page_size - it appears to be >>>>>> using it purely to find "holes" in the calls to note_page(), but I haven't worked out why such >>>>>> holes would occur. >>>>> >>>>> I was indeed introduced for KASAN. We have a first commit >>>>> https://github.com/torvalds/linux/commit/cabe8138 which uses page size to detect whether it is >>>>> a KASAN like stuff. >>>>> >>>>> Then came https://github.com/torvalds/linux/commit/b00ff6d8c as a fix. I can't remember what >>>>> the problem was exactly, something around the use of hugepages for kernel memory, came as part >>>>> of the series >>>>> https://patchwork.ozlabs.org/project/linuxppc-dev/cover/cover.1589866984.git.christophe.leroy@csgroup.eu/ >>>> >>>> >>>> >>>> >>>> >>>> Ah, that's useful context. So it looks like powerpc took a different route to reducing the KASAN >>>> output to x86. >>>> >>>> Given the generic ptdump code has handling for KASAN already it should be possible to drop that >>>> from the powerpc arch code, which I think means we don't actually need to provide page size to >>>> notepage(). Hopefully that means more code to delete ;) >>>> >>> >>> Yes ... and no. >>> >>> It looks like the generic ptdump handles the case when several pgdir entries points to the same >>> kasan_early_shadow_pte. But it doesn't take into account the powerpc case where we have regular >>> page tables where several (if not all) PTEs are pointing to the kasan_early_shadow_page . >> >> I'm not sure I follow quite how powerpc is different here. But could you have a similar check for >> PTEs against kasan_early_shadow_pte as the other levels already have? >> >> I'm just worried that page_size isn't well defined in this interface and it's going to cause >> problems in the future. >> > > I'm trying. I reverted the two commits b00ff6d8c and cabe8138. > > At the moment, I don't get exactly what I expect: For linear memory I get one line for each 8M page > whereas before reverting the patches I got one 16M line and one 112M line. > > And for KASAN shadow area I get two lines for the 2x 8M pages shadowing linear mem then I get one 4M > line for each PGDIR entry pointing to kasan_early_shadow_pte. > > 0xf8000000-0xf87fffff 0x07000000         8M   huge        rw       present > 0xf8800000-0xf8ffffff 0x07800000         8M   huge        rw       present > 0xf9000000-0xf93fffff 0x01430000         4M               r        present ... > 0xfec00000-0xfeffffff 0x01430000         4M               r        present > > Any idea ? > I think the different with other architectures is here: } else if (flag != st->current_flags || level != st->level || addr >= st->marker[1].start_address || pa != st->last_pa + PAGE_SIZE) { In addition to the checks everyone do, powerpc also checks "pa != st->last_pa + PAGE_SIZE". And it is definitely for that test that page_size argument add been added. I see that other architectures except RISCV don't dump the physical address. But even RISCV doesn't include that check. That physical address dump was added by commit aaa229529244 ("powerpc/mm: Add physical address to Linux page table dump") [https://github.com/torvalds/linux/commit/aaa2295] How do other architectures deal with the problem described by the commit log of that patch ? Christophe