Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210409093738.GH6048@kadam> <d3cd5c0b-f30e-6130-582d-7b68d8320507@codeaurora.org>
 <CAJs_Fx7fgeURHzm2k-Bb8h_xy1=-5vrbt+jt5J=vEzr1rEd8Cw@mail.gmail.com> <20210416043336.GM6048@kadam>
In-Reply-To: <20210416043336.GM6048@kadam>
From:   Rob Clark <robdclark@chromium.org>
Date:   Fri, 16 Apr 2021 08:15:22 -0700
Message-ID: <CAJs_Fx4WY9B_FudZtSe1hOkLbqy5pFZ=O-dfNJWtWMkJ=8ySbg@mail.gmail.com>
Subject: Re: [kbuild] drivers/gpu/drm/msm/adreno/a3xx_gpu.c:600
 a3xx_gpu_init() error: passing non negative 1 to ERR_PTR
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Akhil P Oommen <akhilpo@codeaurora.org>, kbuild@lists.01.org,
        lkp@intel.com, kbuild-all@lists.01.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Apr 15, 2021 at 9:33 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Thu, Apr 15, 2021 at 04:21:01PM -0700, Rob Clark wrote:
> > > > 5785dd7a8ef0de Akhil P Oommen 2020-10-28  571         icc_path = devm_of_icc_get(&pdev->dev, "gfx-mem");
> > > > 5785dd7a8ef0de Akhil P Oommen 2020-10-28  572         ret = IS_ERR(icc_path);
> > > > 5785dd7a8ef0de Akhil P Oommen 2020-10-28  573         if (ret)
> > > > 5785dd7a8ef0de Akhil P Oommen 2020-10-28  574                 goto fail;
> > > >
> > > > IS_ERR() returns/true false so this will lead to an Oops in the caller.
> > > >
> > > >       icc_path = devm_of_icc_get(&pdev->dev, "gfx-mem");
> > > >       if (IS_ERR(icc_path)) {
> > > >               ret = PTR_ERR(icc_path);
> > > >               goto fail;
> > > >       }
> > > Agree.
> > >
> > > >
> > > > 5785dd7a8ef0de Akhil P Oommen 2020-10-28  575
> > > > 5785dd7a8ef0de Akhil P Oommen 2020-10-28  576         ocmem_icc_path = devm_of_icc_get(&pdev->dev, "ocmem");
> > > > 5785dd7a8ef0de Akhil P Oommen 2020-10-28  577         ret = IS_ERR(ocmem_icc_path);
> > > > 5785dd7a8ef0de Akhil P Oommen 2020-10-28  578         if (ret) {
> > > > 5785dd7a8ef0de Akhil P Oommen 2020-10-28  579                 /* allow -ENODATA, ocmem icc is optional */
> > > > 5785dd7a8ef0de Akhil P Oommen 2020-10-28  580                 if (ret != -ENODATA)
> > > > 5785dd7a8ef0de Akhil P Oommen 2020-10-28  581                         goto fail;
> > > >
> > > > Same.  ret is true/false so it can't be equal to -ENODATA, plus the
> > > > caller will Oops.
> > > >
> > > > Btw, this patch removed the assignments:
> > > >
> > > >               gpu->icc_path = of_icc_get(dev, "gfx-mem");
> > > >               gpu->ocmem_icc_path = of_icc_get(dev, "ocmem");
> > > >
> > > > So I think "gpu->icc_path" and "gpu->ocmem_icc_path" are always
> > > > NULL/unused and they should be removed.
> > > >
> > > Agree. Will share a fix.
> > > Thanks, Dan.
> >
> > gpu->ocmem_icc_path/icc_path is used on older devices.. it sounds like
> > we broke some older devices and no one has noticed yet?
>
> This is error paths and dead code.  Probably no one is affected in
> real life.
>

oh, right, we are using devm now, so we can drop the icc_put()s

BR,
-R