Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Apr 2021 15:55:11 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Rob Herring <robh+dt@kernel.org>
Cc:     Clemens Gruber <clemens.gruber@pqgruber.com>,
        linux-pwm@vger.kernel.org, Sven Van Asbroeck <TheSven73@gmail.com>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 4/8] dt-bindings: pwm: Support new PWM_USAGE_POWER flag
Message-ID: <YHmXPyf+XjgJs3C8@orome.fritz.box>
References: <20210412132745.76609-1-clemens.gruber@pqgruber.com>
 <20210412132745.76609-4-clemens.gruber@pqgruber.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="XbFHZBPVqfivajiW"
Content-Disposition: inline
In-Reply-To: <20210412132745.76609-4-clemens.gruber@pqgruber.com>
User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06)
Precedence: bulk


--XbFHZBPVqfivajiW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 12, 2021 at 03:27:41PM +0200, Clemens Gruber wrote:
> Add the flag and corresponding documentation for PWM_USAGE_POWER.
>=20
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> ---
>  Documentation/devicetree/bindings/pwm/pwm.txt | 3 +++
>  include/dt-bindings/pwm/pwm.h                 | 1 +
>  2 files changed, 4 insertions(+)

Rob, what are your thoughts on this? I've been thinking about this some
more and I'm having second thoughts about putting this into device tree
because it doesn't actually describe a property of the PWM hardware but
rather a use-case specific hint. It's a bit of a gray area because this
is just part of the PWM specifier which already has use-case specific
"configuration", such as the period and the polarity.

Perhaps a better place for this is within the PWM API? We could add the
same information into struct pwm_state and then consumers that don't
care about specifics of the signal (such as pwm-backlight) can set that
flag when they request a state to be applied.

Thierry

--XbFHZBPVqfivajiW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmB5lzwACgkQ3SOs138+
s6EIRBAAopZq0WA+PGKaCMBdc3iqIKquJL4ZtHYLNy7PIFmUgxNw2bn/B3IRihS1
WKd0Tvt9OYiP9vMhVKdUUm2W0How6aUWgACYAfj1O8LZU5Xa44ENeXSCkACBN6mW
A+ff1QrfNZqxE9BtFPChjTKsm2ty+2ybzT9Z5RcwcmWoZn2/rioZGsx79QzuO02Y
D1fk3L7jkPa7sZsqwkJOdBgSb31hgMzPSOxm3VZaJoxIxr+uIEqJVHNG5vpw/cY0
EStGp0wZc5uROb/zFFlHTi5JuAV+Mxrk/2A6vUU+IL6OwFQ3o1toTQToIW+oK1Ul
1gh/Ts3lFj3O6ALj/8n7pW6eN6JAnE0ZZo75ccWHmaNmzypPNiePA0Vit1WDklZM
KtdIHdCTC0i55R90wFQNPZBhYIfk72hNUJGWjHQV5AwmjwmsXGPLY6q0qvl11kzy
kzDg7CSF2E1BuIb4VGAg+fdJzsoaVQa4pbNT1TYB94eQvPZXUvJ7urNBOntKWH6T
IpDp/DJd5btx+qsXLFKF3fqyEwYlpfQkZlCqhEBM8Qivwa7pMrCLp8YpsDBXGwPK
36GJAzwDQRRx2Efgugk898nZ60dCllaJyt+rMs8HpCkkb6P8OsRuXrrgEcOVLtzl
MkQ1FhpXZOjiIcCh1tqcfjv/7KXCbkam1O2i7d1JSpiHbAzL/Cc=
=GQic
-----END PGP SIGNATURE-----

--XbFHZBPVqfivajiW--