Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Apr 2021 14:41:08 +0100
Message-ID: <87zgxys5xn.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Robert Hancock <robert.hancock@calian.com>
Cc:     tglx@linutronix.de, michal.simek@xilinx.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip/xilinx: Expose Kconfig option
In-Reply-To: <20210415233250.4071772-1-robert.hancock@calian.com>
References: <20210415233250.4071772-1-robert.hancock@calian.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 16 Apr 2021 00:32:50 +0100,
Robert Hancock <robert.hancock@calian.com> wrote:
> 
> Previously the XILINX_INTC config option was hidden and only
> auto-selected on the MicroBlaze platform. However, this IP can also be
> used on other platforms. Allow this option to be user-enabled.
> 
> Signed-off-by: Robert Hancock <robert.hancock@calian.com>

I don't think this is a good idea. In general, people have no idea
which interrupt controller they need to select. So you either end-up
with a missing interrupt controller, or a bunch you really don't need.

This is essentially a platform constraint, and this should directly be
selected by the platform if you have this IP in your system.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.