Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 27/40] drm/ttm/ttm_device: Demote kernel-doc abuses
To:     Lee Jones <lee.jones@linaro.org>
Cc:     linux-kernel@vger.kernel.org, Huang Rui <ray.huang@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org
References: <20210416143725.2769053-1-lee.jones@linaro.org>
 <20210416143725.2769053-28-lee.jones@linaro.org>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <e5d30ac1-3037-0101-0e1a-9df6a8580c70@amd.com>
Date:   Fri, 16 Apr 2021 17:32:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
In-Reply-To: <20210416143725.2769053-28-lee.jones@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:5d8d:1198:63ca:8fe4] (2a02:908:1252:fb60:5d8d:1198:63ca:8fe4) by FR3P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.6 via Frontend Transport; Fri, 16 Apr 2021 15:32:58 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b942ab02-1131-4f6e-2b15-08d900ecea33
X-MS-TrafficTypeDiagnostic: MN2PR12MB4783:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MN2PR12MB4783DC04709DCF9A0B3443AE834C9@MN2PR12MB4783.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TFgaPaSaH1J2G21lYQGIzFtzN1oHdLGx+joK7hTTZ/zlMZzQMNcA3DospUhsSpDGZAuklcr9UXd8nk5gzQMh9Iy0Wm14la/3hxfiuH6VxEOvbeLbry9HISI+i/tLv8Es/d8ch33Alp4a8U0l6yft4Gfw3FCtqQww9i8NCkDvDMtGIr/Qhn6vkr1yPGM4cnxigH2K94eFurEffrBjt9jVcqukUUFzIB8/SigQZjwYh7YACP8/QgeD7VgGCKXNsXnXXbDQe2PsKUbBc+luVnwT/w7HUJE2IOiqQpdbZbBgMMHHRO/k0dA1+AYUjmqjBs0mjQVrJSODgrdUYC4+vvgyInLinIuCTkAayoE+pD1U3FxKJ6GcJxx+S0pS874mDZt1MCj666MusMwpGIEST8hr6N/gNkL3i2fdUOmPq7/q7RvOHVRNlHpizPHsUnKVymWMB3UsozhA65wiBkh9gkyZY/xvHm8KW6ppdK/4z9aeN3+JMOZP7G/8UZ70/JMJd9KX4qPb2bvAKidxSzmYb9UO2mXTqTMAK2PaP4A0lTVwDUWuEi8Y+V7wfUaplbDuvLlAf8b4Wtei9uVn7Wu6ayaT35KtaRA56BI/2AS21MdWIMHEWF0bf+YvXPXLAK75TZRgLU+qUDTBvjwmJEXOAmk9TvQ8aqWxfphDM/wXEUmn2oqVHB1BmHvhj9sHmrS2DiHv
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(396003)(39860400002)(376002)(346002)(38100700002)(52116002)(66476007)(186003)(66556008)(83380400001)(6916009)(54906003)(8676002)(316002)(5660300002)(66946007)(66574015)(16526019)(4326008)(36756003)(2906002)(31696002)(6666004)(478600001)(31686004)(86362001)(2616005)(6486002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dXE5VkJlY2N2c1FSdTE1a0lyMFNCcTFhKy9NTmR3dEhMWkc4enpWdE5YTnVU?=
 =?utf-8?B?dlVRakFnTm5hZmNKZ21iRng3WFM2cXZ6MkJXdHZiRlZRdmtpWE8xNGdHOU1t?=
 =?utf-8?B?SmZROW9ldlJKUmFZUjF4L2svNndtUytKRzhZbXBKSS80ckdhTVhBeWVtZWl4?=
 =?utf-8?B?VitJTWp6R0MzYUcvb2lucVdMNUY0c3dFazhtcmpDNWw0UXhlUEhSajQyS3Fs?=
 =?utf-8?B?dDBoTldWbHhFQ2t1SWorMGw5YzBWaUYzT0hpcDJlWnZNYnIvU0FIZHNTYVZL?=
 =?utf-8?B?WWdPanFkRzdUWWFoWjNWdUlqRnhMV3lFaTVmN2VJZEZqM1ZtUUUxOTJjL2xP?=
 =?utf-8?B?c093Yi8weWU1NmFNai9uRHFLRzVyVnBMZDBMRndqQ2JvZTBUYjg3cFBqclMw?=
 =?utf-8?B?Y21zNHlEWjByK29kSHNjUGJBaldCY0pYenFEN0VFcml3VERhdEJjYjhwaEVD?=
 =?utf-8?B?cTNEdUxWaGU4NWYzZEZ6cGpoeUFtbFFvQmJrZGthK0diT3NzQlZUVzJGbUxa?=
 =?utf-8?B?RWhLaVZlNFJObmFjcjM2V3pXNElNSGRjSUVlR2VXaVFOM3pITkgvMGp5Tm9m?=
 =?utf-8?B?dFowaVpqVnZoT2tOQnNaaTc1SHFjTHpoSDFUcXllMUFXWHdhOUUzaWRXbTR6?=
 =?utf-8?B?Sy8wa3hUOUtsQ1JUT1dBQi9ycUdNUGVXVnVpaU1SeGNwMjV2ckJQenFva2Nq?=
 =?utf-8?B?YWNLYy9IUEsrc2hkaDlqcVFrS1JzamVyYThOcjU1dlhpVzd6dUdxQjQ1dnUx?=
 =?utf-8?B?YXg2QnJTcUZ3SUNjMzRpUFFhWCtBYjI1d2JVQjY4aXJDdjl0WHREZU5LaTZR?=
 =?utf-8?B?dURIaW14ZzhyY1lEUUxCSlFtS1oxMThqejF3NG05M3FLZE5LS1lEU0lHcDlh?=
 =?utf-8?B?am5LVkJ2aFkwUEFmVFFVblZ5YVJPNE1vV1lhSlRZaUc4bzE2RURlb3lYNnVJ?=
 =?utf-8?B?YVB0VEhiOVRGOHQrUVZmOEVXSlpMUUZpakFuSWwxVUZoM1pOMWlQUnY4Q2RS?=
 =?utf-8?B?aGh2NjZZV1doZTR5R2FCYno3VC9ESjFQRm1jbXJCbWJOb3ZZeWFiZEt3TDhy?=
 =?utf-8?B?bEh0Nlh5Mkc1QWp0Y0RFYWFUaHlOazFmNFZmVEk1UXQxOTI0aXhIeWRPQnNo?=
 =?utf-8?B?OUdtdWN1ZTFLT0FnckV6M1dpNXFIVEw3Q3B1QVNKSE9FdjBnOWpra054QXlm?=
 =?utf-8?B?QS9QNkRDclFmajZSdDV2aVVhc0pWTnhRZkFsZGt0N3lVQVJPSUJCNStldmFz?=
 =?utf-8?B?bXhjR0pSUlVjdWFuNkpndytpT2dTcG9nMTNsSzBsVERVaUhqZkpsYjhJQkJN?=
 =?utf-8?B?QW5WM0l3cmM4QnJLWkc5b3IwbHM2aGVFbDVpaFZEbFl3VVkyRVJJWlpmSXVM?=
 =?utf-8?B?aFdJeUxBbldFdU03UmdSdzROTUdsbElBMjNXRXptK212SnVIRmpNUWNPcWJh?=
 =?utf-8?B?Ry94Mlh5NDU0dWR0TEpiV0p5RnZrQmxrUGFSRHBURzdoRzgrZHFwMGRIbHA2?=
 =?utf-8?B?WGhWNVFUNXlFeFBUd0k0cCtIZzNWNGc1RVVRVnZUYjV6bFRpU1BNbHhtWmJm?=
 =?utf-8?B?bDI3bVBqcWNzcDcyTmRxUHdYOElITTJwMUh5NnZJRFdMSm9UN01zai8wRGJN?=
 =?utf-8?B?UHkzSTdsY3RYMERFTnFFTkx2RnlwaTRhNmxScTlCaURtYkZ2dWxUdE9SWlB6?=
 =?utf-8?B?TkZLU2lqNVFqUEplZDFrUmorWjhEM054NDRlYWxhOExoRkIwOGpYd1BKZWEx?=
 =?utf-8?B?MzhYYlhYOCtoRlFpNVluMXhxWTgydTBwcmFmSjZLeG1IUWVxSk1SUTR0VW5i?=
 =?utf-8?B?cTZFVFJyb21BUDd0d3U2R3Iwc1NTRFIzNllOQ1RKOWV5MXM1OWF5eHBJMm5I?=
 =?utf-8?Q?FA7cHJBwri/kP?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b942ab02-1131-4f6e-2b15-08d900ecea33
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2021 15:32:59.3548
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FhkCUOrG3bGoo+M1P8CQYhyAP3oG15qXc+zVU1u8Gj6ExsR7jO/YEb7kGY1SeNoZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4783
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 16.04.21 um 16:37 schrieb Lee Jones:
> Fixes the following W=1 kernel build warning(s):
>
>   drivers/gpu/drm/ttm/ttm_device.c:42: warning: Function parameter or member 'ttm_global_mutex' not described in 'DEFINE_MUTEX'
>   drivers/gpu/drm/ttm/ttm_device.c:42: warning: expecting prototype for ttm_global_mutex(). Prototype was for DEFINE_MUTEX() instead
>   drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or member 'ctx' not described in 'ttm_global_swapout'
>   drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or member 'gfp_flags' not described in 'ttm_global_swapout'
>   drivers/gpu/drm/ttm/ttm_device.c:112: warning: expecting prototype for A buffer object shrink method that tries to swap out the first(). Prototype was for ttm_global_swapout() instead
>
> Cc: Christian Koenig <christian.koenig@amd.com>
> Cc: Huang Rui <ray.huang@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/ttm/ttm_device.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c
> index 9b787b3caeb50..a8bec8358350d 100644
> --- a/drivers/gpu/drm/ttm/ttm_device.c
> +++ b/drivers/gpu/drm/ttm/ttm_device.c
> @@ -36,7 +36,7 @@
>   
>   #include "ttm_module.h"
>   
> -/**
> +/*
>    * ttm_global_mutex - protecting the global state
>    */
>   DEFINE_MUTEX(ttm_global_mutex);
> @@ -104,7 +104,7 @@ static int ttm_global_init(void)
>   	return ret;
>   }
>   
> -/**
> +/*
>    * A buffer object shrink method that tries to swap out the first
>    * buffer object on the global::swap_lru list.
>    */