Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 22/40] drm/ttm/ttm_tt: Demote non-conformant kernel-doc
 header
To:     Lee Jones <lee.jones@linaro.org>
Cc:     linux-kernel@vger.kernel.org, Huang Rui <ray.huang@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org
References: <20210416143725.2769053-1-lee.jones@linaro.org>
 <20210416143725.2769053-23-lee.jones@linaro.org>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <2a85bf3c-d40e-6608-98f3-cd399f4df912@amd.com>
Date:   Fri, 16 Apr 2021 17:34:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
In-Reply-To: <20210416143725.2769053-23-lee.jones@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:5d8d:1198:63ca:8fe4] (2a02:908:1252:fb60:5d8d:1198:63ca:8fe4) by AM0PR02CA0150.eurprd02.prod.outlook.com (2603:10a6:20b:28d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Fri, 16 Apr 2021 15:34:57 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e3ac8195-badc-444a-90fb-08d900ed3136
X-MS-TrafficTypeDiagnostic: MN2PR12MB4206:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MN2PR12MB4206D4057F51F2A660EC0C1C834C9@MN2PR12MB4206.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: upnlecIYF4XCoUgMMJB41siSTXh/Nw7SvuewsCtd42Qv64kRyfiBmbXsu2FtT8WeBlJThVOTnztm2mM78Xe+hTYj0B/CGLqqWVmdI8Vrh05i1W8dINQzLYt0df+4ZLYXcc6ru+KfX8Z1L2evhX+wPKgC5xiLb3tznNfD1WM3y4cQiNqPGB2eGNc/OWl6NM8I/PujVYWVlDas5AWWYPegRtaV2EWOKZZb/Q1c985XRLkDEcAttcgtcWGL//djFCihcrz8/pNc1D4gu+/bWbGxB7RFfGuKMaZOdK60ZayfIehlTrj8lP35e+TEk+s1QGVOOdoZwJnwr2vtbhHoGJ4jz4PIrmzbm/OgNUbSbvrkwvDpcM2I2kT4NykFtx3Ra4vsmKdMNqq2Ynq4tX9kgafASBX38wBTi3D04w8YSoz5rIQBmMUUh/7dxcUw41vi3ZGnaewZ7Z9VyPLK6F7wXxpM3g3Dd92mWa0A3hlmuBOGeiitk0hFDh/oRn8uQhiqepSZpbGrGMbmRLcc5NP5Csw7iGop2V/zNXP9qz5e37KhG/ZLQL3xPnN9OpMt7SzFpoJfWIGT3ayYrQEwsdVsyv7HOy1Yn9MTPDptP0he8bFs8MFToo7llK8zAHVtmweQKa1xLGfL25sVwF553X+017W3pVq0tYMe4j8Fub/ydcsdiBmvFxg3M1kRP7tyNvC3ul8n
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(39860400002)(376002)(136003)(346002)(36756003)(6666004)(54906003)(31696002)(2906002)(66556008)(66476007)(5660300002)(8676002)(66946007)(8936002)(2616005)(316002)(478600001)(6486002)(31686004)(38100700002)(52116002)(6916009)(186003)(83380400001)(16526019)(4326008)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eUJKOTFmN0hWZ0x6RGoxbUJ4N1JTdlZ5eTBpY1pWQWFMVFpibU84cHFaN0tq?=
 =?utf-8?B?bm11a1U1Wjk3cWdwRFltZ2RjRThxSE5BSm5XZnZKSUliZDhEYnRWU1dYVnV6?=
 =?utf-8?B?V1JxNFhsK05qckk1Tmd0R20rbVVBMU9xU2wzS1Z1OXdLZGlsVHlYZUF1a3hi?=
 =?utf-8?B?SDRoR25wOWxVZHFEWE5WYlhKdEpxWjZienJRTks5VytUS0VvQlp3ZzR3QlQw?=
 =?utf-8?B?akNUaUx2dkV0QWh2VFo1U3UzekRXYWpsVDh5dWJZU2VwTmpTeCtKWXd5WUZq?=
 =?utf-8?B?SXBGNlJ3enFiMDQrUzBoVXc3dmpSQTUrNlZzWVZoOUNWY1N0NmdaNnYwVkZh?=
 =?utf-8?B?NEcxSnRRakJ4UlJUQkNuSTFHc1dpNnRkVEJMdHp3TFhaVjlqbFArZlVyQStF?=
 =?utf-8?B?bGVQczYxMVZUV0ZwVHg3YzhROUpyYmlxZmZidkdiZk5NN2dTamNlV0RmOFRo?=
 =?utf-8?B?bW5VNXY1RjJJcVZuV3MrM2JjMnZpL3dwN2VMTUNuSnZhV2dSNng1WXREKzBB?=
 =?utf-8?B?VUxjZjJEa3NHL1NlZUZuQ2hBZFFXSkY3UTFZa2VCcTB1TUlwWU43Ni9kckJm?=
 =?utf-8?B?cW9lalphMDNDY2ZhakhqLzBvT2NMczJlRHdkWmRzTU5RdnZrREZOZ3VoWEh4?=
 =?utf-8?B?WXVOWjJhVDZRR0o1cWcvSTFoUU9QdTZNaXNDYVNCekFPUU5VS0J6NVNUWXlT?=
 =?utf-8?B?U0ErQXhTbUlGdi9JM0xHVUxjbEVrUGZBUDFDa2FVODdXeG94azkxSVlMRGI3?=
 =?utf-8?B?aXlITGpFM3AzQ2d1YUVXS0pWOXN5bnUwT1F2RzVaWUJpOWFzeHpzNHRCSzhK?=
 =?utf-8?B?Sjk2cGgxWXBhWUtFcW5Wb2J6QW01Yk5HS1h3NUZySWg5NlVwbE1oR1U0bFNC?=
 =?utf-8?B?TzJUTERqZjFlUXFLS1ZFMTRDQ0pjRnk5WkJuQ1AvNjk3VjNDWStrVjZWUTdX?=
 =?utf-8?B?bW44SVpQbXVGcGVUdU84TG1zem5xN3QyMDJwakRRRlVVcWN2dHhvMWY1azE0?=
 =?utf-8?B?YkY5RDZvQkhodlozRnhzN2grNy9lcVV3bDZod1JMQS9nUW11c2R5d2FNMFlQ?=
 =?utf-8?B?SGZSNTJGR2NsTGlWUE1CdU5saWVuL2IwL2NQbHdlWi82OWw5cmdkZ1BxVHg0?=
 =?utf-8?B?WENuRG1PdHpkTVBxeHNCYkN0Y1FnNWEwZ1l0UTRMaW0rL0hZSjZNdjNWS3FR?=
 =?utf-8?B?bU1SUWhYVXo4OUM2djJ3U1F0VEpxSHE3WFVpSlJSVlpmOE5oTm9sV3BQY1h1?=
 =?utf-8?B?UHlUWnNFSjFwOTVuemthckVBWEVueG9zZVFyTTNDNWk5NnpmbkJ4QTVHcTFa?=
 =?utf-8?B?UVpNV1hyaFNqSmlCdXkrSm1PVHlNZXdueU1KaDhRWTZjaE1jbnozUVNLRUsv?=
 =?utf-8?B?S3Y1NnBPeXBrUFU0d01mZElBaXNUSFZ2UkVhQ2dnb0MyQjlRN3RvWkVnTUZW?=
 =?utf-8?B?bXJxZVdFdlFST3E2OEROMm9BaS8xcVlBT3M2RWs2RDRoREZrMnk4czA2aFhF?=
 =?utf-8?B?eEYzbDZKRE5QU1BPSDhMeEhwQUhqN2x3a0cxc2xadlY5Zm9obEdoKzB2OCtT?=
 =?utf-8?B?azZ0Vk5xSTFRQThCRlJVYUEwK1JIUktWWUpJckRxVkxLVWNjSjY5QmZ4TU0y?=
 =?utf-8?B?RkZhUW5pcFB1NUtjWXZnL0FNUlFRTnk4VWtjQzdXUlBjb1BnVk14SStzbjg0?=
 =?utf-8?B?dGtRK0xzS3dPbFc0SUh2bHhPZ1VHS3ZMOXVybjFoUHZvTzBMQUU0OGRLYzRN?=
 =?utf-8?B?Q3NGRlZqSFVHZW9rd0gxaWNQbzQ0RmFhV2hJQSt2eHo5dk9EWmJ1MGtTajNB?=
 =?utf-8?B?Q09RNmRTWnhmeFlJZG9iTWRSTnVBRld4b0pYaXlERHYySFhManFWeWVFODZQ?=
 =?utf-8?Q?De1bHTxrw/1s9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3ac8195-badc-444a-90fb-08d900ed3136
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2021 15:34:58.4783
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DUSPi4PBoR3VuzJyR78RnKtMPLV4F3c71MROxrjDZU0pYIM3gwoq8/8kqysMtHCj
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4206
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 16.04.21 um 16:37 schrieb Lee Jones:
> Fixes the following W=1 kernel build warning(s):
>
>   drivers/gpu/drm/ttm/ttm_tt.c:398: warning: Function parameter or member 'num_pages' not described in 'ttm_tt_mgr_init'
>   drivers/gpu/drm/ttm/ttm_tt.c:398: warning: Function parameter or member 'num_dma32_pages' not described in 'ttm_tt_mgr_init'
>
> Cc: Christian Koenig <christian.koenig@amd.com>
> Cc: Huang Rui <ray.huang@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

For that one I would rather prefer to just document the two parameters.

Christian.

> ---
>   drivers/gpu/drm/ttm/ttm_tt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
> index 7dcd3fb694956..d939c3bde2fcf 100644
> --- a/drivers/gpu/drm/ttm/ttm_tt.c
> +++ b/drivers/gpu/drm/ttm/ttm_tt.c
> @@ -389,7 +389,7 @@ void ttm_tt_unpopulate(struct ttm_device *bdev, struct ttm_tt *ttm)
>   	ttm->page_flags &= ~TTM_PAGE_FLAG_PRIV_POPULATED;
>   }
>   
> -/**
> +/*
>    * ttm_tt_mgr_init - register with the MM shrinker
>    *
>    * Register with the MM shrinker for swapping out BOs.