Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 32/40] drm/amd/amdgpu/amdgpu_ttm: Fix incorrectly
 documented function 'amdgpu_ttm_copy_mem_to_mem()'
To:     Lee Jones <lee.jones@linaro.org>
Cc:     linux-kernel@vger.kernel.org,
        Alex Deucher <alexander.deucher@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Jerome Glisse <glisse@freedesktop.org>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org
References: <20210416143725.2769053-1-lee.jones@linaro.org>
 <20210416143725.2769053-33-lee.jones@linaro.org>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <eecd70a6-eb05-ea13-e9ca-c0d989f2210b@amd.com>
Date:   Fri, 16 Apr 2021 17:53:36 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
In-Reply-To: <20210416143725.2769053-33-lee.jones@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:5d8d:1198:63ca:8fe4] (2a02:908:1252:fb60:5d8d:1198:63ca:8fe4) by AM3PR03CA0063.eurprd03.prod.outlook.com (2603:10a6:207:5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Fri, 16 Apr 2021 15:53:41 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7849d282-8b0e-4cb0-164e-08d900efcf8d
X-MS-TrafficTypeDiagnostic: MN2PR12MB4357:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MN2PR12MB435763ACC4BCC5AAF1A439DD834C9@MN2PR12MB4357.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: oRdlPysRb4MqGfyNKIlLPPzhxsdg7YnhfpEqzroLhjGTv39JmonflVXn+/e3CnH25j6g55sZJ2U07gzi/3vRgLr8fa+919Xu+/Ehau//Dx+jCYJ9HGvLH8ydsKqkO12sXdqSgM4QAWLgwGpq1jytY+NgoiqHdh6Dz4b34vIan1RJyyTwu41CJi+Dz42CXma3wCA9+D8SseTJKpl1FgYIdSI0+X9ZiNBgtxX6+O1aVdLk3bKKo26bKNcSa6myNnG3sGQQtzE7BqJjZiGdY1VgT1ZzYEpTMma0ybrJOFYiQ6fM+JNTPXh8UWzG2UbYHASQEx/kS77dC/0kc1JwuOko6FmW5+iY1luArgsJyEsKkZpK/kumRYzDs0LLxMkl10HpCMFR3aYNVDcty1Uio6KTIKjqHqNHv65CLqjQv+4CxUSLqg6pboUJ7A9LOhoUnd/Cn42eI57KHv7Fa0XmAgG2phg8zD7D0M5OCwOI3spK5kye32ZpWnc7DclHgTM9Y/DP3s2bnN6W+mscN3LcTHAtlGg0ac7ymAwX6ut0RhvPvRukSTJMh9uwertuU4CpLy0tsqDyUFb6FlS4Dpvd4q0eMC1eu+guwJkyjb0bIpRK3mf3hjHskCqKQk9PQcvtoMpyzxejoD2tHy+Lmij6toYl1il2vRwTxrz50lMKxzBDAy5Z9u4LsD8S5sL33jjL+SZt
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39860400002)(366004)(396003)(376002)(346002)(4326008)(316002)(16526019)(31686004)(186003)(6486002)(83380400001)(5660300002)(2616005)(86362001)(36756003)(54906003)(66574015)(52116002)(2906002)(66476007)(6916009)(8936002)(478600001)(31696002)(66556008)(6666004)(38100700002)(66946007)(7416002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bjVJTVlmdlVHYnJWN0krYkpUUzF3SzErK0p6NVFhVGc1TUVvMmRSU2t5dyto?=
 =?utf-8?B?QXI5VlRIamhDQlVackQ1VEZtYnZNZnJMN2hQYjNBd1BSTG1jWDMwb3lMSjBY?=
 =?utf-8?B?dTQ4WWlhOGhSeEhHRmpKUTBGMWVlSGF2OW95N29oRnJBSXhxTVQydkVBK2o1?=
 =?utf-8?B?eWNxeXp0U3doTHFNZFVhQzhNMVBzd0lUYWx6OXhpcC9uVk1zUUF5ZGVxcisv?=
 =?utf-8?B?cE83SDRURisxQW9wN1IwUWpCZHN2OWw5ZHkrUUwzQTFJRDViUHRKVjA2QXd3?=
 =?utf-8?B?eHZKUExPTVAwcGFzYStSWkNOZHEyYTRoWTZ6eU5oSEhYcmNBYjR4aDBsTERB?=
 =?utf-8?B?bkVnc1lYY3ZvSHArSlNJTHpKS2pkUUNqMThDRG1BNFkxOUI4c3k5UjdMdkt6?=
 =?utf-8?B?Y1Q4cytnblpVQmFtRkJ0bmhNdi9sRGN4R0R4MXE0NWxqTXVTYTF0aVdZTzZW?=
 =?utf-8?B?OVhiRHBxVnlROFMvV0lSVGE2d0tiZ290VldrcGFsOXV5R1JjMVlaMkRHaGdn?=
 =?utf-8?B?MTRjWVlacEFidEx0K0VVWDVkYnZ0bSs4NWtzdExuMXRxN2NmWDJZbTJKeGhY?=
 =?utf-8?B?RTB3bkd2UmRDd25vMDU3cnhlRXVOUHJLekNmQWJxNEVMNzFuQ3R6T29JdXdL?=
 =?utf-8?B?Y2hGMTdMWFdLbHZvNnRjd21OT1ExU1ZWcEJKaVppcWRENk9JbTIrd2o3Vktm?=
 =?utf-8?B?akc0eDQ5RWh6NjQ2Y2hzZEVwbFk4c1RERk5XcjZSejlQdEVCbXNySVdJTC8y?=
 =?utf-8?B?cWc2Uldvd3dNMTdGTUVDemh2TXhQcEVpODQydURkdFdzZXN1MHRhZjZkWGg0?=
 =?utf-8?B?TXcwUkh1TGJxd2VoS29hM3dML2lCS2FocjVhOVp1SmxLOTd5ei93V2ZVWDJo?=
 =?utf-8?B?S3U2SXRua2lnSTdnUnRVWFJwVmVkQ1UwM0g2Y29kNmd2RDV5SWg3RVVMSHZa?=
 =?utf-8?B?bVQxSVRZS2NKcmIxOHNqOEZNV3AxMjVpY2FvSDY0SVcvRzZieEFNaGZGVEhM?=
 =?utf-8?B?VTE3cmRkNWlhMGlyeUlHbFBpRGRzTWtTVWM4L0lTM0piQStPRlRtWEF1RzJs?=
 =?utf-8?B?YlROR2dNYU56YWYrQ3J3b0MrTk1tbzBVNW5oSWxnTEVQSlJUd3E4bXJIUmJL?=
 =?utf-8?B?aDlvVXpjNkl0bDdTcDhVMDJ3RGtIbXpNRGFybUVtbVlIZnFxLzFSQzZ2RFI4?=
 =?utf-8?B?YmNqT3d1R284QkJYRTFONFc1TE8rRS83QzRFSnRPSnhBQmdyTFFkMjNGZ2dk?=
 =?utf-8?B?UE5KQ01leTk0cUtlVDNuVTI1M1l4eU1TMU95Q2RLcHhwVnFZV0V4NU4rUWQ4?=
 =?utf-8?B?ZzEwYVRvdVBMaFZ3MnVabnZCWE9aM2UwQVc1bkk0VEYxbkhZMmxmMkJBWlBM?=
 =?utf-8?B?VFJudjEra0pPY01nVmRWSEVOTzZiUVJRMEZoOUtvaEd3MlNJWlg3VnZlZzY3?=
 =?utf-8?B?NnlpSWZIcW1mZHNpVUZCeGFOR09IZnRWaGFZbkhDZGtEYjJKOFVSamVtZk5M?=
 =?utf-8?B?aU5sOVE5aVZPVDN2MjNYajJLWWJQQmhvTVpWQncrOHBPaVFqOFpSUnBZRVNp?=
 =?utf-8?B?OVNCM2tGSFVHQjIxNERnL05MRWZGa2dUQjJBQlltODF6MnVxcFZrMEMyaDdj?=
 =?utf-8?B?enV5ZloxbG9lNHdZOFJyemNlTnY5dmFWOVQ3d0tNUVRZOCs5ZlpxdDlyaVNm?=
 =?utf-8?B?N0xMc0NJQjY3K29zeGhEMURwMUpCZ2dUZlpLcXZMOUg2M1dSYmtNVnQ0d3dT?=
 =?utf-8?B?M05aNmtBVzRod3gzdlRLbER5c0pwMDZ6ekhldG9pNXBXVnhOcDlSclRUdnox?=
 =?utf-8?B?OHh6REhpZ1YrWmdHdjc2QjNoSm9RR1dqMjluZkJFZnJhY2l1bnJSY05peHU2?=
 =?utf-8?Q?u1EaG6iBXUFMy?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7849d282-8b0e-4cb0-164e-08d900efcf8d
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2021 15:53:43.0298
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 296FWH3nBWShuip1l+Zh6GJWh1fkdf8fF4bJlhBHIESUY//hubsvkVZNCQwA+L9T
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4357
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 16.04.21 um 16:37 schrieb Lee Jones:
> Fixes the following W=1 kernel build warning(s):
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:311: warning: expecting prototype for amdgpu_copy_ttm_mem_to_mem(). Prototype was for amdgpu_ttm_copy_mem_to_mem() instead
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Jerome Glisse <glisse@freedesktop.org>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 3bef0432cac2f..859314c0d6a39 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -288,7 +288,7 @@ static int amdgpu_ttm_map_buffer(struct ttm_buffer_object *bo,
>   }
>   
>   /**
> - * amdgpu_copy_ttm_mem_to_mem - Helper function for copy
> + * amdgpu_ttm_copy_mem_to_mem - Helper function for copy
>    * @adev: amdgpu device
>    * @src: buffer/address where to read from
>    * @dst: buffer/address where to write to