Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Apr 2021 11:23:44 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     bhelgaas@google.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: shpchp: remove unused function
Message-ID: <20210416162344.GA2724691@bjorn-Precision-5520>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1618475422-96531-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Precedence: bulk

On Thu, Apr 15, 2021 at 04:30:22PM +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
> 
> drivers/pci/hotplug/shpchp_hpc.c:177:20: warning: unused function
> 'shpc_writeb' [-Wunused-function].
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Applied to pci/hotplug for v5.13 with the following subject, thanks!

  PCI: shpchp: Remove unused shpc_writeb()

> ---
>  drivers/pci/hotplug/shpchp_hpc.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
> index db04728..9e3b277 100644
> --- a/drivers/pci/hotplug/shpchp_hpc.c
> +++ b/drivers/pci/hotplug/shpchp_hpc.c
> @@ -174,11 +174,6 @@ static inline u8 shpc_readb(struct controller *ctrl, int reg)
>  	return readb(ctrl->creg + reg);
>  }
>  
> -static inline void shpc_writeb(struct controller *ctrl, int reg, u8 val)
> -{
> -	writeb(val, ctrl->creg + reg);
> -}
> -
>  static inline u16 shpc_readw(struct controller *ctrl, int reg)
>  {
>  	return readw(ctrl->creg + reg);
> -- 
> 1.8.3.1
>