Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: CUvtflCDenYtdx1J3Y5U3HRC7apm0zmd3LUHAPlxzB8zoUsbV6ra6WBG7veX2L0mnYyoGXARjP
 Owiw7a1bBhug==
IronPort-SDR: /G8uWyJoqpYxFkZQD8VLD5Dqg8KkxE+HRNc5pUt16jLXo3D9rjLp7z4QNfAQZgV6fimW794iI4
 VbkG1qA30tNg==
Date:   Fri, 16 Apr 2021 20:36:10 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org
Cc:     Dan Williams <dan.j.williams@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH v1 1/1] libnvdimm: Don't use GUID APIs against raw buffer
Message-ID: <YHnLCoeBDn3BcRx1@smile.fi.intel.com>
References: <20210415143754.16553-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210415143754.16553-1-andriy.shevchenko@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Apr 15, 2021 at 05:37:54PM +0300, Andy Shevchenko wrote:
> Strictly speaking the comparison between guid_t and raw buffer
> is not correct. Return to plain memcmp() since the data structures
> haven't changed to use uuid_t / guid_t the current state of affairs
> is inconsistent. Either it should be changed altogether or left
> as is.

Dan, please review this one as well. I think here you may agree with me.

-- 
With Best Regards,
Andy Shevchenko