Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: linux-next: Tree for Apr 16 (IMA appraise causing build error)
To:     Randy Dunlap <rdunlap@infradead.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
        Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
        Masahiro Yamada <masahiroy@kernel.org>
References: <20210416213625.14542675@canb.auug.org.au>
 <80839e94-f72c-4d2c-6b3a-b68beea72a27@infradead.org>
From:   Nayna <nayna@linux.vnet.ibm.com>
Message-ID: <3b06deaa-2ec1-88cd-87aa-970b9fa4315a@linux.vnet.ibm.com>
Date:   Fri, 16 Apr 2021 16:25:25 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <80839e94-f72c-4d2c-6b3a-b68beea72a27@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 4/16/21 2:53 PM, Randy Dunlap wrote:
> On 4/16/21 4:36 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20210415:
>>
> I noticed this build error message (on an i386 build):
>
> ../certs/Makefile:52: *** Could not determine digest type to use from kernel config.  Stop.
>
> and when I was checking on why it happened, I noticed that
> # CONFIG_MODULES is not set
>
> and hence
> ifndef CONFIG_MODULE_SIG_HASH
> $(error Could not determine digest type to use from kernel config)
> endif
>
> CONFIG_MODULE_SIG_HASH is not set/enabled/defined.
>
> However, the .config file does have
> CONFIG_IMA_APPRAISE=y
> # CONFIG_IMA_ARCH_POLICY is not set
> # CONFIG_IMA_APPRAISE_BUILD_POLICY is not set
> CONFIG_IMA_APPRAISE_BOOTPARAM=y
> CONFIG_IMA_APPRAISE_MODSIG=y
>
> as well as
> CONFIG_MODULE_SIG_FORMAT=y
>
> due to a "select" by IMA_APPRAISE_MODSIG.
> (although I see that MODULE_SIG_FORMAT does not depend on MODULES)
>
>
> Is there anything that you can do (or recommend) to prevent
> the build error?
>
>
>
> BTW, it looks like this:
> config IMA_APPRAISE_REQUIRE_MODULE_SIGS
> 	bool "Appraise kernel modules signatures"
> 	depends on IMA_APPRAISE_BUILD_POLICY
>
> could also depend on MODULES.
>
>
>
> Full i386 randconfig file is attached.


With the new patchset "ima: kernel build support for loading the kernel 
module signing key", there shouldn't be a difference when generating the 
config file between MODULE_SIG and IMA_APPRAISE_MODSIG. Both prompt for 
the hash algorithm.

Can you please explain how you generate randconfig? Do you use make xconfig?

Thanks & Regards,

     - Nayna