Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp605937pxb; Fri, 16 Apr 2021 13:29:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFFouiU8oZrfeibt9A4WLjiEq4B6jBoR1bj9KZeSN0fjzQjGd15zxLX8g2e5qMZfMWXL5H X-Received: by 2002:a63:360b:: with SMTP id d11mr718236pga.297.1618604970954; Fri, 16 Apr 2021 13:29:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618604970; cv=none; d=google.com; s=arc-20160816; b=yKAqH7RO3xOXhdSxFPWtylNuXZ9bAYYthqJmEGS9NanLlyjHh1fSpv1zop95m98hEh k6tC+gXaKxIfQ3rTyHbMHO5x7e/5eH5TmgrHflsMRrEj8xG7m7jaFJHjhz2rU/cUgqRW Wd3o/z9UtyDeJhmreaczRJRfrjQeZrOBb+vcA7Zu22ykFYP+ZZmYZmmQMOznpooj0nW7 w2/Emu21k89kNvNlDu8aDUsBmLmvnPQPgOloxQA3oTipmczV1LZ45T123zudYiu/VqHk lX94SnYBVC0EW/InVrataGFrjeV1ocDbBLib5Q/DwOruXrsfHNOXACNR6RUVE//kPCvB Dbfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from:dmarc-filter :sender:dkim-signature; bh=Z5idBwlQhEZLRZOuOyizkreWC2NX+mI+QplQa1hscsI=; b=RL2XzRt9NRvqUc7quMuUtIzI540XTKjUYNWGZgNVKksC+cFGAwAAPY8XR23kXyaAYr 1AwzGQonrmYqOeW4LnBaTCdXchDn1a9B3UGXQgmcc4mjY7zJ4k1EN8MPITy1SzsEdgl0 ZF+cxQshXz4TzvvmSSJ2HdoCG02HwbQFnebIVNFWBwF7yAaciXrC9B8T4bKnVj/LPYzn zWkJgMccZDNBQ41fk45oIqIajMSJK5SOTeg8saJ8RhlRG0m6S0cybrMjOkbW/cxuxIjn exwYR96r0C01c/Sij20ydZP1dypm77Mr0J3JpEX/TE5VL+VohodLjN4p1oCulq0yr+nx n0gQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=tdRYmcOC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x10si7519045pll.145.2021.04.16.13.29.18; Fri, 16 Apr 2021 13:29:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=tdRYmcOC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245407AbhDPU2k (ORCPT + 99 others); Fri, 16 Apr 2021 16:28:40 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:19917 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244843AbhDPU2i (ORCPT ); Fri, 16 Apr 2021 16:28:38 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1618604893; h=Message-Id: Date: Subject: Cc: To: From: Sender; bh=Z5idBwlQhEZLRZOuOyizkreWC2NX+mI+QplQa1hscsI=; b=tdRYmcOC/inCdp9Z0RoRwZcR5xICAk64SMB0aeD+dPlYoHpbSKcY3hl6XlgZsh96g7QLXi+r sPVVkVKbNoa3UJXOhCcEfrQS31rsjF5TcGVmt6puunVu/2CboVETmn7fOHhKmJfvpAjbT/8f 2zyBNYnh9HR51Q44hePGwIVDjw0= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 6079f35c2cc44d3aea4c9a9c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 16 Apr 2021 20:28:12 GMT Sender: khsieh=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 76AE4C433CA; Fri, 16 Apr 2021 20:28:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from khsieh-linux1.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: khsieh) by smtp.codeaurora.org (Postfix) with ESMTPSA id E6AB3C433C6; Fri, 16 Apr 2021 20:28:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E6AB3C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=khsieh@codeaurora.org From: Kuogee Hsieh To: robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org Cc: abhinavk@codeaurora.org, aravindh@codeaurora.org, khsieh@codeaurora.org, airlied@linux.ie, daniel@ffwll.ch, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending Date: Fri, 16 Apr 2021 13:27:57 -0700 Message-Id: <1618604877-28297-1-git-send-email-khsieh@codeaurora.org> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some dongle may generate more than one irq_hpd events in a short period of time. This patch will treat those irq_hpd events as single one and service only one irq_hpd event. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 5a39da6..0a7d383 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -707,6 +707,9 @@ static int dp_irq_hpd_handle(struct dp_display_private *dp, u32 data) return 0; } + /* only handle first irq_hpd in case of multiple irs_hpd pending */ + dp_del_event(dp, EV_IRQ_HPD_INT); + ret = dp_display_usbpd_attention_cb(&dp->pdev->dev); if (ret == -ECONNRESET) { /* cable unplugged */ dp->core_initialized = false; @@ -1300,6 +1303,9 @@ static int dp_pm_suspend(struct device *dev) /* host_init will be called at pm_resume */ dp->core_initialized = false; + /* system suspended, delete pending irq_hdps */ + dp_del_event(dp, EV_IRQ_HPD_INT); + mutex_unlock(&dp->event_mutex); return 0; @@ -1496,6 +1502,9 @@ int msm_dp_display_disable(struct msm_dp *dp, struct drm_encoder *encoder) /* stop sentinel checking */ dp_del_event(dp_display, EV_DISCONNECT_PENDING_TIMEOUT); + /* link is down, delete pending irq_hdps */ + dp_del_event(dp_display, EV_IRQ_HPD_INT); + dp_display_disable(dp_display, 0); rc = dp_display_unprepare(dp); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project