Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Apr 2021 18:53:33 +0100
Message-ID: <877dl22k0y.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Robert Hancock <robert.hancock@calian.com>
Cc:     "tglx@linutronix.de" <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "michal.simek@xilinx.com" <michal.simek@xilinx.com>
Subject: Re: [PATCH] irqchip/xilinx: Expose Kconfig option
In-Reply-To: <2834595e6552c81441592a57dc41146d46484143.camel@calian.com>
References: <20210415233250.4071772-1-robert.hancock@calian.com>
        <87zgxys5xn.wl-maz@kernel.org>
        <2834595e6552c81441592a57dc41146d46484143.camel@calian.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 16 Apr 2021 17:05:49 +0100,
Robert Hancock <robert.hancock@calian.com> wrote:
> 
> On Fri, 2021-04-16 at 14:41 +0100, Marc Zyngier wrote:
> > On Fri, 16 Apr 2021 00:32:50 +0100,
> > Robert Hancock <robert.hancock@calian.com> wrote:
> > > Previously the XILINX_INTC config option was hidden and only
> > > auto-selected on the MicroBlaze platform. However, this IP can also be
> > > used on other platforms. Allow this option to be user-enabled.
> > > 
> > > Signed-off-by: Robert Hancock <robert.hancock@calian.com>
> > 
> > I don't think this is a good idea. In general, people have no idea
> > which interrupt controller they need to select. So you either end-up
> > with a missing interrupt controller, or a bunch you really don't need.
> > 
> > This is essentially a platform constraint, and this should directly be
> > selected by the platform if you have this IP in your system.
> > 
> > Thanks,
> > 
> > 	M.
> 
> The problem is essentially that at the platform level, we don't know, other
> than in the MicroBlaze case where we know it will be used as the platform's
> primary interrupt controller. In our case, we are using this IP core on the
> ZynqMP platform as a secondary cascaded interrupt controller in the FPGA
> portion of the device.
> But many ZynqMP configurations wouldn't have this device present, it
> depends on what the user instantiates in the programmable logic.
> Also, this core could just as easily be instantiated in standalone
> Xilinx FPGAs which could be connected to many different platforms
> over a PCIe, AXI, etc.  bus.

Not compiling it for some users is great if you happen to *know* what
you have to select, which is probably a single digit percentage of the
people that build their own kernel. At least having it to depend on
ZYNQMP (or some other FPGA platform) would narrow it down.

And if you have some other HW in your FPGA, you can make the config
fragment for this HW select the right interrupt controller. But I'm
definitely not keen on making this a universally user-selectable
driver.

> So I don't think having this as a platform constraint makes sense.

I don't think imposing this on *everyone*, across all supported
architectures and platforms makes any sense. Surely, people who build
their own HW (because that's what we are talking about here) can be
bothered to add the small Kconfig fragment that is required to their
kernel build.

	M.

-- 
Without deviation from the norm, progress is not possible.