Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Apr 2021 20:33:36 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Tudor Ambarus <tudor.ambarus@microchip.com>
Cc:     <richard@nod.at>, <vigneshr@ti.com>, <kyungmin.park@samsung.com>,
        <michael@walle.cc>, <p.yadav@ti.com>, <jean-philippe@linaro.org>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: core: Constify buf in mtd_write_user_prot_reg()
Message-ID: <20210416203336.388878ad@xps13>
In-Reply-To: <20210403060931.7119-1-tudor.ambarus@microchip.com>
References: <20210403060931.7119-1-tudor.ambarus@microchip.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Tudor,

Tudor Ambarus <tudor.ambarus@microchip.com> wrote on Sat, 3 Apr 2021
09:09:31 +0300:

> The write buffer comes from user and should be const.
> Constify write buffer in mtd core and across all _write_user_prot_reg()
> users. cfi_cmdset_{0001, 0002} and onenand_base will pay the cost of an
> explicit cast to discard the const qualifier since the beginning, since
> they are using an otp_op_t function prototype that is used for both reads
> and writes. mtd_dataflash and SPI NOR will benefit of the const buffer
> because they are using different paths for writes and reads.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Applied on top of mtd/next after the merge of all our internal PR's.

Thanks,
Miquèl