Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 2ji2sd3hPn/z5JmLUtzVdRO6d6MnNtXwxonJaDdiHgbPdyzkuX4PO9KKWhUN89HvpfDInpHCmt
 jMh0mq0HyNWMQcHDPXvwBw9RwLP2K+43rjy66n5Zdx4gncJxPfFknnTotoRmVhIIrp+8rygzkI
 RcmK1c6D2ORYZvpKXJDbK2zE7a+hxwtxnraT62SImCxvQOpIesM/k5deUnN2gLscX0TypX8hrd
 +K0RkPd4TKlCfjx4y7Js+B4Rfhii1Wqp9J8JORh8DZvRAIyX9+BFsdLKzDogCSX61aBnkykCvH
 EcE=
IronPort-SDR: jFg8ZE9+a7RnCtKJBTDKPDH0YQFiiYc+RLe2/ggtktSLzGuW0l+JkHEi53dYP+aw07dknhIVx/
 Nstud1eYgA0yQrQUT2PKgRpB8az4JrJ3mJzXJIbPNG98dmTr+8xZPhCf6ztEQXeD1lGwx/sc/j
 StVhBPwXHyPvDpH8qFSMhUHOPnaypY8tGTZ1DkZE3KR78Yri76n+HVwDrluFa/tdu11JQg6dLS
 cyElu2wKDZYx3Zzd53PsYMHJ4Z3BvSBDK7ffFu4iV+hSPJgqevNFRilwJbi+CPQDKoLCzYhGqZ
 7D8VePHUrt8afPohCGbYNQyC
IronPort-SDR: YHPDjhLsFx+LE0qZcYne9xelQgeX9OMP5X2ZphNVvunYaGLHeFJ1mCFHZFOA/iQiLF2zhhcXtU
 MEAGtd/1IXUQhhFZGoLVY2ThXNO1MzxOiMJScd5bDoDEfzVMxvvrVaNrWmIdMhP3yLGwzOaSOh
 JjUOY2qcSvRBSUP0dNuwngB8KtonYjb3AgqCKor6so+znxZFYwrDssokH9eqmSVqCnraHD0Tp1
 S5MQizOFLgkC6Xt5jU+v1SpBuftnhWhyTAsq0iwzjBdeCH+jUh9mVfA89HbeqlscP9/x+zmNiw
 JxQ=
WDCIronportException: Internal
From:   Damien Le Moal <damien.lemoal@wdc.com>
To:     uclinux-dev@uclinux.org, Greg Ungerer <gerg@linux-m68k.org>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        linux-riscv@lists.infradead.org
Cc:     linux-kernel@vger.kernel.org, Anup Patel <anup.patel@wdc.com>,
        Christoph Hellwig <hch@lst.de>
Subject: [PATCH v4 2/2] riscv: Disable data start offset in flat binaries
Date:   Sat, 17 Apr 2021 10:10:09 +0900
Message-Id: <20210417011009.54569-3-damien.lemoal@wdc.com>
In-Reply-To: <20210417011009.54569-1-damien.lemoal@wdc.com>
References: <20210417011009.54569-1-damien.lemoal@wdc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

uclibc/gcc combined with elf2flt riscv linker file fully resolve the
PC relative __global_pointer$ value at compile time and do not generate
a relocation entry to set a correct value of the gp register at runtime.
As a result, if the flatbin loader offsets the start of the data
section, the relative position change between the text and data sections
compared to the compile time positions results in an incorrect gp value
being used. This causes flatbin executables to crash.

Avoid this problem by enabling CONFIG_BINFMT_FLAT_NO_DATA_START_OFFSET
automatically when CONFIG_RISCV is enabled and CONFIG_MMU is disabled.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
 arch/riscv/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index 4515a10c5d22..add528eb9235 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -33,6 +33,7 @@ config RISCV
 	select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT if MMU
 	select ARCH_WANT_FRAME_POINTERS
 	select ARCH_WANT_HUGE_PMD_SHARE if 64BIT
+	select BINFMT_FLAT_NO_DATA_START_OFFSET if !MMU
 	select CLONE_BACKWARDS
 	select CLINT_TIMER if !MMU
 	select COMMON_CLK
-- 
2.30.2