Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1618197759-128087-1-git-send-email-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <1618197759-128087-1-git-send-email-jiapeng.chong@linux.alibaba.com>
From:   Julian Calaby <julian.calaby@gmail.com>
Date:   Sat, 17 Apr 2021 16:34:54 +1000
Message-ID: <CAGRGNgVucQWcGiUnWtsC=oRDXrWkQ13CFojOcM7xU+4TukUoOA@mail.gmail.com>
Subject: Re: [PATCH] scsi: a100u2w: remove useless variable
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     "James E. J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Linux SCSI List <linux-scsi@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Jiapeng,

On Mon, Apr 12, 2021 at 1:23 PM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following gcc warning:
>
> drivers/scsi/a100u2w.c:1092:8: warning: variable =E2=80=98bios_phys=E2=80=
=99 set but not
> used [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/scsi/a100u2w.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c
> index 66c5143..855a3fe 100644
> --- a/drivers/scsi/a100u2w.c
> +++ b/drivers/scsi/a100u2w.c
> @@ -1089,7 +1089,6 @@ static int inia100_probe_one(struct pci_dev *pdev,
>         int error =3D -ENODEV;
>         u32 sz;
>         unsigned long biosaddr;
> -       char *bios_phys;
>
>         if (pci_enable_device(pdev))
>                 goto out;
> @@ -1141,7 +1140,7 @@ static int inia100_probe_one(struct pci_dev *pdev,
>
>         biosaddr =3D host->BIOScfg;
>         biosaddr =3D (biosaddr << 4);
> -       bios_phys =3D phys_to_virt(biosaddr);
> +       phys_to_virt(biosaddr);

Does phys_to_virt() have side effects? If it doesn't, there's a lot
more stuff that can get deleted here.

Thanks,

--=20
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/