Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1009495pxb; Sat, 17 Apr 2021 04:00:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzi3PeYgPn6Lg55JBE1X//y18x6WldblrRNBRTotD6e90lCbYj8RnUUZAA0aGSh16QdQlkd X-Received: by 2002:a17:902:59ce:b029:eb:2262:d5c6 with SMTP id d14-20020a17090259ceb02900eb2262d5c6mr14298664plj.77.1618657204275; Sat, 17 Apr 2021 04:00:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618657204; cv=none; d=google.com; s=arc-20160816; b=U+4uJs8rFbMiUc/Ffmx+322gxK1Ec0/wOeDG1ZAqtk5FoQ/ERzCP5W/qiTI3kgRsp4 OXIYWEV5EVS9iEcHKkjRThJKtwpkhmpZHLzj8Wc2WYHMjm+um+KnM99JOf2mIpe4TfzZ 6fYeBuaH2Ntsp7Ww5+I+q0EpV2QmFU8BaXdGHQuEZSgZs9/6PWPXLmeM97Ae9a7ggZLY HgvGnAzv8mOj6jhAHgt9cMlnMblhTEdswIWuWM4ValwaUvS5vWDmshNqzk/OOsIAtyw9 t4EmnxQTXlCIsiyScSqwZQpYrVuA1iBjfXb4at3NFey/fXWdrViklPXc/rJMYxjX+9Q4 pyFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=6UnepjopnJiqlBeRwokEI+rZdMEiDlM4idHpRMkX0Po=; b=k/M45KV1XUBixIPulM2VnG8CoaNAzaFUxRqbA5nmKr6sLNU8WvBNJRvXumgomtib/X KckU3gkb1vODzgqdxTjAxR4e9VTO/I2UUloX9qrwAlhKlKfjcUpPTHAmXvnSG9U3Szw2 kdwYcpyAXWZ11AnUI4HynnIUecB4xmvdZofJK0Cx5nc8wzUFHqC3xFVDKLlqRiydfUhG 7FVPz+uS47VP4NV62EdL1EYSjVGD1OHkIqnEps3nhN2wqLD1uU6WJbbaqD8OXyjQKGrn HzWeRdxeIUAz1Q999dl0WCNHBsYVJ9ULOPwmjZ9vc6q9e+VW8xk8l1WKEaQMIYmcRIAq eOww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r15si9805704pgv.80.2021.04.17.03.59.51; Sat, 17 Apr 2021 04:00:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231387AbhDQK7n convert rfc822-to-8bit (ORCPT + 99 others); Sat, 17 Apr 2021 06:59:43 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:48947 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230510AbhDQK7l (ORCPT ); Sat, 17 Apr 2021 06:59:41 -0400 Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-153-fX_eEiD9OBC36ZMNcm5hsg-1; Sat, 17 Apr 2021 11:59:11 +0100 X-MC-Unique: fX_eEiD9OBC36ZMNcm5hsg-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 17 Apr 2021 11:59:10 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.015; Sat, 17 Apr 2021 11:59:10 +0100 From: David Laight To: 'Matthew Wilcox' , Jesper Dangaard Brouer CC: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , Ilias Apalodimas , Matteo Croce , Grygorii Strashko , Arnd Bergmann , "Christoph Hellwig" Subject: RE: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems Thread-Topic: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems Thread-Index: AQHXMXYmwdfrgigLI0exh4xFUSZq9Kq0jZ3ggAK59KGAAUYTcA== Date: Sat, 17 Apr 2021 10:59:09 +0000 Message-ID: References: <20210410205246.507048-2-willy@infradead.org> <20210411114307.5087f958@carbon> <20210411103318.GC2531743@casper.infradead.org> <20210412011532.GG2531743@casper.infradead.org> <20210414101044.19da09df@carbon> <20210414115052.GS2531743@casper.infradead.org> <20210414211322.3799afd4@carbon> <20210414213556.GY2531743@casper.infradead.org> <20210415200832.32796445@carbon> <20210416152755.GL2531743@casper.infradead.org> In-Reply-To: <20210416152755.GL2531743@casper.infradead.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthew Wilcox > Sent: 16 April 2021 16:28 > > On Thu, Apr 15, 2021 at 08:08:32PM +0200, Jesper Dangaard Brouer wrote: > > See below patch. Where I swap32 the dma address to satisfy > > page->compound having bit zero cleared. (It is the simplest fix I could > > come up with). > > I think this is slightly simpler, and as a bonus code that assumes the > old layout won't compile. Always a good plan. ... > static inline dma_addr_t page_pool_get_dma_addr(struct page *page) > { > - return page->dma_addr; > + dma_addr_t ret = page->dma_addr[0]; > + if (sizeof(dma_addr_t) > sizeof(unsigned long)) > + ret |= (dma_addr_t)page->dma_addr[1] << 32; > + return ret; > +} Won't some compiler/option combinations generate an error for the '<< 32' when dma_addr_t is 32bit? You might need to use a (u64) cast. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)