Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1070272pxb; Sat, 17 Apr 2021 05:52:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzr1i4Efjs8cvyZN5XgqK5O7qXY2ims/GgV2guEsW4Z7kAwDw9lxVZ478uGA5+7xgub6rbM X-Received: by 2002:a17:902:e851:b029:eb:1fd0:fa8e with SMTP id t17-20020a170902e851b02900eb1fd0fa8emr14405693plg.38.1618663946134; Sat, 17 Apr 2021 05:52:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618663946; cv=none; d=google.com; s=arc-20160816; b=IDdbSrAZPsLEw9eDDsDSvkavbiW7MKsPA7V+bHWyDMxIjc65+c8YI2HDOcTl0ocNyX fRBYU7fPediJb7I458C7JcEpcIXWqfreROToNNB/cDDFXodxY2296mt/N3O9QWsHebHf AWdrWPnI1lYAyjSa0hVHrXLHfYpKF6qyThXM9DFFIUwYcacThS5H/Wag88qlkBKxdVUd DHXSqeWY/4nVEnXs4jTGxjp5UtyGvSEcrPjnlOUwsKM5eL9tm42JDalZkZZ6LyTq11WU JVmbuhIbogpVHCtaOIL3rwgHtuql3iajhc8IF7Xcrt8sgDiwR6ftlDtoVhZB42A58+zg 05BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=CK9W0sv6eRHdyCB5RWUgu3S7S7hJ78bLj/lTgSuLMhU=; b=RezyQpR8nN+FB4m4VcsLYs6OJjZKuyruVNcmyEVWNgEk07Kwy/UUxIdaalJUlG3Ko2 XQ2AOY17o2f9EUjkqAF5BE5GqFaAV0nFz2BIH9YHE9fBIiCvtdBHdEZIOanh92nXf3Wz KH8MDu/ax3GkkOy8hRHzXKtnUWAzh5muh04acsTIP/88Zjx79tzjLOR8iBjpaAHWq65o XcJT9zds3GIgzHeh2k1j8dmOas08eqzQDz6NafMsQ8QgfpYxrIrDbK1MuYQiLf2Sa8EZ BrsqZEcAxdQbsdgxfxvxPUFqm+u6PDLkLr86snTd389i0STUxsBcbnQoRUdxE5xwaZCR A/XA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YEKvlLpx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lk18si11863215pjb.95.2021.04.17.05.52.13; Sat, 17 Apr 2021 05:52:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YEKvlLpx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236265AbhDQMwG (ORCPT + 99 others); Sat, 17 Apr 2021 08:52:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230442AbhDQMwF (ORCPT ); Sat, 17 Apr 2021 08:52:05 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70740C061574; Sat, 17 Apr 2021 05:51:39 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id j7so11596318pgi.3; Sat, 17 Apr 2021 05:51:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CK9W0sv6eRHdyCB5RWUgu3S7S7hJ78bLj/lTgSuLMhU=; b=YEKvlLpxuA4qNW5N1A3VDiigeTuCGS9cKk174L9rxmXIobdMp0C7YWpk5yoDt9X2sT gSS+4b/VwsW+PdGgUnCHq6JHcVgHXA5MrwfN5X5J6Sp3g7xxLGrG1AnK5KEVZxIj7aTA V/am8e5y8NUfoE/md1jvr0CBPGpOmIU2aX3tKum/9FEYW/S7O7WCsmxS0tgAhjRYN9R1 KAHrYRBINWhNmZz8mjrEvtYl4qnzw0ZvoBEW57uAfkHOerOhl3UWiTtg2UOk8RfdDacC ea7xcV3T+OtVWJUru2i52pgTgNsGKTbVezg4nxNXyl879Ipp/Vxe5Pz2JJm+mVpmZig8 2Pig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CK9W0sv6eRHdyCB5RWUgu3S7S7hJ78bLj/lTgSuLMhU=; b=spAoOgYmTp3gOto+DBEsm2hpAtJjE28XBfVgTCJ/Z2k9dLWQ1HQG23b6hpIZ/hcVfA ++HGlb7JHWhelN9uyjZhUZIBNN/MCqiCOUNnEIXQ691t0jg/EvfKSu8iIE9kbsrcoRzF vPnGqrkMoTSt94fAR1ztcz2B5w9t2t6ujkihPWx2PN8UBvRekcVLAyGbRBAXpNSl3WJc m6Bmc9/QEslx7ay115zWanA0p/vKxmA/fH7cYSwS2nI9y7UwXjUNOc9PHykjunJbhM2a 8qVAyv1M6qaToio+moEUe9AtmCnVTNxWJAXydhRBiHb7qDR+eucNnSQ4EqV8XttFpUcb 2OOw== X-Gm-Message-State: AOAM533s0VR++MoIbsSk46MxCbcgIMiLSblwHm/JopM01h53H+rL/Sqo f2aaErRy0F5phZ2x4my9uAwkw9ogMhqZdsPShaU= X-Received: by 2002:a63:cb44:: with SMTP id m4mr3432862pgi.4.1618663898587; Sat, 17 Apr 2021 05:51:38 -0700 (PDT) MIME-Version: 1.0 References: <20210416174902.9036-1-joe.g.sandom@gmail.com> <20210416174902.9036-2-joe.g.sandom@gmail.com> In-Reply-To: <20210416174902.9036-2-joe.g.sandom@gmail.com> From: Andy Shevchenko Date: Sat, 17 Apr 2021 15:51:22 +0300 Message-ID: Subject: Re: [PATCH v8 2/2] Added AMS tsl2591 device tree binding To: Joe Sandom Cc: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , linux-iio , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 16, 2021 at 8:49 PM Joe Sandom wrote: > > Device tree binding for AMS/TAOS tsl2591 ambient light sensor. > > This driver supports configuration via device tree and sysfs. > Supported channels for raw infrared light intensity, > raw combined light intensity and illuminance in lux. > The driver additionally supports iio events on lower and > upper thresholds. > > This is a very-high sensitivity light-to-digital converter that > transforms light intensity into a digital signal. With subject line fixed (other comments up to you) Reviewed-by: Andy Shevchenko > Signed-off-by: Joe Sandom > Reviewed-by: Rob Herring > --- > Changes in v8: > - No changes > > Notes: > - Re-submitted to align the version with part 1 of the patch series > > .../bindings/iio/light/amstaos,tsl2591.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/light/amstaos,tsl2591.yaml > > diff --git a/Documentation/devicetree/bindings/iio/light/amstaos,tsl2591.yaml b/Documentation/devicetree/bindings/iio/light/amstaos,tsl2591.yaml > new file mode 100644 > index 000000000000..596a3bc770f4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/light/amstaos,tsl2591.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/light/amstaos,tsl2591.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AMS/TAOS TSL2591 Ambient Light Sensor (ALS) > + > +maintainers: > + - Joe Sandom > + > +description: | > + AMS/TAOS TSL2591 is a very-high sensitivity > + light-to-digital converter that transforms light intensity into a digital > + signal. > + > +properties: > + compatible: > + const: amstaos,tsl2591 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + description: > + Interrupt (INT:Pin 2) Active low. Should be set to IRQ_TYPE_EDGE_FALLING. > + interrupt is used to detect if the light intensity has fallen below > + or reached above the configured threshold values. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + tsl2591@29 { > + compatible = "amstaos,tsl2591"; > + reg = <0x29>; > + interrupts = <20 IRQ_TYPE_EDGE_FALLING>; > + }; > + }; > +... > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko