Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Mark Rutland' <mark.rutland@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        "will@kernel.org" <will@kernel.org>
CC:     He Zhe <zhe.he@windriver.com>, "oleg@redhat.com" <oleg@redhat.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "paul@paul-moore.com" <paul@paul-moore.com>,
        "eparis@redhat.com" <eparis@redhat.com>,
        "linux-audit@redhat.com" <linux-audit@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle
 compat
Thread-Topic: [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle
 compat
Thread-Index: AQHXMsVKs7ekp24ri06bsZbID/QU96q4sqsA
Date:   Sat, 17 Apr 2021 13:19:02 +0000
Message-ID: <ba281040abc146fca5a2117d5476aa1b@AcuMS.aculab.com>
References: <20210416075533.7720-1-zhe.he@windriver.com>
 <20210416123322.GA23184@arm.com> <20210416133431.GA2303@C02TD0UTHF1T.local>
In-Reply-To: <20210416133431.GA2303@C02TD0UTHF1T.local>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Mark Rutland
> Sent: 16 April 2021 14:35
..
> @@ -51,13 +48,7 @@ static inline void syscall_set_return_value(struct task_struct *task,
>  					    struct pt_regs *regs,
>  					    int error, long val)
>  {
> -	if (error)
> -		val = error;
> -
> -	if (is_compat_thread(task_thread_info(task)))
> -		val = lower_32_bits(val);
> -
> -	regs->regs[0] = val;
> +	regs->regs[0] = (long) error ? error : val;

	= error ? (long)error : rval;

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)