Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 17 Apr 2021 11:31:04 -0400
From:   Alan Stern <stern@rowland.harvard.edu>
To:     liulongfang <liulongfang@huawei.com>
Cc:     gregkh@linuxfoundation.org, mathias.nyman@intel.com,
        liudongdong3@huawei.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, kong.kongxinwei@hisilicon.com,
        yisen.zhuang@huawei.com
Subject: Re: [RFC PATCH] USB:XHCI:skip hub registration
Message-ID: <20210417153104.GA73141@rowland.harvard.edu>
References: <1618489358-42283-1-git-send-email-liulongfang@huawei.com>
 <20210415144323.GC1530055@rowland.harvard.edu>
 <3dad6f4f-6386-427c-c36c-7d26b9a76fa4@huawei.com>
 <20210416152021.GA42403@rowland.harvard.edu>
 <547e07d6-ae62-1225-7483-754bf57ed1d2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <547e07d6-ae62-1225-7483-754bf57ed1d2@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Sat, Apr 17, 2021 at 02:48:22PM +0800, liulongfang wrote:
> On 2021/4/16 23:20, Alan Stern wrote:
> > On Fri, Apr 16, 2021 at 10:03:21AM +0800, liulongfang wrote:
> >> The current method is an improved method of the above patch.
> >> This patch just make it skip registering USB-3 root hub if that hub has no ports,
> > 
> > No, that isn't what this patch does.
> > 
> > If the root hub wasn't registered, hub_probe wouldn't get called.  But 
> > with your patch, the system tries to register the root hub, and it does 
> > call hub_probe, and then that function fails with a warning message.
> > 
> > The way to _really_ akip registering the root hub is to change the 
> > xhci-hcd code.  Make it skip calling usb_add_hcd.
> > 
> 
> If you do not register in the root hub, this will return an error code,

What will return an error code?  Are you talking about xhci_pci_probe()?  
You oight to be able to figure out how to make it work.

> which will make all the XHCI drivers unregister, causing the USB2.0 controllers
> on the xhci to be unavailable.

Alan Stern