Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422957AbWJQKzR (ORCPT ); Tue, 17 Oct 2006 06:55:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422935AbWJQKzR (ORCPT ); Tue, 17 Oct 2006 06:55:17 -0400 Received: from emailer.gwdg.de ([134.76.10.24]:31718 "EHLO emailer.gwdg.de") by vger.kernel.org with ESMTP id S1422852AbWJQKzO (ORCPT ); Tue, 17 Oct 2006 06:55:14 -0400 Date: Tue, 17 Oct 2006 12:40:31 +0200 (MEST) From: Jan Engelhardt To: Josef Jeff Sipek cc: Andrew James Wade , Linux Kernel Mailing List , Andrew Morton , Linus Torvalds , hch@infradead.org, Al Viro , linux-fsdevel@vger.kernel.org, Pekka Enberg , ezk@cs.sunysb.edu, mhalcrow@us.ibm.com Subject: Re: [PATCH 1 of 2] fsstack: Introduce fsstack_copy_{attr,inode}_* In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Report: Content analysis: 0.0 points, 6.0 required _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 34 >To: null@josefsipek.net (Superb idea to prekill any Cc, re-adding them) >+void __fsstack_copy_attr_all(struct inode *dest, >+ const struct inode *src, >+ int (*get_nlinks)(struct inode *)) >+{ >[big] >+} >+ >+/* externs for fs/stack.c */ >+extern void __fsstack_copy_attr_all(struct inode *dest, >+ const struct inode *src, >+ int (*get_nlinks)(struct inode *)); >+ >+static inline void fsstack_copy_attr_all(struct inode *dest, >+ const struct inode *src) >+{ >+ __fsstack_copy_attr_all(dest, src, NULL); >+} Do we really need this indirection? Can't __fsstack_copy_attr_all be named fsstack_copy_attr_all instead? -`J' -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/