Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 17 Apr 2021 21:51:50 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Clemens Gruber <clemens.gruber@pqgruber.com>
Cc:     linux-pwm@vger.kernel.org,
        Thierry Reding <thierry.reding@gmail.com>,
        Sven Van Asbroeck <TheSven73@gmail.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 1/8] pwm: pca9685: Switch to atomic API
Message-ID: <20210417195150.5fdcpxfbasp4y264@pengutronix.de>
References: <20210415121455.39536-1-clemens.gruber@pqgruber.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ff2fxzbhzbuvas53"
Content-Disposition: inline
In-Reply-To: <20210415121455.39536-1-clemens.gruber@pqgruber.com>
Precedence: bulk


--ff2fxzbhzbuvas53
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 15, 2021 at 02:14:48PM +0200, Clemens Gruber wrote:
> The switch to the atomic API goes hand in hand with a few fixes to
> previously experienced issues:
> - The duty cycle is no longer lost after disable/enable (previously the
>   OFF registers were cleared in disable and the user was required to
>   call config to restore the duty cycle settings)
> - If one sets a period resulting in the same prescale register value,
>   the sleep and write to the register is now skipped
> - Previously, only the full ON bit was toggled in GPIO mode (and full
>   OFF cleared if set to high), which could result in both full OFF and
>   full ON not being set and on=3D0, off=3D0, which is not allowed accordi=
ng
>   to the datasheet
> - The OFF registers were reset to 0 in probe, which could lead to the
>   forbidden on=3D0, off=3D0. Fixed by resetting to POR default (full OFF)
>=20
> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>

(I sent my ack to v8 before, but indeed this was the version I intended
to ack)

Acked-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>


--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--ff2fxzbhzbuvas53
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmB7PFMACgkQwfwUeK3K
7AkQFAf7Bf/gV7qahl2vQAfHsWkDcCGR5BJfoJKbbHbYDThTeEVojA/x8LgbaH9g
QThc4OEKrQvwaikwerXHKTbDXWZkGY3rGuf6aAzOg9Ue3BplgNSovkdePziavycG
E16uyTFhuupd3AEJ0lkBcsDG6TFJ4jyD0LEJP3EJNpHcXpZCV1fzBqVNa8kH14Gj
DyUkQqfvJUc0bhuGV1PSn7WjFJyOIDFRFfTamq/Qn/cVBV9Pljz+kR6r1+OJS/Gu
qvZPBSoQ/6Vv+nZiLb9FNPvfAd4P1e9ip6+mA1BZ6J3DQVEkkX2JLZh2LVMPSPnY
c0plbd/hg15dojJWZglR/afI/DjrwA==
=k/RB
-----END PGP SIGNATURE-----

--ff2fxzbhzbuvas53--