Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2136812pxb; Sun, 18 Apr 2021 20:27:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXkvtI9YOlIR6d3hW1GLd8UsorsEi4sP6ZBb9hfDpx7+mQACmWbddWV1T52w8++xXuiSSx X-Received: by 2002:a65:5203:: with SMTP id o3mr9658546pgp.305.1618802853010; Sun, 18 Apr 2021 20:27:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618802853; cv=none; d=google.com; s=arc-20160816; b=tyt+FAk+ElXyl8pqLNv0Jf8o7WH6iYzhfR6zUWxRktITzwFzRYNmoQEdSiQNa84d3T XWnlJeOcNucmlJ1ZLKqhXgrPUEO0ZoQNgrGLxykmwZfRnw5F8S3NQ6A641AZhOouoPyd tLsHLQRCg5ibie0Zfq1bMFUxzT7CZ1Odp8m4KtHVhlWZgHpYbgGOzIjm4FHKi0myrMgr X2eHZuGed5DMKYIyp9J0V26Pz/pJovfnQpkLFhgceHfmVMOftivD70EkISRXRvovXHKm mm2jszpGzzK8AbnM+h0lO9ZlAHqq1+TmMeEt/B26jzkZdVGzkOGdEuAU9tidTVWfvnNV 9trg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wF5Ti3p6ukxFBbnOErN0GEWkYJORujrGl5v+prvaUz0=; b=Xyp8UhBuz4I8qvdHkcARNPiszpyDB/s7+fOKHysW0WFLMY8KcExhEkqwVqGGxx07f6 9D62Fzw++sxPE9MMnelhFaILOYu4SOb9uJwaft8Q7xmUROMEgEBNOjq6oBmaRKlTwpuz Lj5KiUuMM/jGwggCCQoNdb4HVmR2hf46D7wfmkVUFST5SYB3eH/7ASoYr6+3+PfdSUhI CzSHscF/+zpaj2cSkTdD4L1wBQ3LhljwgqLsIrcenwcb9uy/rzJrfC8pPEhRQaDj+bNk uvPXRWgk37s1IbPvHw7avQ88lG3ENNWErYnKrhCRuQyIBrXxwIjVfmu8H2kBCcPR8eq8 LnBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=dYIGAGcY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bh11si15750919plb.256.2021.04.18.20.27.18; Sun, 18 Apr 2021 20:27:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=dYIGAGcY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237297AbhDSD1H (ORCPT + 99 others); Sun, 18 Apr 2021 23:27:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237377AbhDSD03 (ORCPT ); Sun, 18 Apr 2021 23:26:29 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E115DC06174A; Sun, 18 Apr 2021 20:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wF5Ti3p6ukxFBbnOErN0GEWkYJORujrGl5v+prvaUz0=; b=dYIGAGcYlNbN2NQppzgNkikKhg PnPCMz45ytddxiSTkgLS7zacFZxpmcMQC3jAp+uN4QTTlXXGK2aUbuvkAgjfWG1ASsMxc/2mnVU7j pUvoft2tkI1gm6TtpVV16Ard9CweevBNvpMYqIleos42dDFi23wYZ8gslx4fyK2oBC9sQOzqgFosX STUB7UudxPMxRJ8yVnRb6yJaSDOhjeoZPr3i/M8tLPIXryTVaj42PgmXRyGB3P5Wk1Ug30gRFuMe9 1MrYPpYOb1lEUzD+XC8/sKDgdrYNKFS+ij1sfSfn/uS+u//uHP3U4PSg+SSV05Ek5y6ejifOQXDTI y/SwOkcw==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lYKXB-00D9dR-5t; Mon, 19 Apr 2021 03:25:18 +0000 Date: Mon, 19 Apr 2021 04:25:13 +0100 From: Matthew Wilcox To: Fox Chen Cc: Neil Brown , Jonathan Corbet , vegard.nossum@oracle.com, Al Viro , rdunlap@infradead.org, grandmaster@al2klimov.de, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Greg KH Subject: Re: [PATCH v2 01/12] docs: path-lookup: update follow_managed() part Message-ID: <20210419032513.GW2531743@casper.infradead.org> References: <20210316054727.25655-1-foxhlchen@gmail.com> <20210316054727.25655-2-foxhlchen@gmail.com> <20210419021730.GV2531743@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 19, 2021 at 10:33:00AM +0800, Fox Chen wrote: > On Mon, Apr 19, 2021 at 10:17 AM Matthew Wilcox wrote: > > > > On Tue, Mar 16, 2021 at 01:47:16PM +0800, Fox Chen wrote: > > > -In the absence of symbolic links, ``walk_component()`` creates a new > > > +As the last step of ``walk_component()``, ``step_into()`` will be called either > > > > You can drop ``..`` from around function named which are followed with > > (). d74b0d31ddde ("Docs: An initial automarkup extension for sphinx") > > marks them up automatically. > > > > Got it, thanks for letting me know. But I will still use them in this > patch series to keep consistency with the remaining parts of the > document. Well, you weren't. For example: +As the last step of ``walk_component()``, ``step_into()`` will be called either +directly from walk_component() or from handle_dots(). It calls +``handle_mount()``, to check and handle mount points, in which a new Neither of the functions on the second line were using ``.